powerpc/44x: Set GPIO chip firmware node

[PATCH] powerpc/44x: Set GPIO chip firmware node

Posted by Rosen Penev 1 week, 2 days ago

The PPC4xx GPIO driver stopped assigning an explicit firmware node
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

Assisted-by: Codex:GPT-5.5
Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/powerpc/platforms/44x/gpio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x/gpio.c
index d5824b7747b3..4d5176aa6895 100644
--- a/arch/powerpc/platforms/44x/gpio.c
+++ b/arch/powerpc/platforms/44x/gpio.c
@@ -169,6 +169,8 @@ static int ppc4xx_gpio_probe(struct platform_device *ofdev)
 
 	gc = &chip->gc;
 
+	gc->parent = dev;
+	gc->fwnode = dev_fwnode(dev);
 	gc->base = -1;
 	gc->ngpio = 32;
 	gc->direction_input = ppc4xx_gpio_dir_in;
-- 
2.54.0

Re: [PATCH] powerpc/44x: Set GPIO chip firmware node

Posted by Linus Walleij 1 week, 1 day ago

On Sat, May 16, 2026 at 1:19 AM Rosen Penev <rosenp@gmail.com> wrote:

> The PPC4xx GPIO driver stopped assigning an explicit firmware node
> to the gpio_chip when it moved away from of_mm_gpiochip_add_data().
>
> Restore that association from the platform device so OF GPIO lookup
> can match phandles to the registered gpiochip.
>
> Tested on: Cisco MX60W. No more probe deferral.
>
> Assisted-by: Codex:GPT-5.5
> Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [PATCH] powerpc/44x: Set GPIO chip firmware node

Posted by Rosen Penev 1 week, 1 day ago

On Sat, May 16, 2026 at 7:55 AM Linus Walleij <linusw@kernel.org> wrote:
>
> On Sat, May 16, 2026 at 1:19 AM Rosen Penev <rosenp@gmail.com> wrote:
>
> > The PPC4xx GPIO driver stopped assigning an explicit firmware node
> > to the gpio_chip when it moved away from of_mm_gpiochip_add_data().
> >
> > Restore that association from the platform device so OF GPIO lookup
> > can match phandles to the registered gpiochip.
> >
> > Tested on: Cisco MX60W. No more probe deferral.
> >
> > Assisted-by: Codex:GPT-5.5
> > Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
>
> Reviewed-by: Linus Walleij <linusw@kernel.org>
dev was needed, not fwnode. Which makes sense as this is specified in dts.

https://patch.msgid.link/20260427-gpio-mmio-more-v3-1-fe1882351424@kernel.org
fixes this but that's not in a released kernel.
>
> Yours,
> Linus Walleij