net: phy: micrel: use dev_err_probe()

[PATCH net-next] net: phy: micrel: use dev_err_probe()

Posted by Robert Marko 3 weeks, 6 days ago

Currently, during probe defferal the driver will print multiple times:
mscc-miim e20101a8.mdio: Cannot register MDIO bus (-517)

So, lets silence that by using the dev_err_probe() for printing the probe
error as it handles probe defferal.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 drivers/net/mdio/mdio-mscc-miim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c
index 944efd33da6d..259944d37fbd 100644
--- a/drivers/net/mdio/mdio-mscc-miim.c
+++ b/drivers/net/mdio/mdio-mscc-miim.c
@@ -330,7 +330,7 @@ static int mscc_miim_probe(struct platform_device *pdev)
 
 	ret = of_mdiobus_register(bus, np);
 	if (ret < 0) {
-		dev_err(dev, "Cannot register MDIO bus (%d)\n", ret);
+		dev_err_probe(dev, ret, "Cannot register MDIO bus\n");
 		goto out_disable_clk;
 	}
 
-- 
2.54.0

Re: [PATCH net-next] net: phy: micrel: use dev_err_probe()

Posted by Andrew Lunn 3 weeks, 6 days ago

On Fri, May 15, 2026 at 02:05:40PM +0200, Robert Marko wrote:
> Currently, during probe defferal the driver will print multiple times:
> mscc-miim e20101a8.mdio: Cannot register MDIO bus (-517)
> 
> So, lets silence that by using the dev_err_probe() for printing the probe
> error as it handles probe defferal.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew