[v1] net: ag71xx: check error for platform_get_irq

[PATCH net] net: ag71xx: check error for platform_get_irq

Rosen Penev posted 1 patch 4 weeks ago

Diff against v2
Download mbox

There is a newer version of this series

drivers/net/ethernet/atheros/ag71xx.c | 3 +++
1 file changed, 3 insertions(+)

Expand all Fold all

[PATCH net] net: ag71xx: check error for platform_get_irq

Posted by Rosen Penev 4 weeks ago

Exit probe if the proper IRQ cannot be found.

Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/ethernet/atheros/ag71xx.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
index a5ab99474179..4e4794c4dfdc 100644
--- a/drivers/net/ethernet/atheros/ag71xx.c
+++ b/drivers/net/ethernet/atheros/ag71xx.c
@@ -1856,6 +1856,9 @@ static int ag71xx_probe(struct platform_device *pdev)
 	ag71xx_int_disable(ag, AG71XX_INT_POLL);
 
 	ndev->irq = platform_get_irq(pdev, 0);
+	if (ndev->irq < 0)
+		return ndev->irq;
+
 	err = devm_request_irq(&pdev->dev, ndev->irq, ag71xx_interrupt,
 			       0x0, dev_name(&pdev->dev), ndev);
 	if (err) {
-- 
2.54.0

Re: [PATCH net] net: ag71xx: check error for platform_get_irq

Posted by Markus Elfring 4 weeks ago

> Exit probe if the proper IRQ cannot be found.

Would a summary phrase like “Complete error handling for a failed platform_get_irq() call”
be nicer?

Regards,
Markus