1. Patchew
  2. linux
  3. View series

[PATCH] dt-bindings: nvmem: qfprom: Add ipq5210 & ipq9650 compatible

Varadarajan Narayanan posted 1 patch 4 weeks ago 
Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 2 ++
1 file changed, 2 insertions(+)
[PATCH] dt-bindings: nvmem: qfprom: Add ipq5210 & ipq9650 compatible
Posted by Varadarajan Narayanan 4 weeks ago 
Document compatible string for the QFPROM on ipq5210 & ipq9650 platforms.

Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
index 2ab047f2bb69..eb49ba609083 100644
--- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
+++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
@@ -20,12 +20,14 @@ properties:
           - qcom,apq8064-qfprom
           - qcom,apq8084-qfprom
           - qcom,ipq5018-qfprom
+          - qcom,ipq5210-qfprom
           - qcom,ipq5332-qfprom
           - qcom,ipq5424-qfprom
           - qcom,ipq6018-qfprom
           - qcom,ipq8064-qfprom
           - qcom,ipq8074-qfprom
           - qcom,ipq9574-qfprom
+          - qcom,ipq9650-qfprom
           - qcom,kaanapali-qfprom
           - qcom,msm8226-qfprom
           - qcom,msm8916-qfprom

---
base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83
change-id: 20260515-tsens-802eef7a2cf6

Best regards,
-- 
Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
Re: [PATCH] dt-bindings: nvmem: qfprom: Add ipq5210 & ipq9650 compatible
Posted by Krzysztof Kozlowski 1 week, 1 day ago 
On 15/05/2026 11:24, Varadarajan Narayanan wrote:
> Document compatible string for the QFPROM on ipq5210 & ipq9650 platforms.
> 
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: nvmem: qfprom: Add ipq5210 & ipq9650 compatible
Posted by Krzysztof Kozlowski 3 weeks, 6 days ago 
On Fri, May 15, 2026 at 02:54:34PM +0530, Varadarajan Narayanan wrote:
> Document compatible string for the QFPROM on ipq5210 & ipq9650 platforms.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

This applies to all your patches, not only to this one.

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: nvmem: qfprom: Add ipq5210 & ipq9650 compatible
Posted by Varadarajan Narayanan 1 week, 1 day ago 
On Sat, May 16, 2026 at 11:55:35AM +0200, Krzysztof Kozlowski wrote:
> On Fri, May 15, 2026 at 02:54:34PM +0530, Varadarajan Narayanan wrote:
> > Document compatible string for the QFPROM on ipq5210 & ipq9650 platforms.
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> This applies to all your patches, not only to this one.

I had incorrectly wrapped to 72 columns instead of 75. Will fix that.

However, in this commit log there is only one line, not sure what to change.
Am I missing something? Please let me know.

Thanks
Varada
Re: [PATCH] dt-bindings: nvmem: qfprom: Add ipq5210 & ipq9650 compatible
Posted by Krzysztof Kozlowski 1 week, 1 day ago 
On 03/06/2026 13:32, Varadarajan Narayanan wrote:
> On Sat, May 16, 2026 at 11:55:35AM +0200, Krzysztof Kozlowski wrote:
>> On Fri, May 15, 2026 at 02:54:34PM +0530, Varadarajan Narayanan wrote:
>>> Document compatible string for the QFPROM on ipq5210 & ipq9650 platforms.
>>
>> Please wrap commit message according to Linux coding style / submission
>> process (neither too early nor over the limit):
>> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>>
>> This applies to all your patches, not only to this one.
> 
> I had incorrectly wrapped to 72 columns instead of 75. Will fix that.
> 
> However, in this commit log there is only one line, not sure what to change.
> Am I missing something? Please let me know.

Hm, that was two weeks ago, so I don't know what I had in mind that time
but I imagine it was too long. If you checked and it is fine, then
disregard the comment.

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: nvmem: qfprom: Add ipq5210 & ipq9650 compatible
Posted by Varadarajan Narayanan 1 week, 1 day ago 
On Wed, Jun 03, 2026 at 04:04:43PM +0200, Krzysztof Kozlowski wrote:
> On 03/06/2026 13:32, Varadarajan Narayanan wrote:
> > On Sat, May 16, 2026 at 11:55:35AM +0200, Krzysztof Kozlowski wrote:
> >> On Fri, May 15, 2026 at 02:54:34PM +0530, Varadarajan Narayanan wrote:
> >>> Document compatible string for the QFPROM on ipq5210 & ipq9650 platforms.
> >>
> >> Please wrap commit message according to Linux coding style / submission
> >> process (neither too early nor over the limit):
> >> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
> >>
> >> This applies to all your patches, not only to this one.
> >
> > I had incorrectly wrapped to 72 columns instead of 75. Will fix that.
> >
> > However, in this commit log there is only one line, not sure what to change.
> > Am I missing something? Please let me know.
>
> Hm, that was two weeks ago, so I don't know what I had in mind that time
> but I imagine it was too long. If you checked and it is fine, then
> disregard the comment.

Thanks for the clarification. Would you consider reviewing this patch, or
should I re-post as v2?

-Varada

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.