staging: sm750fb: rename CamelCase variables in sm750_hw.c

[PATCH] staging: sm750fb: rename CamelCase variables in sm750_hw.c

Posted by Rupesh Majhi 4 weeks ago

Renamed the following CamelCase variables to snake_case to comply
with Linux kernel coding style:
- pvReg -> pv_reg
- pvMem -> pv_mem
- initPram -> init_parm

Issue found by checkpatch.

Signed-off-by: Rupesh Majhi <zoone.rupert@gmail.com>
---
 drivers/staging/sm750fb/sm750_hw.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index ce46f240cbaf..ce6a0d2ebbb5 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -49,19 +49,19 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
 	}
 
 	/* now map mmio and vidmem */
-	sm750_dev->pvReg =
+	sm750_dev->pv_reg =
 		ioremap(sm750_dev->vidreg_start, sm750_dev->vidreg_size);
-	if (!sm750_dev->pvReg) {
+	if (!sm750_dev->pv_reg) {
 		pr_err("mmio failed\n");
 		ret = -EFAULT;
 		goto exit;
 	}
-	pr_info("mmio virtual addr = %p\n", sm750_dev->pvReg);
+	pr_info("mmio virtual addr = %p\n", sm750_dev->pv_reg);
 
-	sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
-	sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
+	sm750_dev->accel.dpr_base = sm750_dev->pv_reg + DE_BASE_ADDR_TYPE1;
+	sm750_dev->accel.dp_port_base = sm750_dev->pv_reg + DE_PORT_ADDR_TYPE1;
 
-	mmio750 = sm750_dev->pvReg;
+	mmio750 = sm750_dev->pv_reg;
 	sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid);
 
 	sm750_dev->vidmem_start = pci_resource_start(pdev, 0);
@@ -76,15 +76,15 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
 		sm750_dev->vidmem_start, sm750_dev->vidmem_size);
 
 	/* reserve the vidmem space of smi adaptor */
-	sm750_dev->pvMem =
+	sm750_dev->pv_mem =
 		ioremap_wc(sm750_dev->vidmem_start, sm750_dev->vidmem_size);
-	if (!sm750_dev->pvMem) {
-		iounmap(sm750_dev->pvReg);
+	if (!sm750_dev->pv_mem) {
+		iounmap(sm750_dev->pv_reg);
 		pr_err("Map video memory failed\n");
 		ret = -EFAULT;
 		goto exit;
 	}
-	pr_info("video memory vaddr = %p\n", sm750_dev->pvMem);
+	pr_info("video memory vaddr = %p\n", sm750_dev->pv_mem);
 exit:
 	return ret;
 }
@@ -93,7 +93,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
 {
 	struct init_status *parm;
 
-	parm = &sm750_dev->initParm;
+	parm = &sm750_dev->init_parm;
 	if (parm->chip_clk == 0)
 		parm->chip_clk = (sm750_get_chip_type() == SM750LE) ?
 					       DEFAULT_SM750LE_CHIP_CLOCK :
@@ -104,7 +104,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
 	if (parm->master_clk == 0)
 		parm->master_clk = parm->chip_clk / 3;
 
-	ddk750_init_hw((struct initchip_param *)&sm750_dev->initParm);
+	ddk750_init_hw((struct initchip_param *)&sm750_dev->init_parm);
 	/* for sm718, open pci burst */
 	if (sm750_dev->devid == 0x718) {
 		poke32(SYSTEM_CTRL,
-- 
2.43.0

Re: [PATCH] staging: sm750fb: rename CamelCase variables in sm750_hw.c

Posted by Ahmet Sezgin Duran 4 weeks ago

On 5/15/26 1:37 AM, Rupesh Majhi wrote:
> Renamed the following CamelCase variables to snake_case to comply
> with Linux kernel coding style:
> - pvReg -> pv_reg
> - pvMem -> pv_mem
> - initPram -> init_parm
> 
> Issue found by checkpatch.
> 
> Signed-off-by: Rupesh Majhi <zoone.rupert@gmail.com>
> ---
>   drivers/staging/sm750fb/sm750_hw.c | 24 ++++++++++++------------
>   1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
> index ce46f240cbaf..ce6a0d2ebbb5 100644
> --- a/drivers/staging/sm750fb/sm750_hw.c
> +++ b/drivers/staging/sm750fb/sm750_hw.c
> @@ -49,19 +49,19 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
>   	}
>   
>   	/* now map mmio and vidmem */
> -	sm750_dev->pvReg =
> +	sm750_dev->pv_reg =
>   		ioremap(sm750_dev->vidreg_start, sm750_dev->vidreg_size);
> -	if (!sm750_dev->pvReg) {
> +	if (!sm750_dev->pv_reg) {
>   		pr_err("mmio failed\n");
>   		ret = -EFAULT;
>   		goto exit;
>   	}
> -	pr_info("mmio virtual addr = %p\n", sm750_dev->pvReg);
> +	pr_info("mmio virtual addr = %p\n", sm750_dev->pv_reg);
>   
> -	sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
> -	sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
> +	sm750_dev->accel.dpr_base = sm750_dev->pv_reg + DE_BASE_ADDR_TYPE1;
> +	sm750_dev->accel.dp_port_base = sm750_dev->pv_reg + DE_PORT_ADDR_TYPE1;
>   
> -	mmio750 = sm750_dev->pvReg;
> +	mmio750 = sm750_dev->pv_reg;
>   	sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid);
>   
>   	sm750_dev->vidmem_start = pci_resource_start(pdev, 0);
> @@ -76,15 +76,15 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
>   		sm750_dev->vidmem_start, sm750_dev->vidmem_size);
>   
>   	/* reserve the vidmem space of smi adaptor */
> -	sm750_dev->pvMem =
> +	sm750_dev->pv_mem =
>   		ioremap_wc(sm750_dev->vidmem_start, sm750_dev->vidmem_size);
> -	if (!sm750_dev->pvMem) {
> -		iounmap(sm750_dev->pvReg);
> +	if (!sm750_dev->pv_mem) {
> +		iounmap(sm750_dev->pv_reg);
>   		pr_err("Map video memory failed\n");
>   		ret = -EFAULT;
>   		goto exit;
>   	}
> -	pr_info("video memory vaddr = %p\n", sm750_dev->pvMem);
> +	pr_info("video memory vaddr = %p\n", sm750_dev->pv_mem);
>   exit:
>   	return ret;
>   }
> @@ -93,7 +93,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
>   {
>   	struct init_status *parm;
>   
> -	parm = &sm750_dev->initParm;
> +	parm = &sm750_dev->init_parm;
>   	if (parm->chip_clk == 0)
>   		parm->chip_clk = (sm750_get_chip_type() == SM750LE) ?
>   					       DEFAULT_SM750LE_CHIP_CLOCK :
> @@ -104,7 +104,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
>   	if (parm->master_clk == 0)
>   		parm->master_clk = parm->chip_clk / 3;
>   
> -	ddk750_init_hw((struct initchip_param *)&sm750_dev->initParm);
> +	ddk750_init_hw((struct initchip_param *)&sm750_dev->init_parm);
>   	/* for sm718, open pci burst */
>   	if (sm750_dev->devid == 0x718) {
>   		poke32(SYSTEM_CTRL,

Did you create this patch from Greg's latest staging-testing branch?

Your patch doesn't apply. `pvMem` does not exist in the latest code.

Regards,
Ahmet Sezgin Duran