[PATCH v2] thermal: core: Add WQ_UNBOUND to alloc_workqueue users

Marco Crivellari posted 1 patch 4 weeks ago
There is a newer version of this series
drivers/thermal/thermal_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH v2] thermal: core: Add WQ_UNBOUND to alloc_workqueue users
Posted by Marco Crivellari 4 weeks ago
This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:

   commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
   commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The refactoring is going to alter the default behavior of
alloc_workqueue() to be unbound by default.

With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU. For more details see the Link tag below.

This workqueue has no benefits being per-CPU, so make it unbound using
explicitly WQ_UNBOUND.

Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
---
Changes in v2:
- "thermal_events" workqueue has more benefits being unbound, so instead
  of WQ_PERCPU, use WQ_UNBOUND.

Link to v1: https://lore.kernel.org/all/20260514132901.275477-1-marco.crivellari@suse.com/

 drivers/thermal/thermal_core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 2f4e2dc46b8f..1ac4262dafbc 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1889,7 +1889,8 @@ static int __init thermal_init(void)
 	if (result)
 		goto error;
 
-	thermal_wq = alloc_workqueue("thermal_events", WQ_POWER_EFFICIENT, 0);
+	thermal_wq = alloc_workqueue("thermal_events",
+				     WQ_POWER_EFFICIENT | WQ_UNBOUND, 0);
 	if (!thermal_wq) {
 		result = -ENOMEM;
 		goto unregister_netlink;
-- 
2.54.0

Re: [PATCH v2] thermal: core: Add WQ_UNBOUND to alloc_workqueue users
Posted by Marco Crivellari 4 weeks ago
On Thu, May 14, 2026 at 4:25 PM Marco Crivellari
<marco.crivellari@suse.com> wrote:
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 2f4e2dc46b8f..1ac4262dafbc 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1889,7 +1889,8 @@ static int __init thermal_init(void)
>         if (result)
>                 goto error;
>
> -       thermal_wq = alloc_workqueue("thermal_events", WQ_POWER_EFFICIENT, 0);
> +       thermal_wq = alloc_workqueue("thermal_events",
> +                                    WQ_POWER_EFFICIENT | WQ_UNBOUND, 0);
>         if (!thermal_wq) {
>                 result = -ENOMEM;
>                 goto unregister_netlink;

I just realized we can drop WQ_POWER_EFFICIENT now, because the
workqueue is unbound.
I will send the v3 removing the power efficient flag. Sorry for not
noticing that before.

Thanks!

-- 

Marco Crivellari

SUSE Labs