[PATCH] ntfs: Add WQ_PERCPU to alloc_workqueue users

Marco Crivellari posted 1 patch 4 weeks ago
fs/ntfs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] ntfs: Add WQ_PERCPU to alloc_workqueue users
Posted by Marco Crivellari 4 weeks ago
This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:

   commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
   commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The refactoring is going to alter the default behavior of
alloc_workqueue() to be unbound by default.

With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU. For more details see the Link tag below.

In order to keep alloc_workqueue() behavior identical, explicitly request
WQ_PERCPU.

Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
---
 fs/ntfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
index 22dc7865eca7..3a25e4dcfba4 100644
--- a/fs/ntfs/super.c
+++ b/fs/ntfs/super.c
@@ -2628,7 +2628,7 @@ MODULE_ALIAS_FS("ntfs");
 
 static int ntfs_workqueue_init(void)
 {
-	ntfs_wq = alloc_workqueue("ntfs-bg-io", 0, 0);
+	ntfs_wq = alloc_workqueue("ntfs-bg-io", WQ_PERCPU, 0);
 	if (!ntfs_wq)
 		return -ENOMEM;
 	return 0;
-- 
2.54.0

Re: [PATCH] ntfs: Add WQ_PERCPU to alloc_workqueue users
Posted by Hyunchul Lee 4 weeks ago
2026년 5월 14일 (목) 오후 10:54, Marco Crivellari <marco.crivellari@suse.com>님이 작성:
>
> This continues the effort to refactor workqueue APIs, which began with
> the introduction of new workqueues and a new alloc_workqueue flag in:
>
>    commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
>    commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
>
> The refactoring is going to alter the default behavior of
> alloc_workqueue() to be unbound by default.
>
> With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
> any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
> must now use WQ_PERCPU. For more details see the Link tag below.
>
> In order to keep alloc_workqueue() behavior identical, explicitly request
> WQ_PERCPU.
>
> Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
> Suggested-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>

Looks good to me.

Reviewed-by: Hyunchul Lee <hyc.lee@gmail.com>

> ---
>  fs/ntfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
> index 22dc7865eca7..3a25e4dcfba4 100644
> --- a/fs/ntfs/super.c
> +++ b/fs/ntfs/super.c
> @@ -2628,7 +2628,7 @@ MODULE_ALIAS_FS("ntfs");
>
>  static int ntfs_workqueue_init(void)
>  {
> -       ntfs_wq = alloc_workqueue("ntfs-bg-io", 0, 0);
> +       ntfs_wq = alloc_workqueue("ntfs-bg-io", WQ_PERCPU, 0);
>         if (!ntfs_wq)
>                 return -ENOMEM;
>         return 0;
> --
> 2.54.0
>


-- 
Thanks,
Hyunchul