[PATCH v1] ARM: imx3: Fix CCM node reference leak

Yuho Choi posted 1 patch 4 weeks, 1 day ago
arch/arm/mach-imx/mm-imx3.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH v1] ARM: imx3: Fix CCM node reference leak
Posted by Yuho Choi 4 weeks, 1 day ago
of_find_compatible_node() returns a referenced device node. The i.MX31
and i.MX35 early init paths use the node to map the CCM registers with
of_iomap(), but never drop the node reference.

Release the node after the mapping is created.

Fixes: 2cf98d12958c ("ARM: imx3: Retrieve the CCM base address from devicetree")
Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
---
 arch/arm/mach-imx/mm-imx3.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-imx/mm-imx3.c b/arch/arm/mach-imx/mm-imx3.c
index 0788c5cc7f9e..9b0b014d7fe2 100644
--- a/arch/arm/mach-imx/mm-imx3.c
+++ b/arch/arm/mach-imx/mm-imx3.c
@@ -106,6 +106,7 @@ void __init imx31_init_early(void)
 	arm_pm_idle = imx31_idle;
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx31-ccm");
 	mx3_ccm_base = of_iomap(np, 0);
+	of_node_put(np);
 	BUG_ON(!mx3_ccm_base);
 }
 #endif /* ifdef CONFIG_SOC_IMX31 */
@@ -143,6 +144,7 @@ void __init imx35_init_early(void)
 	arch_ioremap_caller = imx3_ioremap_caller;
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx35-ccm");
 	mx3_ccm_base = of_iomap(np, 0);
+	of_node_put(np);
 	BUG_ON(!mx3_ccm_base);
 }
 #endif /* ifdef CONFIG_SOC_IMX35 */
-- 
2.43.0
Re: [PATCH v1] ARM: imx3: Fix CCM node reference leak
Posted by Frank.Li@oss.nxp.com 1 week, 3 days ago
From: Frank Li <Frank.Li@nxp.com>


On Wed, 13 May 2026 23:40:04 -0400, Yuho Choi wrote:
> of_find_compatible_node() returns a referenced device node. The i.MX31
> and i.MX35 early init paths use the node to map the CCM registers with
> of_iomap(), but never drop the node reference.
> 
> Release the node after the mapping is created.
> 
> 
> [...]

Applied, thanks!

[1/1] ARM: imx3: Fix CCM node reference leak
      commit: 36d46348eb5fc4bc505cd2290ddd70c25fbe6bb3

Best regards,
-- 
Frank Li <Frank.Li@nxp.com>