[v1] Add LECARC ACPI IDs for DesignWare GPIO, SPI, I2C

[PATCH 0/3] Add LECARC ACPI IDs for DesignWare GPIO, SPI, I2C

Posted by thomas 4 weeks, 1 day ago

This patch series adds ACPI identification for LECARC SoCs that
integrate Synopsys DesignWare peripherals.

LECARC platforms use the following ACPI HIDs:
- GPIO: LECA0001 (V1 register offsets)
- SPI:  LECA0002 (requires custom init function)
- I2C:  LECA0003

The patches are independent but share a common dependency on the
ACPI description file (drivers/acpi/acpi_apd.c) for SPI and I2C.
To avoid merge conflicts, they are submitted as a single series
with the following order:

Patch 1: gpio: dwapb – add LECA0001 to dwapb_acpi_match[].
Patch 2: spi: dw-mmio – add LECA0002 and dw_spi_lecarc_init(),
         plus corresponding entry in acpi_apd.c.
Patch 3: i2c: designware – add LECA0003 to dw_i2c_acpi_match[],
         plus corresponding entry in acpi_apd.c.

All changes have been tested on LECARC evaluation board with
kernel v7.0.0-rc6. No regressions observed on existing hardware.

Please apply.

thomas (3):
  gpio: dwapb: Add LECARC ACPI ID
  spi: dw-mmio: Add LECARC ACPI ID and init hook
  i2c: designware: Add LECARC ACPI ID

 drivers/acpi/acpi_apd.c                     | 12 ++++++++++++
 drivers/gpio/gpio-dwapb.c                   |  1 +
 drivers/i2c/busses/i2c-designware-platdrv.c |  1 +
 drivers/spi/spi-dw-mmio.c                   |  9 +++++++++
 4 files changed, 23 insertions(+)

--
2.43.0

Re: [PATCH 0/3] Add LECARC ACPI IDs for DesignWare GPIO, SPI, I2C

Posted by Andy Shevchenko 4 weeks ago

On Thu, May 14, 2026 at 10:40:09AM +0800, thomas wrote:

This is a v2 of the series (Mark commented on the wrong one AFAICS), please
make sure you do proper versioning and changelog is provided.

> This patch series adds ACPI identification for LECARC SoCs that
> integrate Synopsys DesignWare peripherals.
> 
> LECARC platforms use the following ACPI HIDs:
> - GPIO: LECA0001 (V1 register offsets)
> - SPI:  LECA0002 (requires custom init function)
> - I2C:  LECA0003
> 
> The patches are independent but share a common dependency on the
> ACPI description file (drivers/acpi/acpi_apd.c) for SPI and I2C.
> To avoid merge conflicts, they are submitted as a single series
> with the following order:

> Patch 1: gpio: dwapb – add LECA0001 to dwapb_acpi_match[].
> Patch 2: spi: dw-mmio – add LECA0002 and dw_spi_lecarc_init(),
>          plus corresponding entry in acpi_apd.c.
> Patch 3: i2c: designware – add LECA0003 to dw_i2c_acpi_match[],
>          plus corresponding entry in acpi_apd.c.

You have to fix your SoB. There should be your real name and not an alias.

> All changes have been tested on LECARC evaluation board with
> kernel v7.0.0-rc6. No regressions observed on existing hardware.

Otherwise I can confirm that LECA is officially registered ACPI vendor ID and
the IDs look legit (it's up to the company to map the device ID parts to
whatever devices they have properly).

When you address the SoB and other comments, I ack them.

-- 
With Best Regards,
Andy Shevchenko