[PATCH v8 0/6] staging: rtl8723bs: rtw_mlme: line length cleanup

Salman Alghamdi posted 6 patches 4 weeks, 1 day ago
drivers/staging/rtl8723bs/core/rtw_mlme.c | 260 ++++++++++++++--------
1 file changed, 169 insertions(+), 91 deletions(-)
[PATCH v8 0/6] staging: rtl8723bs: rtw_mlme: line length cleanup
Posted by Salman Alghamdi 4 weeks, 1 day ago
This series cleans up lines exceeding 100 columns in rtw_mlme.c,
along with minor readability improvements.

The two bug fix patches previously included in this series have been
split out and sent separately as standalone patches at Greg's request.

Changes since v7:
- Split bounds check fix into a separate standalone patch per Greg KH's
  review

Changes since v6:
- Split fix patch into a separate series per Greg KH's review

Changes since v5:
- Fix variable declaration ordering that broke compilation due to
  dependency on uninitialized pointer (per Luka Gejak)

Changes since v4:
- Add separate patch for rtw_sitesurvey_cmd condition simplification
  (per Dan Carpenter)
- Fix variable declaration ordering to reverse Christmas tree
- Remove roam_failed intermediate variable

Changes since v3:
- Split the line length patch into two: one for simple wrapping
  and one for variable extraction (per Dan Carpenter)
- Add a separate patch for ie_length bounds checks which were
  flagged as behavior changes
- Use umin() instead of min_t() for unsigned value capping
- Fix empty else block left after dead code removal

Changes since v2:
- fixes a pre-existing buffer over-read bug in rtw_update_protection()
  identified during review.
- address the line length cleanup, dead code removal, line consolidation,
  and readability improvements as separate atomic changes.

Salman Alghamdi (6):
  staging: rtl8723bs: rtw_mlme: wrap lines exceeding 100 columns
  staging: rtl8723bs: rtw_mlme: wrap rtw_sitesurvey_cmd condition
  staging: rtl8723bs: rtw_mlme: extract local variables for long
    expressions
  staging: rtl8723bs: rtw_mlme: remove dead commented-out code
  staging: rtl8723bs: rtw_mlme: consolidate capability comparisons lines
  staging: rtl8723bs: rtw_mlme: add blank line for readability

 drivers/staging/rtl8723bs/core/rtw_mlme.c | 260 ++++++++++++++--------
 1 file changed, 169 insertions(+), 91 deletions(-)

-- 
2.54.0
Re: [PATCH v8 0/6] staging: rtl8723bs: rtw_mlme: line length cleanup
Posted by Greg KH 3 weeks, 1 day ago
On Wed, May 13, 2026 at 11:34:58PM +0300, Salman Alghamdi wrote:
> This series cleans up lines exceeding 100 columns in rtw_mlme.c,
> along with minor readability improvements.
> 
> The two bug fix patches previously included in this series have been
> split out and sent separately as standalone patches at Greg's request.
> 
> Changes since v7:
> - Split bounds check fix into a separate standalone patch per Greg KH's
>   review

Not all of these applied to my tree, can you rebase against the latest
staging-next branch and resend the remaining ones?

thanks,

greg k-h