checkpatch: add .dtso to DT compatible string vendor check

[PATCH] checkpatch: add .dtso to DT compatible string vendor check

Posted by Vitor Soares 4 weeks, 1 day ago

From: Vitor Soares <vitor.soares@toradex.com>

Extend the DT compatible documentation check to match .dtso files so
that vendor-prefixed compatibles in overlay files trigger the
UNDOCUMENTED_DT_STRING warning when the vendor is absent from
vendor-prefixes.yaml.

Assisted-by: Claude:claude-sonnet-4.6
Signed-off-by: Vitor Soares <vitor.soares@toradex.com>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3727156e4cca..fac38fd84856 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3774,7 +3774,7 @@ sub process {
 
 # check for DT compatible documentation
 		if (defined $root &&
-			(($realfile =~ /\.dtsi?$/ && $line =~ /^\+\s*compatible\s*=\s*\"/) ||
+			(($realfile =~ /\.(dts|dtsi|dtso)$/ && $line =~ /^\+\s*compatible\s*=\s*\"/) ||
 			 ($realfile =~ /\.[ch]$/ && $line =~ /^\+.*\.compatible\s*=\s*\"/))) {
 
 			my @compats = $rawline =~ /\"([a-zA-Z0-9\-\,\.\+_]+)\"/g;
-- 
2.53.0

Re: [PATCH] checkpatch: add .dtso to DT compatible string vendor check

Posted by Joe Perches 4 weeks, 1 day ago

On Wed, 2026-05-13 at 18:15 +0100, Vitor Soares wrote:
> Extend the DT compatible documentation check to match .dtso files so
> that vendor-prefixed compatibles in overlay files trigger the
> UNDOCUMENTED_DT_STRING warning when the vendor is absent from
> vendor-prefixes.yaml.
> 
> Assisted-by: Claude:claude-sonnet-4.6
> Signed-off-by: Vitor Soares <[vitor.soares@toradex.com](mailto:vitor.soares@toradex.com)>
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3774,7 +3774,7 @@ sub process {
>  
>  # check for DT compatible documentation
>  		if (defined $root &&
> -			(($realfile =~ /\.dtsi?$/ && $line =~ /^\+\s*compatible\s*=\s*\"/) ||
> +			(($realfile =~ /\.(dts|dtsi|dtso)$/ && $line =~ /^\+\s*compatible\s*=\s*\"/) ||

Use (?:...) to avoid capture groups.

And presumably all checks for dts.? files and locations should be modified

$ git grep -n dts scripts/checkpatch.pl
scripts/checkpatch.pl:3777:                     (($realfile =~ /\.dtsi?$/ && $line =~ /^\+\s*compatible\s*=\s*\"/) ||
scripts/checkpatch.pl:3807:             if ($realfile =~ /\.(dts|dtsi|dtso)$/ &&
scripts/checkpatch.pl:3824:                             if ($realfile =~ /\.(c|rs|dts|dtsi)$/) {
scripts/checkpatch.pl:3886:             next if ($realfile !~ /\.(h|c|rs|s|S|sh|dtsi|dts)$/);
scripts/checkpatch.pl:3985:             next if ($realfile !~ /\.(h|c|pl|dtsi|dts)$/);