[PATCH] sched/deadline: Fix stale comment above yield_task_dl()

Furkan Caliskan posted 1 patch 1 month ago
kernel/sched/deadline.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
[PATCH] sched/deadline: Fix stale comment above yield_task_dl()
Posted by Furkan Caliskan 1 month ago
The comment above yield_task_dl() states that bandwidth reclaiming is
"planned for the future". This is now obsolete as GRUB-PA has been
implemented.

Update the comment to reflect that yielded bandwidth is now actively
reclaimed for power saving and scheduling efficiency.

Signed-off-by: Furkan Caliskan <frn1furkan10@gmail.com>
---
 kernel/sched/deadline.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index edca7849b165..1ff8e5aafb3b 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -2365,14 +2365,11 @@ static bool dequeue_task_dl(struct rq *rq, struct task_struct *p, int flags)
 }
 
 /*
- * Yield task semantic for -deadline tasks is:
+ * Get off from the CPU until our next instance
  *
- *   get off from the CPU until our next instance, with
- *   a new runtime. This is of little use now, since we
- *   don't have a bandwidth reclaiming mechanism. Anyway,
- *   bandwidth reclaiming is planned for the future, and
- *   yield_task_dl will indicate that some spare budget
- *   is available for other task instances to use it.
+ * Yielding indicates that the current instance has finished its work 
+ * early. This allows the remaining budget to be reclaimed by other
+ * tasks or used to reduce CPU frequency via the GRUB-PA mechanism. 
  */
 static void yield_task_dl(struct rq *rq)
 {
-- 
2.34.1
Re: [PATCH] sched/deadline: Fix stale comment above yield_task_dl()
Posted by Juri Lelli 1 month ago
Hi,

On 13/05/26 13:25, Furkan Caliskan wrote:
> The comment above yield_task_dl() states that bandwidth reclaiming is
> "planned for the future". This is now obsolete as GRUB-PA has been
> implemented.
> 
> Update the comment to reflect that yielded bandwidth is now actively
> reclaimed for power saving and scheduling efficiency.
> 
> Signed-off-by: Furkan Caliskan <frn1furkan10@gmail.com>

Acked-by: Juri Lelli <juri.lelli@redhat.com>

Thanks,
Juri