This patch series contains various charging-related improvements
for the uniwill-laptop driver. The first two patches fix some minor
issues inside the charging threshold code, while the third patch
fixes an issue inside the module initialization code. The next two
patches contain some preparations for the main patch. Said patch
introduces support for controlling the charging modes available
on many Uniwill-based devices not sold by Intel. The last patch
whitelists most Tuxedo devices for using the battery charge modes.

All patches have been tested on a Tuxedo InfinityBook Pro 15 Gen10 AMD
and work just fine.

Changes since v2:
- add Reviewed-by tags
- rework first patch to use a common helper function
- add last patch from Werner

Changes since v1:
- add Reviewed-by tags
- fix spelling errors
- split third patch into two separate patches
- restructure code for battery initialization

Armin Wolf (7):
  platform/x86: uniwill-laptop: Properly initialize charging threshold
  platform/x86: uniwill-laptop: Accept charging threshold of 0
  platform/x86: uniwill-laptop: Fix behavior of "force" module param
  platform/x86: uniwill-laptop: Do not enable the charging limit even
    when forced
  platform/x86: uniwill-laptop: Rework FN lock/super key suspend
    handling
  platform/x86: uniwill-laptop: Mark EC_ADDR_OEM_4 as volatile
  platform/x86: uniwill-laptop: Add support for battery charge modes

Werner Sembach (1):
  platform/x86: uniwill-laptop: Enable battery charge modes on supported
    devices

 .../admin-guide/laptops/uniwill-laptop.rst    |  25 +-
 drivers/platform/x86/uniwill/uniwill-acpi.c   | 443 ++++++++++++++----
 drivers/platform/x86/uniwill/uniwill-wmi.c    |   5 +-
 3 files changed, 384 insertions(+), 89 deletions(-)

-- 
2.39.5

On Wed, 13 May 2026 01:21:37 +0200, Armin Wolf wrote:

> This patch series contains various charging-related improvements
> for the uniwill-laptop driver. The first two patches fix some minor
> issues inside the charging threshold code, while the third patch
> fixes an issue inside the module initialization code. The next two
> patches contain some preparations for the main patch. Said patch
> introduces support for controlling the charging modes available
> on many Uniwill-based devices not sold by Intel. The last patch
> whitelists most Tuxedo devices for using the battery charge modes.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/8] platform/x86: uniwill-laptop: Properly initialize charging threshold
      (no commit info)
[2/8] platform/x86: uniwill-laptop: Accept charging threshold of 0
      (no commit info)
[3/8] platform/x86: uniwill-laptop: Fix behavior of "force" module param
      (no commit info)
[4/8] platform/x86: uniwill-laptop: Do not enable the charging limit even when forced
      (no commit info)
[5/8] platform/x86: uniwill-laptop: Rework FN lock/super key suspend handling
      commit: 4d86e384c164abeee17da09fe6cd24a37973e628
[6/8] platform/x86: uniwill-laptop: Mark EC_ADDR_OEM_4 as volatile
      commit: f7bcba269143230923e40cd88b9169ed27f178ae
[7/8] platform/x86: uniwill-laptop: Add support for battery charge modes
      commit: 73fa957a05e9fd43f204225497d4c98d7c0d0490
[8/8] platform/x86: uniwill-laptop: Enable battery charge modes on supported devices
      commit: 2c5d91f35d0d564c8b4c062b67526e0d2d27fae9

--
 i.

On Wed, 13 May 2026 01:21:37 +0200, Armin Wolf wrote:

> This patch series contains various charging-related improvements
> for the uniwill-laptop driver. The first two patches fix some minor
> issues inside the charging threshold code, while the third patch
> fixes an issue inside the module initialization code. The next two
> patches contain some preparations for the main patch. Said patch
> introduces support for controlling the charging modes available
> on many Uniwill-based devices not sold by Intel. The last patch
> whitelists most Tuxedo devices for using the battery charge modes.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/8] platform/x86: uniwill-laptop: Properly initialize charging threshold
      commit: c12cc42dadd85dea210d5699d4f21def827382eb
[2/8] platform/x86: uniwill-laptop: Accept charging threshold of 0
      commit: c16a4823cc60a32b891f7a148bb30c0f51d12cf4
[3/8] platform/x86: uniwill-laptop: Fix behavior of "force" module param
      commit: fb4b67c44557cb4cbb15900083d4e1af22320339
[4/8] platform/x86: uniwill-laptop: Do not enable the charging limit even when forced
      commit: 26cbe119f99c86dcb4a0136d2bc73c0c716d80e4
[5/8] platform/x86: uniwill-laptop: Rework FN lock/super key suspend handling
      (no commit info)
[6/8] platform/x86: uniwill-laptop: Mark EC_ADDR_OEM_4 as volatile
      (no commit info)
[7/8] platform/x86: uniwill-laptop: Add support for battery charge modes
      (no commit info)
[8/8] platform/x86: uniwill-laptop: Enable battery charge modes on supported devices
      (no commit info)

--
 i.

Am 19.05.26 um 16:45 schrieb Ilpo Järvinen:

> On Wed, 13 May 2026 01:21:37 +0200, Armin Wolf wrote:
>
>> This patch series contains various charging-related improvements
>> for the uniwill-laptop driver. The first two patches fix some minor
>> issues inside the charging threshold code, while the third patch
>> fixes an issue inside the module initialization code. The next two
>> patches contain some preparations for the main patch. Said patch
>> introduces support for controlling the charging modes available
>> on many Uniwill-based devices not sold by Intel. The last patch
>> whitelists most Tuxedo devices for using the battery charge modes.
>>
>> [...]
>
> Thank you for your contribution, it has been applied to my local
> review-ilpo-fixes branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> local branch there, which might take a while.

Thank you :)

Is there a special reason why only the first four commits are actually available
on the fixes branch?

Thanks,
Armin Wolf

>
> The list of commits applied:
> [1/8] platform/x86: uniwill-laptop: Properly initialize charging threshold
>        commit: c12cc42dadd85dea210d5699d4f21def827382eb
> [2/8] platform/x86: uniwill-laptop: Accept charging threshold of 0
>        commit: c16a4823cc60a32b891f7a148bb30c0f51d12cf4
> [3/8] platform/x86: uniwill-laptop: Fix behavior of "force" module param
>        commit: fb4b67c44557cb4cbb15900083d4e1af22320339
> [4/8] platform/x86: uniwill-laptop: Do not enable the charging limit even when forced
>        commit: 26cbe119f99c86dcb4a0136d2bc73c0c716d80e4
> [5/8] platform/x86: uniwill-laptop: Rework FN lock/super key suspend handling
>        (no commit info)
> [6/8] platform/x86: uniwill-laptop: Mark EC_ADDR_OEM_4 as volatile
>        (no commit info)
> [7/8] platform/x86: uniwill-laptop: Add support for battery charge modes
>        (no commit info)
> [8/8] platform/x86: uniwill-laptop: Enable battery charge modes on supported devices
>        (no commit info)
>
> --
>   i.
>
>

On Sat, 23 May 2026, Armin Wolf wrote:

> Am 19.05.26 um 16:45 schrieb Ilpo Järvinen:
> 
> > On Wed, 13 May 2026 01:21:37 +0200, Armin Wolf wrote:
> > 
> > > This patch series contains various charging-related improvements
> > > for the uniwill-laptop driver. The first two patches fix some minor
> > > issues inside the charging threshold code, while the third patch
> > > fixes an issue inside the module initialization code. The next two
> > > patches contain some preparations for the main patch. Said patch
> > > introduces support for controlling the charging modes available
> > > on many Uniwill-based devices not sold by Intel. The last patch
> > > whitelists most Tuxedo devices for using the battery charge modes.
> > > 
> > > [...]
> > 
> > Thank you for your contribution, it has been applied to my local
> > review-ilpo-fixes branch. Note it will show up in the public
> > platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> > local branch there, which might take a while.
> 
> Thank you :)
> 
> Is there a special reason why only the first four commits are actually
> available
> on the fixes branch?

Yes, there is.

I was planning on merging the rest through for-next as I didn't categorize 
them as important fixes. I'll get to it some time this week.

--
 i.

> Thanks,
> Armin Wolf
> 
> > 
> > The list of commits applied:
> > [1/8] platform/x86: uniwill-laptop: Properly initialize charging threshold
> >        commit: c12cc42dadd85dea210d5699d4f21def827382eb
> > [2/8] platform/x86: uniwill-laptop: Accept charging threshold of 0
> >        commit: c16a4823cc60a32b891f7a148bb30c0f51d12cf4
> > [3/8] platform/x86: uniwill-laptop: Fix behavior of "force" module param
> >        commit: fb4b67c44557cb4cbb15900083d4e1af22320339
> > [4/8] platform/x86: uniwill-laptop: Do not enable the charging limit even
> > when forced
> >        commit: 26cbe119f99c86dcb4a0136d2bc73c0c716d80e4
> > [5/8] platform/x86: uniwill-laptop: Rework FN lock/super key suspend
> > handling
> >        (no commit info)
> > [6/8] platform/x86: uniwill-laptop: Mark EC_ADDR_OEM_4 as volatile
> >        (no commit info)
> > [7/8] platform/x86: uniwill-laptop: Add support for battery charge modes
> >        (no commit info)
> > [8/8] platform/x86: uniwill-laptop: Enable battery charge modes on supported
> > devices
> >        (no commit info)