[PATCH] s390: cleanup kconfig defaults for selftests

Julian Braha posted 1 patch 1 month ago
arch/s390/Kconfig | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
[PATCH] s390: cleanup kconfig defaults for selftests
Posted by Julian Braha 1 month ago
Remove the unconditional defaults of 'n' from the def_tristate statements,
which shadow the later 'KUNIT_ALL_TESTS' default, causing it to be dead
kconfig code.

Also, include S390_KPROBES_SANITY_TEST in KUNIT_ALL_TESTS.

This dead code was found by kconfirm, a static analysis tool for Kconfig.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 arch/s390/Kconfig | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index ecbcbb781e40..4d7c492c6bca 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -999,9 +999,8 @@ config S390_MODULES_SANITY_TEST_HELPERS
 menu "Selftests"
 
 config S390_UNWIND_SELFTEST
-	def_tristate n
+	def_tristate KUNIT_ALL_TESTS
 	depends on KUNIT
-	default KUNIT_ALL_TESTS
 	prompt "Test unwind functions"
 	help
 	  This option enables s390 specific stack unwinder testing kernel
@@ -1011,7 +1010,7 @@ config S390_UNWIND_SELFTEST
 	  Say N if you are unsure.
 
 config S390_KPROBES_SANITY_TEST
-	def_tristate n
+	def_tristate KUNIT_ALL_TESTS
 	prompt "Enable s390 specific kprobes tests"
 	depends on KPROBES
 	depends on KUNIT
@@ -1023,9 +1022,8 @@ config S390_KPROBES_SANITY_TEST
 	  Say N if you are unsure.
 
 config S390_MODULES_SANITY_TEST
-	def_tristate n
+	def_tristate KUNIT_ALL_TESTS
 	depends on KUNIT && m
-	default KUNIT_ALL_TESTS
 	prompt "Enable s390 specific modules tests"
 	select S390_MODULES_SANITY_TEST_HELPERS
 	help
-- 
2.53.0
Re: [PATCH] s390: cleanup kconfig defaults for selftests
Posted by Alexander Gordeev 3 weeks, 2 days ago
On Tue, May 12, 2026 at 06:43:36PM +0100, Julian Braha wrote:
> Remove the unconditional defaults of 'n' from the def_tristate statements,
> which shadow the later 'KUNIT_ALL_TESTS' default, causing it to be dead
> kconfig code.
> 
> Also, include S390_KPROBES_SANITY_TEST in KUNIT_ALL_TESTS.
> 
> This dead code was found by kconfirm, a static analysis tool for Kconfig.
> 
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
>  arch/s390/Kconfig | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)

Applied, thanks!