[PATCH] KVM: selftests: sync_regs_test: drop stale TODO comment

Piotr Zarycki posted 1 patch 1 month ago
tools/testing/selftests/kvm/x86/sync_regs_test.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] KVM: selftests: sync_regs_test: drop stale TODO comment
Posted by Piotr Zarycki 1 month ago
The TODO asked for a build-time check to guard against missing new sync
fields. Remove it, as code review is sufficient to catch such issues.

Signed-off-by: Piotr Zarycki <piotr.zarycki@gmail.com>
---
 tools/testing/selftests/kvm/x86/sync_regs_test.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/kvm/x86/sync_regs_test.c b/tools/testing/selftests/kvm/x86/sync_regs_test.c
index e0c52321f87c..5b0c2359bbb4 100644
--- a/tools/testing/selftests/kvm/x86/sync_regs_test.c
+++ b/tools/testing/selftests/kvm/x86/sync_regs_test.c
@@ -255,7 +255,6 @@ KVM_ONE_VCPU_TEST(sync_regs_test, req_and_verify_all_valid, guest_code)
 	struct kvm_regs regs;
 
 	/* Request and verify all valid register sets. */
-	/* TODO: BUILD TIME CHECK: TEST_ASSERT(KVM_SYNC_X86_NUM_FIELDS != 3); */
 	run->kvm_valid_regs = TEST_SYNC_FIELDS;
 	vcpu_run(vcpu);
 	TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO);
-- 
2.54.0
Re: [PATCH] KVM: selftests: sync_regs_test: drop stale TODO comment
Posted by Sean Christopherson 3 weeks, 3 days ago
On Tue, 12 May 2026 18:13:17 +0200, Piotr Zarycki wrote:
> The TODO asked for a build-time check to guard against missing new sync
> fields. Remove it, as code review is sufficient to catch such issues.

Applied to kvm-x86 selftests, thanks!

[1/1] KVM: selftests: sync_regs_test: drop stale TODO comment
      https://github.com/kvm-x86/linux/commit/64f1fa859c1e

--
https://github.com/kvm-x86/linux/tree/next