drivers/staging/sm750fb/sm750.c | 1 + 1 file changed, 1 insertion(+)
The g_fbmode array is modified at runtime, so it must remain
non-const. Added clarifying comment.
Signed-off-by: Chhabilal Dangal <yogeshdangal66@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 9f3e3d37e82a..a553099f42f3 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -33,6 +33,7 @@
static int g_hwcursor = 1;
static int g_noaccel;
static int g_nomtrr;
+/* intentionally non-const since array is modified at runtime */
static const char *g_fbmode[] = {NULL, NULL};
static const char *g_def_fbmode = "1024x768-32@60";
static char *g_settings;
--
2.54.0
On Mon, May 11, 2026 at 10:47:45PM +0545, Chhabilal Dangal wrote: > The g_fbmode array is modified at runtime, so it must remain > non-const. Added clarifying comment. > > Signed-off-by: Chhabilal Dangal <yogeshdangal66@gmail.com> > --- > drivers/staging/sm750fb/sm750.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c > index 9f3e3d37e82a..a553099f42f3 100644 > --- a/drivers/staging/sm750fb/sm750.c > +++ b/drivers/staging/sm750fb/sm750.c > @@ -33,6 +33,7 @@ > static int g_hwcursor = 1; > static int g_noaccel; > static int g_nomtrr; > +/* intentionally non-const since array is modified at runtime */ No comment is needed, if you change the code, it breaks the build, so that is very obvious as you would never submit a patch that you did not build, right? :) thanks, greg k-h
© 2016 - 2026 Red Hat, Inc.