[PATCH] scsi: libiscsi: fix spelling and format errors

Wang Yan posted 1 patch 1 month ago
drivers/scsi/libiscsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] scsi: libiscsi: fix spelling and format errors
Posted by Wang Yan 1 month ago
Fix two issues in libiscsi.c:
- Correct typo "numer" to "number" in iscsi_session_setup() comment
- Fix format string "seconds\n." to "seconds.\n" in recv timeout warning

Signed-off-by: Wang Yan <wangyan01@kylinos.cn>
---
 drivers/scsi/libiscsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 25857d6ed6e8..160f02f2f51d 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -3012,7 +3012,7 @@ static void iscsi_host_dec_session_cnt(struct Scsi_Host *shost)
  * This can be used by software iscsi_transports that allocate
  * a session per scsi host.
  *
- * Callers should set cmds_max to the largest total numer (mgmt + scsi) of
+ * Callers should set cmds_max to the largest total number (mgmt + scsi) of
  * tasks they support. The iscsi layer reserves ISCSI_MGMT_CMDS_MAX tasks
  * for nop handling and login/logout requests.
  */
@@ -3307,7 +3307,7 @@ int iscsi_conn_start(struct iscsi_cls_conn *cls_conn)
 
 	if (conn->ping_timeout && !conn->recv_timeout) {
 		iscsi_conn_printk(KERN_ERR, conn, "invalid recv timeout of "
-				  "zero. Using 5 seconds\n.");
+				  "zero. Using 5 seconds.\n");
 		conn->recv_timeout = 5;
 	}
 
-- 
2.25.1
Re: [PATCH] scsi: libiscsi: fix spelling and format errors
Posted by Martin K. Petersen 2 weeks, 6 days ago
On Mon, 11 May 2026 17:30:30 +0800, Wang Yan wrote:

> Fix two issues in libiscsi.c:
> - Correct typo "numer" to "number" in iscsi_session_setup() comment
> - Fix format string "seconds\n." to "seconds.\n" in recv timeout warning
> 
> 

Applied to 7.2/scsi-queue, thanks!

[1/1] scsi: libiscsi: fix spelling and format errors
      https://git.kernel.org/mkp/scsi/c/250ba648f42d

-- 
Martin K. Petersen
Re: [PATCH] scsi: libiscsi: fix spelling and format errors
Posted by Martin K. Petersen 4 weeks ago
Wang,

> Fix two issues in libiscsi.c:
> - Correct typo "numer" to "number" in iscsi_session_setup() comment
> - Fix format string "seconds\n." to "seconds.\n" in recv timeout warning

Applied to 7.2/scsi-staging, thanks!

-- 
Martin K. Petersen
Re: [PATCH] scsi: libiscsi: fix spelling and format errors
Posted by Chris Leech 1 month ago
On Mon, May 11, 2026 at 05:30:30PM +0800, Wang Yan wrote:
> Fix two issues in libiscsi.c:
> - Correct typo "numer" to "number" in iscsi_session_setup() comment
> - Fix format string "seconds\n." to "seconds.\n" in recv timeout warning
> 
> Signed-off-by: Wang Yan <wangyan01@kylinos.cn>
> ---

Sure, that looks fine.

Reviewed-by: Chris Leech <cleech@redhat.com>

>  drivers/scsi/libiscsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 25857d6ed6e8..160f02f2f51d 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -3012,7 +3012,7 @@ static void iscsi_host_dec_session_cnt(struct Scsi_Host *shost)
>   * This can be used by software iscsi_transports that allocate
>   * a session per scsi host.
>   *
> - * Callers should set cmds_max to the largest total numer (mgmt + scsi) of
> + * Callers should set cmds_max to the largest total number (mgmt + scsi) of
>   * tasks they support. The iscsi layer reserves ISCSI_MGMT_CMDS_MAX tasks
>   * for nop handling and login/logout requests.
>   */
> @@ -3307,7 +3307,7 @@ int iscsi_conn_start(struct iscsi_cls_conn *cls_conn)
>  
>  	if (conn->ping_timeout && !conn->recv_timeout) {
>  		iscsi_conn_printk(KERN_ERR, conn, "invalid recv timeout of "
> -				  "zero. Using 5 seconds\n.");
> +				  "zero. Using 5 seconds.\n");
>  		conn->recv_timeout = 5;
>  	}
>  
> -- 
> 2.25.1
>
Re: [PATCH] scsi: libiscsi: fix spelling and format errors
Posted by Mike Christie 1 month ago
On 5/11/26 4:30 AM, Wang Yan wrote:
> Fix two issues in libiscsi.c:
> - Correct typo "numer" to "number" in iscsi_session_setup() comment
> - Fix format string "seconds\n." to "seconds.\n" in recv timeout warning
> 
> Signed-off-by: Wang Yan <wangyan01@kylinos.cn>

Reviewed-by: Mike Christie <michael.christie@oracle.com>