powerpc/64s: Fix the vector number in comments for h_facility_unavailable

[PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable

Posted by Gautam Menghani 1 month ago

From: Gautam Menghani <gautam@linux.ibm.com>

The comments explaining the h_facility_unavailable interrupt have mentioned
the vector number as 0xf60 instead of 0xf80. Fix this typo.

Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
---
 arch/powerpc/kernel/exceptions-64s.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
index b7229430ca94..2696fbbca3b6 100644
--- a/arch/powerpc/kernel/exceptions-64s.S
+++ b/arch/powerpc/kernel/exceptions-64s.S
@@ -2498,7 +2498,7 @@ EXC_COMMON_BEGIN(facility_unavailable_common)
 
 
 /**
- * Interrupt 0xf60 - Hypervisor Facility Unavailable Interrupt.
+ * Interrupt 0xf80 - Hypervisor Facility Unavailable Interrupt.
  * This is a synchronous interrupt in response to
  * executing an instruction without access to the facility that can only
  * be resolved in HV mode (e.g., HFSCR).
-- 
2.53.0

Re: [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable

Posted by Vaibhav Jain 1 month ago

Hey Gautam,

Thanks for the patch. Since this patch doesnt have any functional or
code change can you please put a 'trivial' suffix to it patch title like
[1] or some other suffix indicating its a non-functional change. That
way maintainers can easily pull the patch without worrying much about a
regression.

[1]
https://git.kernel.org/powerpc/c/d2827e5e2e0f0941a651f4b1ca5e9b778c4b5293

Gautam Menghani <Gautam.Menghani@ibm.com> writes:
> From: Gautam Menghani <gautam@linux.ibm.com>
>
> The comments explaining the h_facility_unavailable interrupt have mentioned
> the vector number as 0xf60 instead of 0xf80. Fix this typo.
>
> Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
> ---
>  arch/powerpc/kernel/exceptions-64s.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
> index b7229430ca94..2696fbbca3b6 100644
> --- a/arch/powerpc/kernel/exceptions-64s.S
> +++ b/arch/powerpc/kernel/exceptions-64s.S
> @@ -2498,7 +2498,7 @@ EXC_COMMON_BEGIN(facility_unavailable_common)
>  
>  
>  /**
> - * Interrupt 0xf60 - Hypervisor Facility Unavailable Interrupt.
> + * Interrupt 0xf80 - Hypervisor Facility Unavailable Interrupt.
>   * This is a synchronous interrupt in response to
>   * executing an instruction without access to the facility that can only
>   * be resolved in HV mode (e.g., HFSCR).
> -- 
> 2.53.0
>
>

-- 
Cheers
~ Vaibhav

Re: [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable

Posted by Gautam Menghani 4 weeks ago

On Wed, May 13, 2026 at 02:35:29PM +0530, Vaibhav Jain wrote:
> Hey Gautam,
> 
> Thanks for the patch. Since this patch doesnt have any functional or
> code change can you please put a 'trivial' suffix to it patch title like
> [1] or some other suffix indicating its a non-functional change. That
> way maintainers can easily pull the patch without worrying much about a
> regression.
> 
> [1]
> https://git.kernel.org/powerpc/c/d2827e5e2e0f0941a651f4b1ca5e9b778c4b5293

Yeah I've mentioned "comments" in the title, so I guess that's fine?

Thanks,
Gautam

Re: [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable

Posted by Vaibhav Jain 3 weeks, 4 days ago

Gautam Menghani <gautam@linux.ibm.com> writes:

> On Wed, May 13, 2026 at 02:35:29PM +0530, Vaibhav Jain wrote:
>> Hey Gautam,
>> 
>> Thanks for the patch. Since this patch doesnt have any functional or
>> code change can you please put a 'trivial' suffix to it patch title like
>> [1] or some other suffix indicating its a non-functional change. That
>> way maintainers can easily pull the patch without worrying much about a
>> regression.
>> 
>> [1]
>> https://git.kernel.org/powerpc/c/d2827e5e2e0f0941a651f4b1ca5e9b778c4b5293
>
> Yeah I've mentioned "comments" in the title, so I guess that's fine?
>
> Thanks,
> Gautam

Bike shedding a bit but using the term 'trivial' might be better then
using the term 'comments'

-- 
Cheers
~ Vaibhav

Re: [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable

Posted by Ritesh Harjani (IBM) 1 month ago

Gautam Menghani <Gautam.Menghani@ibm.com> writes:

> From: Gautam Menghani <gautam@linux.ibm.com>
>
> The comments explaining the h_facility_unavailable interrupt have mentioned
> the vector number as 0xf60 instead of 0xf80. Fix this typo.
>

Yup, looks like it got copied over from the above definition of Facility
Unavailable Interrupt. Nice catch!

LGTM. Please feel free to add:

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

Re: [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable

Posted by Amit Machhiwal 1 month ago

On 2026/05/11 01:34 PM, Gautam Menghani wrote:
> From: Gautam Menghani <gautam@linux.ibm.com>
> 
> The comments explaining the h_facility_unavailable interrupt have mentioned
> the vector number as 0xf60 instead of 0xf80. Fix this typo.
> 
> Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
> ---
>  arch/powerpc/kernel/exceptions-64s.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Amit Machhiwal <amachhiw@linux.ibm.com>

> 
> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
> index b7229430ca94..2696fbbca3b6 100644
> --- a/arch/powerpc/kernel/exceptions-64s.S
> +++ b/arch/powerpc/kernel/exceptions-64s.S
> @@ -2498,7 +2498,7 @@ EXC_COMMON_BEGIN(facility_unavailable_common)
>  
>  
>  /**
> - * Interrupt 0xf60 - Hypervisor Facility Unavailable Interrupt.
> + * Interrupt 0xf80 - Hypervisor Facility Unavailable Interrupt.
>   * This is a synchronous interrupt in response to
>   * executing an instruction without access to the facility that can only
>   * be resolved in HV mode (e.g., HFSCR).
> -- 
> 2.53.0
> 
>

Re: [PATCH] powerpc/64s: Fix the vector number in comments for h_facility_unavailable

Posted by Harsh Prateek Bora 1 month ago


On 11/05/26 1:34 pm, Gautam Menghani wrote:
> From: Gautam Menghani <gautam@linux.ibm.com>
> 
> The comments explaining the h_facility_unavailable interrupt have mentioned
> the vector number as 0xf60 instead of 0xf80. Fix this typo.
> 
> Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
> ---
>   arch/powerpc/kernel/exceptions-64s.S | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
> index b7229430ca94..2696fbbca3b6 100644
> --- a/arch/powerpc/kernel/exceptions-64s.S
> +++ b/arch/powerpc/kernel/exceptions-64s.S
> @@ -2498,7 +2498,7 @@ EXC_COMMON_BEGIN(facility_unavailable_common)
>   
>   
>   /**
> - * Interrupt 0xf60 - Hypervisor Facility Unavailable Interrupt.
> + * Interrupt 0xf80 - Hypervisor Facility Unavailable Interrupt.

Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

>    * This is a synchronous interrupt in response to
>    * executing an instruction without access to the facility that can only
>    * be resolved in HV mode (e.g., HFSCR).