[PATCH 0/8] USB: serial: clean up include directives

Johan Hovold posted 8 patches 1 month ago
drivers/usb/serial/ark3116.c          | 1 -
drivers/usb/serial/belkin_sa.c        | 2 --
drivers/usb/serial/cyberjack.c        | 2 --
drivers/usb/serial/cypress_m8.c       | 2 --
drivers/usb/serial/digi_acceleport.c  | 2 --
drivers/usb/serial/empeg.c            | 3 ---
drivers/usb/serial/f81232.c           | 3 ---
drivers/usb/serial/f81534.c           | 1 -
drivers/usb/serial/ftdi_sio.c         | 1 -
drivers/usb/serial/garmin_gps.c       | 3 ---
drivers/usb/serial/generic.c          | 1 -
drivers/usb/serial/io_edgeport.c      | 2 +-
drivers/usb/serial/io_ti.c            | 2 --
drivers/usb/serial/ipaq.c             | 3 ---
drivers/usb/serial/ipw.c              | 2 --
drivers/usb/serial/ir-usb.c           | 2 --
drivers/usb/serial/iuu_phoenix.c      | 2 --
drivers/usb/serial/keyspan.c          | 2 --
drivers/usb/serial/keyspan_pda.c      | 2 --
drivers/usb/serial/kl5kusb105.c       | 2 --
drivers/usb/serial/kobil_sct.c        | 2 --
drivers/usb/serial/mct_u232.c         | 2 --
drivers/usb/serial/metro-usb.c        | 3 ---
drivers/usb/serial/mos7720.c          | 3 ++-
drivers/usb/serial/mos7840.c          | 1 -
drivers/usb/serial/mxuport.c          | 2 --
drivers/usb/serial/omninet.c          | 2 --
drivers/usb/serial/opticon.c          | 2 --
drivers/usb/serial/option.c           | 1 -
drivers/usb/serial/oti6858.c          | 3 ---
drivers/usb/serial/pl2303.c           | 3 ---
drivers/usb/serial/qcserial.c         | 1 -
drivers/usb/serial/quatech2.c         | 2 --
drivers/usb/serial/safe_serial.c      | 2 --
drivers/usb/serial/spcp8x5.c          | 2 --
drivers/usb/serial/ssu100.c           | 2 --
drivers/usb/serial/symbolserial.c     | 2 --
drivers/usb/serial/ti_usb_3410_5052.c | 2 --
drivers/usb/serial/usb-serial.c       | 3 ---
drivers/usb/serial/usb_wwan.c         | 1 -
drivers/usb/serial/visor.c            | 4 ----
drivers/usb/serial/whiteheat.c        | 4 ----
drivers/usb/serial/wishbone-serial.c  | 1 -
drivers/usb/serial/xr_serial.c        | 1 +
drivers/usb/serial/xsens_mt.c         | 1 -
45 files changed, 4 insertions(+), 88 deletions(-)
[PATCH 0/8] USB: serial: clean up include directives
Posted by Johan Hovold 1 month ago
Include directives tend to be copied from existing drivers when new
drivers are written. Clean up the driver include directives to avoid
having to point out unnecessary includes when reviewing new drivers.

Johan


Johan Hovold (8):
  USB: serial: drop unused tty_driver includes
  USB: serial: drop unused tty_flip includes
  USB: serial: xr: add missing uaccess include
  USB: serial: drop unused uaccess includes
  USB: serial: drop unused moduleparam includes
  USB: serial: garmin_gps: drop unused atomic include
  USB: serial: add missing atomic includes
  USB: serial: whiteheat: drop termbits include

 drivers/usb/serial/ark3116.c          | 1 -
 drivers/usb/serial/belkin_sa.c        | 2 --
 drivers/usb/serial/cyberjack.c        | 2 --
 drivers/usb/serial/cypress_m8.c       | 2 --
 drivers/usb/serial/digi_acceleport.c  | 2 --
 drivers/usb/serial/empeg.c            | 3 ---
 drivers/usb/serial/f81232.c           | 3 ---
 drivers/usb/serial/f81534.c           | 1 -
 drivers/usb/serial/ftdi_sio.c         | 1 -
 drivers/usb/serial/garmin_gps.c       | 3 ---
 drivers/usb/serial/generic.c          | 1 -
 drivers/usb/serial/io_edgeport.c      | 2 +-
 drivers/usb/serial/io_ti.c            | 2 --
 drivers/usb/serial/ipaq.c             | 3 ---
 drivers/usb/serial/ipw.c              | 2 --
 drivers/usb/serial/ir-usb.c           | 2 --
 drivers/usb/serial/iuu_phoenix.c      | 2 --
 drivers/usb/serial/keyspan.c          | 2 --
 drivers/usb/serial/keyspan_pda.c      | 2 --
 drivers/usb/serial/kl5kusb105.c       | 2 --
 drivers/usb/serial/kobil_sct.c        | 2 --
 drivers/usb/serial/mct_u232.c         | 2 --
 drivers/usb/serial/metro-usb.c        | 3 ---
 drivers/usb/serial/mos7720.c          | 3 ++-
 drivers/usb/serial/mos7840.c          | 1 -
 drivers/usb/serial/mxuport.c          | 2 --
 drivers/usb/serial/omninet.c          | 2 --
 drivers/usb/serial/opticon.c          | 2 --
 drivers/usb/serial/option.c           | 1 -
 drivers/usb/serial/oti6858.c          | 3 ---
 drivers/usb/serial/pl2303.c           | 3 ---
 drivers/usb/serial/qcserial.c         | 1 -
 drivers/usb/serial/quatech2.c         | 2 --
 drivers/usb/serial/safe_serial.c      | 2 --
 drivers/usb/serial/spcp8x5.c          | 2 --
 drivers/usb/serial/ssu100.c           | 2 --
 drivers/usb/serial/symbolserial.c     | 2 --
 drivers/usb/serial/ti_usb_3410_5052.c | 2 --
 drivers/usb/serial/usb-serial.c       | 3 ---
 drivers/usb/serial/usb_wwan.c         | 1 -
 drivers/usb/serial/visor.c            | 4 ----
 drivers/usb/serial/whiteheat.c        | 4 ----
 drivers/usb/serial/wishbone-serial.c  | 1 -
 drivers/usb/serial/xr_serial.c        | 1 +
 drivers/usb/serial/xsens_mt.c         | 1 -
 45 files changed, 4 insertions(+), 88 deletions(-)

-- 
2.53.0
Re: [PATCH 0/8] USB: serial: clean up include directives
Posted by Greg Kroah-Hartman 1 month ago
On Mon, May 11, 2026 at 09:14:40AM +0200, Johan Hovold wrote:
> Include directives tend to be copied from existing drivers when new
> drivers are written. Clean up the driver include directives to avoid
> having to point out unnecessary includes when reviewing new drivers.
> 
> Johan
> 
> 
> Johan Hovold (8):
>   USB: serial: drop unused tty_driver includes
>   USB: serial: drop unused tty_flip includes
>   USB: serial: xr: add missing uaccess include
>   USB: serial: drop unused uaccess includes
>   USB: serial: drop unused moduleparam includes
>   USB: serial: garmin_gps: drop unused atomic include
>   USB: serial: add missing atomic includes
>   USB: serial: whiteheat: drop termbits include

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>