[PATCH] arm64: dts: qcom: ipq5210: add the download mode support

Kathiravan Thirumoorthy posted 1 patch 1 month ago
arch/arm64/boot/dts/qcom/ipq5210.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
[PATCH] arm64: dts: qcom: ipq5210: add the download mode support
Posted by Kathiravan Thirumoorthy 1 month ago
Enable support for download mode to collect RAM dumps in case
of system crash, facilitating post mortem analysis.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/ipq5210.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
index 3761eb03ab24..cd587eef0018 100644
--- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
@@ -75,6 +75,7 @@ optee {
 
 		scm {
 			compatible = "qcom,scm-ipq5210", "qcom,scm";
+			qcom,dload-mode = <&tcsr 0x25100>;
 		};
 	};
 
@@ -160,6 +161,11 @@ tcsr_mutex: hwlock@1905000 {
 			#hwlock-cells = <1>;
 		};
 
+		tcsr: syscon@1937000 {
+			compatible = "qcom,tcsr-ipq5210", "syscon";
+			reg = <0x0 0x01937000 0x0 0x2b000>;
+		};
+
 		qupv3: geniqup@1ac0000 {
 			compatible = "qcom,geni-se-qup";
 			reg = <0x0 0x01ac0000 0x0 0x2000>;

---
base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83
change-id: 20260511-ipq5210_dload_support-4336d9627beb
prerequisite-change-id: 20260511-ipq5210_tcsr_binding-5aef0d2eaeca:v1
prerequisite-patch-id: 93b818cd4feadea099a037157877d5a033545b53

Best regards,
--  
Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
Re: [PATCH] arm64: dts: qcom: ipq5210: add the download mode support
Posted by Krzysztof Kozlowski 4 weeks ago
On 11/05/2026 13:01, Kathiravan Thirumoorthy wrote:
> Enable support for download mode to collect RAM dumps in case
> of system crash, facilitating post mortem analysis.
> 
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq5210.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

So you sent ALL your patches separately. One by one.

This is non acceptable waste of maintainers time.

Best regards,
Krzysztof
Re: [PATCH] arm64: dts: qcom: ipq5210: add the download mode support
Posted by Kathiravan Thirumoorthy 4 weeks ago
On 5/15/2026 1:53 PM, Krzysztof Kozlowski wrote:
> On 11/05/2026 13:01, Kathiravan Thirumoorthy wrote:
>> Enable support for download mode to collect RAM dumps in case
>> of system crash, facilitating post mortem analysis.
>>
>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/ipq5210.dtsi | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
> So you sent ALL your patches separately. One by one.
>
> This is non acceptable waste of maintainers time.

Agreed and apologies for the same. Will squash all the DT changes 
together and post it.

>
> Best regards,
> Krzysztof