drivers/staging/media/atomisp/pci/ia_css_isp_configs.c | 1 - drivers/staging/media/atomisp/pci/ia_css_isp_params.c | 1 - drivers/staging/media/atomisp/pci/ia_css_isp_params.h | 1 - drivers/staging/media/atomisp/pci/ia_css_isp_states.c | 1 - drivers/staging/media/atomisp/pci/ia_css_isp_states.h | 1 - 5 files changed, 5 deletions(-)
Remove the "Generated code: do not edit or commmit." comments from
five files. As suggested by Andy Shevchenko, this code is coupled
with legacy firmware and will never be re-generated, so the comment
is misleading and should be dropped entirely rather than having its
typo fixed.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
drivers/staging/media/atomisp/pci/ia_css_isp_configs.c | 1 -
drivers/staging/media/atomisp/pci/ia_css_isp_params.c | 1 -
drivers/staging/media/atomisp/pci/ia_css_isp_params.h | 1 -
drivers/staging/media/atomisp/pci/ia_css_isp_states.c | 1 -
drivers/staging/media/atomisp/pci/ia_css_isp_states.h | 1 -
5 files changed, 5 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
index 38c9c62366d6..96a8e58cfcee 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
@@ -4,7 +4,6 @@
* Copyright (c) 2015, Intel Corporation.
*/
-/* Generated code: do not edit or commmit. */
#define IA_CSS_INCLUDE_CONFIGURATIONS
#include "ia_css_pipeline.h"
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_params.c b/drivers/staging/media/atomisp/pci/ia_css_isp_params.c
index 1cd3322b0da0..96af15f62060 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_params.c
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_params.c
@@ -48,7 +48,6 @@
#include "isp/kernels/eed1_8/ia_css_eed1_8.host.h"
#include "isp/kernels/bnlm/ia_css_bnlm.host.h"
#include "isp/kernels/conversion/conversion_1.0/ia_css_conversion.host.h"
-/* Generated code: do not edit or commmit. */
#include "ia_css_pipeline.h"
#include "ia_css_isp_params.h"
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_params.h b/drivers/staging/media/atomisp/pci/ia_css_isp_params.h
index a542f8979905..8c9468c5849f 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_params.h
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_params.h
@@ -4,7 +4,6 @@
* Copyright (c) 2015, Intel Corporation.
*/
-/* Generated code: do not edit or commmit. */
#ifndef _IA_CSS_ISP_PARAM_H
#define _IA_CSS_ISP_PARAM_H
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_states.c b/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
index af1765040464..1ea71477e774 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
@@ -3,7 +3,6 @@
* Support for Intel Camera Imaging ISP subsystem.
* Copyright (c) 2015, Intel Corporation.
*/
-/* Generated code: do not edit or commmit. */
#include "ia_css_pipeline.h"
#include "ia_css_isp_states.h"
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_states.h b/drivers/staging/media/atomisp/pci/ia_css_isp_states.h
index d637ea1d13f6..5bd1d4ae1fe4 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_states.h
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_states.h
@@ -15,7 +15,6 @@
#include "isp/kernels/ynr/ynr_1.0/ia_css_ynr.host.h"
#include "isp/kernels/dpc2/ia_css_dpc2.host.h"
#include "isp/kernels/eed1_8/ia_css_eed1_8.host.h"
-/* Generated code: do not edit or commmit. */
#ifndef _IA_CSS_ISP_STATE_H
#define _IA_CSS_ISP_STATE_H
---
base-commit: ea09c82fbc53aad867541cd2f0bde96c6b228ba0
change-id: 20260511-atomisp-remove-generated-comment-ae5966c5ec7f
Best regards,
--
Tomasz Unger <tomasz.unger@yahoo.pl>
On Mon, May 11, 2026 at 06:55:31PM +0200, Tomasz Unger wrote: > Remove the "Generated code: do not edit or commmit." comments from > five files. As suggested by Andy Shevchenko, this code is coupled > with legacy firmware and will never be re-generated, so the comment > is misleading and should be dropped entirely rather than having its > typo fixed. > > Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com> > Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> > --- > drivers/staging/media/atomisp/pci/ia_css_isp_configs.c | 1 - > drivers/staging/media/atomisp/pci/ia_css_isp_params.c | 1 - > drivers/staging/media/atomisp/pci/ia_css_isp_params.h | 1 - > drivers/staging/media/atomisp/pci/ia_css_isp_states.c | 1 - > drivers/staging/media/atomisp/pci/ia_css_isp_states.h | 1 - > 5 files changed, 5 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c > index 38c9c62366d6..96a8e58cfcee 100644 > --- a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c > +++ b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c > @@ -4,7 +4,6 @@ > * Copyright (c) 2015, Intel Corporation. > */ > > -/* Generated code: do not edit or commmit. */ > > #define IA_CSS_INCLUDE_CONFIGURATIONS Now there are two blank lines in a row. > #include "ia_css_pipeline.h" > diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_params.c b/drivers/staging/media/atomisp/pci/ia_css_isp_params.c > index 1cd3322b0da0..96af15f62060 100644 > --- a/drivers/staging/media/atomisp/pci/ia_css_isp_params.c > +++ b/drivers/staging/media/atomisp/pci/ia_css_isp_params.c > @@ -48,7 +48,6 @@ > #include "isp/kernels/eed1_8/ia_css_eed1_8.host.h" > #include "isp/kernels/bnlm/ia_css_bnlm.host.h" > #include "isp/kernels/conversion/conversion_1.0/ia_css_conversion.host.h" > -/* Generated code: do not edit or commmit. */ > > #include "ia_css_pipeline.h" > #include "ia_css_isp_params.h" > diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_params.h b/drivers/staging/media/atomisp/pci/ia_css_isp_params.h > index a542f8979905..8c9468c5849f 100644 > --- a/drivers/staging/media/atomisp/pci/ia_css_isp_params.h > +++ b/drivers/staging/media/atomisp/pci/ia_css_isp_params.h > @@ -4,7 +4,6 @@ > * Copyright (c) 2015, Intel Corporation. > */ > > -/* Generated code: do not edit or commmit. */ > > #ifndef _IA_CSS_ISP_PARAM_H Same. regards, dan carpenter
© 2016 - 2026 Red Hat, Inc.