[PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers

Pramod Maurya posted 2 patches 1 month ago
drivers/staging/rtl8723bs/include/cmd_osdep.h      | 9 ++++-----
drivers/staging/rtl8723bs/include/rtl8192c_recv.h  | 1 -
drivers/staging/rtl8723bs/include/rtl8723b_dm.h    | 1 -
drivers/staging/rtl8723bs/include/rtw_ioctl_set.h  | 1 -
drivers/staging/rtl8723bs/include/rtw_wifi_regd.h  | 1 -
drivers/staging/rtl8723bs/include/sdio_ops_linux.h | 1 -
6 files changed, 4 insertions(+), 10 deletions(-)
[PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers
Posted by Pramod Maurya 1 month ago
This series fixes two separate checkpatch.pl warnings in the rtl8723bs
include headers, split into one patch per logical change:

1. Remove superfluous consecutive blank lines from six header files.
2. Remove the redundant extern keyword from function prototype
   declarations in cmd_osdep.h and fix extra whitespace in struct
   parameter types.

v2: Split into one patch per logical change as requested by Nikolay
    Kulikov. Added cover letter. Previous combined patch was sent as
    "[PATCH 2/2] staging: rtl8723bs: Fix coding style in include headers".

Pramod Maurya (2):
  staging: rtl8723bs: Remove multiple blank lines in include headers
  staging: rtl8723bs: Remove extern from function prototypes in
    cmd_osdep.h

 drivers/staging/rtl8723bs/include/cmd_osdep.h      | 9 ++++-----
 drivers/staging/rtl8723bs/include/rtl8192c_recv.h  | 1 -
 drivers/staging/rtl8723bs/include/rtl8723b_dm.h    | 1 -
 drivers/staging/rtl8723bs/include/rtw_ioctl_set.h  | 1 -
 drivers/staging/rtl8723bs/include/rtw_wifi_regd.h  | 1 -
 drivers/staging/rtl8723bs/include/sdio_ops_linux.h | 1 -
 6 files changed, 4 insertions(+), 10 deletions(-)

-- 
2.52.0
Re: [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers
Posted by Nikolay Kulikov 1 month ago
On Sun, May 10, 2026 at 01:51:01PM -0400, Pramod Maurya wrote:
> This series fixes two separate checkpatch.pl warnings in the rtl8723bs
> include headers, split into one patch per logical change:
> 
> 1. Remove superfluous consecutive blank lines from six header files.
> 2. Remove the redundant extern keyword from function prototype
>    declarations in cmd_osdep.h and fix extra whitespace in struct
>    parameter types.
> 
> v2: Split into one patch per logical change as requested by Nikolay
>     Kulikov. Added cover letter. Previous combined patch was sent as
>     "[PATCH 2/2] staging: rtl8723bs: Fix coding style in include headers".
> 
> Pramod Maurya (2):
>   staging: rtl8723bs: Remove multiple blank lines in include headers
>   staging: rtl8723bs: Remove extern from function prototypes in
>     cmd_osdep.h
> 
>  drivers/staging/rtl8723bs/include/cmd_osdep.h      | 9 ++++-----
>  drivers/staging/rtl8723bs/include/rtl8192c_recv.h  | 1 -
>  drivers/staging/rtl8723bs/include/rtl8723b_dm.h    | 1 -
>  drivers/staging/rtl8723bs/include/rtw_ioctl_set.h  | 1 -
>  drivers/staging/rtl8723bs/include/rtw_wifi_regd.h  | 1 -
>  drivers/staging/rtl8723bs/include/sdio_ops_linux.h | 1 -
>  6 files changed, 4 insertions(+), 10 deletions(-)
> 
> -- 
> 2.52.0
> 

Looks good to me.

Reviewed-by: Nikolay Kulikov <nikolayof23@gmail.com>


Thanks,
Nikolay