[PATCH v3 0/1] dt-bindings: iio: dds: Add AD9832/AD9835 binding

Hungyu Lin posted 1 patch 1 month ago
.../bindings/iio/dds/adi,ad9832.yaml          | 91 +++++++++++++++++++
1 file changed, 91 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
[PATCH v3 0/1] dt-bindings: iio: dds: Add AD9832/AD9835 binding
Posted by Hungyu Lin 1 month ago
This series adds devicetree binding documentation for the
Analog Devices AD9832 and AD9835 DDS devices.

v3:
  - Require spi-cpol in binding and example
  - Use generic node name (dds@0) in example

v2:
  - Add SPI peripheral schema reference
  - Fix example by adding clock and regulator providers
  - Fix SPDX license format

Hungyu Lin (1):
  dt-bindings: iio: dds: Add AD9832/AD9835 binding

 .../bindings/iio/dds/adi,ad9832.yaml          | 91 +++++++++++++++++++
 1 file changed, 91 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml

-- 
2.34.1
Re: [PATCH v3 0/1] dt-bindings: iio: dds: Add AD9832/AD9835 binding
Posted by Sanjay Chitroda 1 month ago

On 9 May 2026 7:07:44 am IST, Hungyu Lin <dennylin0707@gmail.com> wrote:
>This series adds devicetree binding documentation for the
>Analog Devices AD9832 and AD9835 DDS devices.
>
>v3:
>  - Require spi-cpol in binding and example
>  - Use generic node name (dds@0) in example
>

Hi,

Thank you for the change.

Ideally, multiple logical changes should be split into series. For a single patch you can include changelog like this:

Signed-off-by: ....
---
Changes in v2:
- Add SPI peripheral schema reference
---
 .../bindings..
         | 94 +++++++++++++++++++

If reviewer specifically asked to update, you can mention in the changelog as well. for examle:

- Add SPI peripheral schema reference based on review comment from <Reviewer Name>

Replace <Reviewer Name> with the actual reviewer.

Thanks,
Sanjay

>v2:
>  - Add SPI peripheral schema reference
>  - Fix example by adding clock and regulator providers
>  - Fix SPDX license format
>
>Hungyu Lin (1):
>  dt-bindings: iio: dds: Add AD9832/AD9835 binding
>
> .../bindings/iio/dds/adi,ad9832.yaml          | 91 +++++++++++++++++++
> 1 file changed, 91 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
>
Re: [PATCH v3 0/1] dt-bindings: iio: dds: Add AD9832/AD9835 binding
Posted by Jonathan Cameron 1 month ago
On Sat, 09 May 2026 07:40:55 +0530
Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:

> On 9 May 2026 7:07:44 am IST, Hungyu Lin <dennylin0707@gmail.com> wrote:
> >This series adds devicetree binding documentation for the
> >Analog Devices AD9832 and AD9835 DDS devices.
> >
> >v3:
> >  - Require spi-cpol in binding and example
> >  - Use generic node name (dds@0) in example
> >  
> 
> Hi,
> 
> Thank you for the change.
> 
> Ideally, multiple logical changes should be split into series. For a single patch you can include changelog like this:

Whilst in general that is true, here we are talking about a single
device tree binding.  Those are almost always single patch affairs
as they aren't normally that complex.

Jonathan

> 
> Signed-off-by: ....
> ---
> Changes in v2:
> - Add SPI peripheral schema reference
> ---
>  .../bindings..
>          | 94 +++++++++++++++++++
> 
> If reviewer specifically asked to update, you can mention in the changelog as well. for examle:
> 
> - Add SPI peripheral schema reference based on review comment from <Reviewer Name>
> 
> Replace <Reviewer Name> with the actual reviewer.
> 
> Thanks,
> Sanjay
> 
> >v2:
> >  - Add SPI peripheral schema reference
> >  - Fix example by adding clock and regulator providers
> >  - Fix SPDX license format
> >
> >Hungyu Lin (1):
> >  dt-bindings: iio: dds: Add AD9832/AD9835 binding
> >
> > .../bindings/iio/dds/adi,ad9832.yaml          | 91 +++++++++++++++++++
> > 1 file changed, 91 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> >