Hi,
it was a known limitation, in the SCMI Clock protocol support, the lack of
dynamic allocation around per-clock rates discovery: fixed size statically
per-clock rates arrays did not scale and was increasingly a waste of memory
(see [1]).
This series aim at solving this in successive steps:
- simplify and reduce to the minimum possible the rates data info exposed
to the SCMI driver by scmi_clock_info
- move away from static fixed allocation of per-clock rates arrays in
favour of a completely dynamic runtime allocation: just allocate what
is needed based on the effectively discovered
This is done in patches 2-6.
A further bigger optimization suggested in a past series [2] by Etienne
would be, whenever allowed by the spec, to limit upfront the number of
queries in order to simply retrieve min and max rate, that are indeed the
only rates needed by the CLK SCMI driver.
The approach proposed in [1] was open coding and duplicating some of the
functionalities already provided by SCMI iterators, though.
Patch 7-14 implement such optimization instead by:
- reworking core SCMI iterators to support bound enumerations
- use such new bound iterators to perform the minimum number of queries
in order to only retrieve min an max rate
As a final result now the rates enumeration triggered by the CLK SCMI
driver, while still allocating for all the existent rates, miminize the
number of SCMI CLK_DESCRIBE_RATE messages needed to obtain min and max.
Finally, patch 15 introduces a new clock protocol operation to be able to
trigger anytime on demand a full enumeration and obtain the full list of
rates when needed, not only min/max: this latter method is really only used
currently by some dowstream SCMI Test driver of mine.
Most notably in V3 I had:
- picked up Geert fixes on V2: these could have been squashed in the
original series while maintaining proper Geert's authorship but as of
now I have simply picked them up and changed their order to be near the
commit they fix
- dropped the "Harden Clock protocol initialization" patch that caused a
number of out-of-spec vendor FW to break
Based on v7.1-rc2.
Tested on ARM/JUNO, RADXA/ROCK5B and an emulated environment.
Any feeback welcome.
Thanks,
Cristian
[1]: https://lore.kernel.org/arm-scmi/aZsX-oplR6fiLBBN@pluto/T/#t
[2]: https://lore.kernel.org/20241203173908.3148794-2-etienne.carriere@foss.st.com
---
v3 -->v4
- Rebased on v7.1-rc2
- Removed unused info.rate_discrete [Geert]
- Made dev_dbg() more meaningful by printing tot_rates [Geert]
- Fixed build bisectability by renaming properly to iter_response_bound_cleanup()
v2 --> v3
- Rebased on v7.1-rc1
- Picked up Geert fixes
- Dropped patch breaking out-of-spec FW (Harden Clock Protocol init)
- Collected Reviewed tags
v1 --> v2
- Rebased on v7.0-rc3
- Added a Fixes patch to rectify bug in rounding algo
- Removed useless parenthesis in macros
- Collected a few Reviewed-by tags
- Clarified commit message
Cristian Marussi (12):
clk: scmi: Fix clock rate rounding
firmware: arm_scmi: Add clock determine_rate operation
clk: scmi: Use new determine_rate clock operation
firmware: arm_scmi: Simplify clock rates exposed interface
clk: scmi: Use new simplified per-clock rate properties
firmware: arm_scmi: Drop unused clock rate interfaces
firmware: arm_scmi: Make clock rates allocation dynamic
firmware: arm_scmi: Harden clock parents discovery
firmware: arm_scmi: Refactor iterators internal allocation
firmware: arm_scmi: Add bound iterators support
firmware: arm_scmi: Use bound iterators to minimize discovered rates
firmware: arm_scmi: Introduce all_rates_get clock operation
Geert Uytterhoeven (3):
firmware: arm_scmi: Fix bound iterators returning too many items
firmware: arm_scmi: Use proper iter_response_bound_cleanup() name
firmware: arm_scmi: Fix OOB in scmi_clock_describe_rates_get_lazy()
drivers/clk/clk-scmi.c | 48 +---
drivers/firmware/arm_scmi/clock.c | 301 ++++++++++++++++++++------
drivers/firmware/arm_scmi/driver.c | 80 +++++--
drivers/firmware/arm_scmi/protocols.h | 13 +-
include/linux/scmi_protocol.h | 30 +--
5 files changed, 324 insertions(+), 148 deletions(-)
--
2.53.0