[PATCH net-next v2 0/9] net: atlantic: add PTP support for AQC113 (Antigua)

sukhdeeps@marvell.com posted 9 patches 1 month ago
There is a newer version of this series
drivers/net/ethernet/aquantia/atlantic/aq_filters.c          |  64 +-
drivers/net/ethernet/aquantia/atlantic/aq_filters.h          |   3 +
drivers/net/ethernet/aquantia/atlantic/aq_hw.h               |  37 +-
drivers/net/ethernet/aquantia/atlantic/aq_main.c             |  33 +-
drivers/net/ethernet/aquantia/atlantic/aq_nic.c              |  51 +-
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c         |   4 +-
drivers/net/ethernet/aquantia/atlantic/aq_ptp.c              | 531 +++++++--
drivers/net/ethernet/aquantia/atlantic/aq_ptp.h              |  15 +-
drivers/net/ethernet/aquantia/atlantic/aq_ring.c             |  42 +-
drivers/net/ethernet/aquantia/atlantic/aq_ring.h             |   4 +-
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c   |  15 +-
drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2.c    | 813 +++++++++++-
drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2.h    |  12 +
drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_internal.h | 69 +-
drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_llh.c | 360 ++++++
drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_llh.h | 107 +-
drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_llh_internal.h | 204 ++-
drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils.c |  33 +
drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils.h |  15 +
drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils_fw.c |  52 +
20 files changed, 2244 insertions(+), 224 deletions(-)
[PATCH net-next v2 0/9] net: atlantic: add PTP support for AQC113 (Antigua)
Posted by sukhdeeps@marvell.com 1 month ago
From: Sukhdeep Singh <sukhdeeps@marvell.com>

This series adds IEEE 1588 PTP support for the AQC113 (Antigua) network
controller. AQC113 is the successor to the existing AQC107 (Atlantic)
chip already supported by the atlantic driver.

AQC113 uses a substantially different hardware architecture for PTP
compared to AQC107:

  - Dual on-chip TSG clocks with direct register access instead of
    PHY-based timestamping via firmware
  - TX timestamps via descriptor writeback instead of firmware mailbox
  - Hardware L3/L4 RX filters for PTP multicast steering with both
    IPv4 and IPv6 support
  - Reference-counted shared filter slots managed through an Action
    Resolver Table (ART), allowing multiple rules to share L3/L4
    hardware filters when their match criteria are identical

The series is structured in three parts:

Patches 1-3 prepare the existing L3/L4 filter path:

  Patch 1 corrects flow_type masking and IPv6 address handling in
  aq_set_data_fl3l4(). Patch 2 moves the active_ipv4/ipv6 bitmap
  updates to after the hardware write succeeds. Patch 3 decouples
  the function from driver-internal structures so it can be called
  directly by the AQC113 PTP filter setup code.

Patches 4-6 add the AQC113 hardware infrastructure:

  Patch 4 adds the low-level register definitions and accessor
  functions. Patch 5 adds filter data structures and firmware
  capability query. Patch 6 implements the complete L2/L3/L4 RX
  filter management layer including the reference-counted sharing
  and ART integration.

Patches 7-9 add the AQC113 PTP feature:

  Patch 7 reserves the dedicated PTP traffic class buffer and
  configures the TX path. Patch 8 extends the hw_ops interface
  with PTP-specific function pointers and updates AQC107 to the
  new signatures. Patch 9 implements the full PTP subsystem
  integration for AQC113.

The existing AQC107 PTP implementation is not functionally changed
by this series; AQC113-specific code paths are gated on chip
detection throughout.

Tested on AQC113 at 1G, 2.5G, 5G, and 10G link speeds using
ptp4l/phc2sys with hardware timestamping in both L2 and L4
(IPv4/IPv6) modes.

Changes in v2:
- Patch 6: Remove redundant variable initializers for art_mask, h, l
  and err as suggested by Vadim Fedorenko

Sukhdeep Singh (9):
  net: atlantic: correct L3L4 filter flow_type masking and IPv6 handling
  net: atlantic: move active_ipv4/ipv6 bitmap updates after HW write
  net: atlantic: decouple aq_set_data_fl3l4() from driver internals
  net: atlantic: add AQC113 hardware register definitions and accessors
  net: atlantic: add AQC113 filter data structures and firmware query
  net: atlantic: implement AQC113 L2/L3/L4 RX filter management
  net: atlantic: add AQC113 PTP traffic class and TX path setup
  net: atlantic: extend hw_ops and TX descriptor for AQC113 PTP
  net: atlantic: add PTP support for AQC113 (Antigua)

 drivers/net/ethernet/aquantia/atlantic/aq_filters.c          |  64 +-
 drivers/net/ethernet/aquantia/atlantic/aq_filters.h          |   3 +
 drivers/net/ethernet/aquantia/atlantic/aq_hw.h               |  37 +-
 drivers/net/ethernet/aquantia/atlantic/aq_main.c             |  33 +-
 drivers/net/ethernet/aquantia/atlantic/aq_nic.c              |  51 +-
 drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c         |   4 +-
 drivers/net/ethernet/aquantia/atlantic/aq_ptp.c              | 531 +++++++--
 drivers/net/ethernet/aquantia/atlantic/aq_ptp.h              |  15 +-
 drivers/net/ethernet/aquantia/atlantic/aq_ring.c             |  42 +-
 drivers/net/ethernet/aquantia/atlantic/aq_ring.h             |   4 +-
 drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c   |  15 +-
 drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2.c    | 813 +++++++++++-
 drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2.h    |  12 +
 drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_internal.h | 69 +-
 drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_llh.c | 360 ++++++
 drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_llh.h | 107 +-
 drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_llh_internal.h | 204 ++-
 drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils.c |  33 +
 drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils.h |  15 +
 drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_utils_fw.c |  52 +
 20 files changed, 2244 insertions(+), 224 deletions(-)

-- 
2.43.0
Re: [PATCH net-next v2 0/9] net: atlantic: add PTP support for AQC113 (Antigua)
Posted by Jakub Kicinski 1 month ago
On Fri, 8 May 2026 17:31:47 +0530 sukhdeeps@marvell.com wrote:
> From: Sukhdeep Singh <sukhdeeps@marvell.com>

I have a process question. Who is maintaining this driver?
MAINTAINERS list Igor but he didn't sign off any of the patches.
Occasionally we get patches for this driver from users and other
developers and none of you Marvell people respond. 
Please have a read of:
https://docs.kernel.org/next/maintainer/feature-and-driver-maintainers.html
and tell me - who is serving as the maintainer of atlantic?
Re: [PATCH net-next v2 0/9] net: atlantic: add PTP support for AQC113 (Antigua)
Posted by Simon Horman 1 month ago
On Fri, May 08, 2026 at 05:31:47PM +0530, sukhdeeps@marvell.com wrote:
> From: Sukhdeep Singh <sukhdeeps@marvell.com>
> 
> This series adds IEEE 1588 PTP support for the AQC113 (Antigua) network
> controller. AQC113 is the successor to the existing AQC107 (Atlantic)
> chip already supported by the atlantic driver.

...

Hi Sukhdeep,

There are AI-generated reviews of this patchset available on
https://netdev-ai.bots.linux.dev and https://sashiko.dev
with some overlap between them.

I would appreciate it if you could look over these and address issues that
are either introduced by or effect the functionality of this patch-set.  I
suggest leaving other pre-existing issues as follow-up so as not to expand
the scope of this patch-set.