[PATCH v2 00/13] TI: K3 DTS: fix USB Clocking for Compliance

Siddharth Vadapalli posted 13 patches 1 month, 1 week ago
.../boot/dts/ti/k3-am642-hummingboard-t-usb3.dts  |  9 +++++++++
.../boot/dts/ti/k3-am642-phyboard-electra-rdk.dts |  9 +++++++++
arch/arm64/boot/dts/ti/k3-am642-sk.dts            |  6 ++++++
.../boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl.dts   |  9 +++++++++
arch/arm64/boot/dts/ti/k3-am68-phyboard-izar.dts  |  9 +++++++++
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts  |  9 +++++++++
arch/arm64/boot/dts/ti/k3-am69-aquila.dtsi        |  6 ++++++
arch/arm64/boot/dts/ti/k3-am69-sk.dts             |  6 ++++++
.../arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 15 +++++++++++++++
.../boot/dts/ti/k3-j721e-common-proc-board.dts    |  6 ++++++
arch/arm64/boot/dts/ti/k3-j721e-sk.dts            | 15 +++++++++++++++
arch/arm64/boot/dts/ti/k3-j722s-evm.dts           |  6 ++++++
.../boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi  |  6 ++++++
13 files changed, 111 insertions(+)
[PATCH v2 00/13] TI: K3 DTS: fix USB Clocking for Compliance
Posted by Siddharth Vadapalli 1 month, 1 week ago
Hello,

This series enables Internal Spread Spectrum Clocking (SSC) for USB
SuperSpeed configuration. This is mandated by the USB Specification
section 6.5.3 Normative Spread Spectrum Clocking (SSC).

Series has been posted as individual patches for respective boards since
the Fixes tag is different for each board and needs to be backported via
stable.

Series is based on commit
74fe02ce122a Merge tag 'wq-for-7.1-rc2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq
of Mainline Linux.

v1 of this series is at:
https://lore.kernel.org/r/20260505110631.1144200-1-s-vadapalli@ti.com/
Changes since v1:
- Collected Acked-by tag on patch 1 from Josua Mayer <josua@solid-run.com>
- Reordered properties in patches 7, 8, 12 and 13 to have 'status' at the
  end of the node based on feedback from Francesco Dolcini <francesco@dolcini.it>

Series has been tested on the following boards:
1. AM642-SK
https://gist.github.com/Siddharth-Vadapalli-at-TI/d4aecc572697bd02bb65a0fe5efea393
2. AM68-SK-Baseboard
https://gist.github.com/Siddharth-Vadapalli-at-TI/371aacaada2b236776455be5fa15e593
3. AM69-SK
https://gist.github.com/Siddharth-Vadapalli-at-TI/1d7c6c3a5cbe6ec2bc966887c3e4d913
4. J721E-Common-Processor-Board
https://gist.github.com/Siddharth-Vadapalli-at-TI/f815f1a9b400ba492133e43c36f69936
5. J721E-SK
https://gist.github.com/Siddharth-Vadapalli-at-TI/0d1e4e72b47ab1482b5b7d1247bc8bfa
6. J722S-EVM
https://gist.github.com/Siddharth-Vadapalli-at-TI/146533f0a89bde59b47ead582a924e62
7. J742S2-EVM
https://gist.github.com/Siddharth-Vadapalli-at-TI/be8ed3e339441b7301f57ad006868238
8. J784S4-EVM
https://gist.github.com/Siddharth-Vadapalli-at-TI/62795430857387491162b21d9c9692d0

Regards,
Siddharth.

Luis Parga (2):
  arm64: dts: ti: k3-am642-sk: fix USB clocking for compliance
  arm64: dts: ti: k3-j722s-evm: fix USB clocking for compliance

Siddharth Vadapalli (11):
  arm64: dts: ti: k3-am642-hummingboard-t: fix USB clocking for
    compliance
  arm64: dts: ti: k3-am642-phyboard-electra-rdk: fix USB clocking for
    compliance
  arm64: dts: ti: k3-am642-tqma64xxl: fix USB clocking for compliance
  arm64: dts: ti: k3-am68-phyboard-izar: fix USB clocking for compliance
  arm64: dts: ti: k3-am68-sk-baseboard: fix USB clocking for compliance
  arm64: dts: ti: k3-am69-aquila: fix USB clocking for compliance
  arm64: dts: ti: k3-am69-sk: fix USB clocking for compliance
  arm64: dts: ti: k3-j721e-beagleboneai64: fix USB clocking for
    compliance
  arm64: dts: ti: k3-j721e-common-proc-board: fix USB clocking for
    compliance
  arm64: dts: ti: k3-j721e-sk: fix USB clocking for compliance
  arm64: dts: ti: k3-j784s4-j742s2-evm-common: fix USB clocking for
    compliance

 .../boot/dts/ti/k3-am642-hummingboard-t-usb3.dts  |  9 +++++++++
 .../boot/dts/ti/k3-am642-phyboard-electra-rdk.dts |  9 +++++++++
 arch/arm64/boot/dts/ti/k3-am642-sk.dts            |  6 ++++++
 .../boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl.dts   |  9 +++++++++
 arch/arm64/boot/dts/ti/k3-am68-phyboard-izar.dts  |  9 +++++++++
 arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts  |  9 +++++++++
 arch/arm64/boot/dts/ti/k3-am69-aquila.dtsi        |  6 ++++++
 arch/arm64/boot/dts/ti/k3-am69-sk.dts             |  6 ++++++
 .../arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 15 +++++++++++++++
 .../boot/dts/ti/k3-j721e-common-proc-board.dts    |  6 ++++++
 arch/arm64/boot/dts/ti/k3-j721e-sk.dts            | 15 +++++++++++++++
 arch/arm64/boot/dts/ti/k3-j722s-evm.dts           |  6 ++++++
 .../boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi  |  6 ++++++
 13 files changed, 111 insertions(+)

-- 
2.51.1
Re: [PATCH v2 00/13] TI: K3 DTS: fix USB Clocking for Compliance
Posted by Robert Nelson 1 month, 1 week ago
On Wed, May 6, 2026 at 9:08 AM Siddharth Vadapalli <s-vadapalli@ti.com> wrote:
>
> Hello,
>
> This series enables Internal Spread Spectrum Clocking (SSC) for USB
> SuperSpeed configuration. This is mandated by the USB Specification
> section 6.5.3 Normative Spread Spectrum Clocking (SSC).
>
> Series has been posted as individual patches for respective boards since
> the Fixes tag is different for each board and needs to be backported via
> stable.

While yes, that's true for stable branches.  Since these are so
similar, wouldn't it be best to push them to the board soc family
headers?

(Either way, I'll be backporting these for Beagle. ;) )

Regards,

-- 
Robert Nelson
https://rcn-ee.com/
Re: [PATCH v2 00/13] TI: K3 DTS: fix USB Clocking for Compliance
Posted by Siddharth Vadapalli 1 month, 1 week ago
On 06/05/26 22:37, Robert Nelson wrote:
> On Wed, May 6, 2026 at 9:08 AM Siddharth Vadapalli <s-vadapalli@ti.com> wrote:
>>
>> Hello,
>>
>> This series enables Internal Spread Spectrum Clocking (SSC) for USB
>> SuperSpeed configuration. This is mandated by the USB Specification
>> section 6.5.3 Normative Spread Spectrum Clocking (SSC).
>>
>> Series has been posted as individual patches for respective boards since
>> the Fixes tag is different for each board and needs to be backported via
>> stable.
> 
> While yes, that's true for stable branches.  Since these are so
> similar, wouldn't it be best to push them to the board soc family
> headers?

I see individual patches per board+SoC combination for new features as 
well. So having individual patches for Fixes seems to be preferred given 
that squashing all Fixes tags into a single patch doesn't make it easy for 
backporting and reverting in case of issues is also easier for individual 
patches.

> 
> (Either way, I'll be backporting these for Beagle. ;) )

Thank you.

Regards,
Siddharth.
Re: [PATCH v2 00/13] TI: K3 DTS: fix USB Clocking for Compliance
Posted by Nishanth Menon 1 month ago
On 12:14-20260507, Siddharth Vadapalli wrote:
> On 06/05/26 22:37, Robert Nelson wrote:
> > On Wed, May 6, 2026 at 9:08 AM Siddharth Vadapalli <s-vadapalli@ti.com> wrote:
> > > 
> > > Hello,
> > > 
> > > This series enables Internal Spread Spectrum Clocking (SSC) for USB
> > > SuperSpeed configuration. This is mandated by the USB Specification
> > > section 6.5.3 Normative Spread Spectrum Clocking (SSC).
> > > 
> > > Series has been posted as individual patches for respective boards since
> > > the Fixes tag is different for each board and needs to be backported via
> > > stable.
> > 
> > While yes, that's true for stable branches.  Since these are so
> > similar, wouldn't it be best to push them to the board soc family
> > headers?
> 
> I see individual patches per board+SoC combination for new features as well.
> So having individual patches for Fixes seems to be preferred given that
> squashing all Fixes tags into a single patch doesn't make it easy for
> backporting and reverting in case of issues is also easier for individual
> patches.

It is not clear to me the path to stable here.
1. Driver fixes
2. binding updates
3. dts fixes

How are we lining these up for stable?

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource
Re: [PATCH v2 00/13] TI: K3 DTS: fix USB Clocking for Compliance
Posted by Nishanth Menon 1 month ago
On 19:39-20260506, Siddharth Vadapalli wrote:
> Hello,
> 
> This series enables Internal Spread Spectrum Clocking (SSC) for USB
> SuperSpeed configuration. This is mandated by the USB Specification
> section 6.5.3 Normative Spread Spectrum Clocking (SSC).
> 
> Series has been posted as individual patches for respective boards since
> the Fixes tag is different for each board and needs to be backported via
> stable.
> 
> Series is based on commit
> 74fe02ce122a Merge tag 'wq-for-7.1-rc2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq
> of Mainline Linux.

I am on next-20260507
The serdes_wiz0 node here is bound by ti,phy-j721e-wiz.yaml (the node
uses compatible = "ti,am64-wiz-10g").  That binding has
additionalProperties: false and does not define ti,core-clk-sel,
ti,ssc-enable, ti,ssc-type, ti,ssc-frequency-hz, or
ti,ssc-depth-per-mil.
I see
arch/arm64/boot/dts/ti/k3-am642-hummingboard-t-usb3.dtb: wiz@f000000 (ti,am64-wiz-10g): 'ti,core-clk-sel', 'ti,ssc-depth-per-mil', 'ti,ssc-enable', 'ti,ssc-frequency-hz', 'ti,ssc-type' do not match any of the regexes: '^cmn-refclk1?-dig-div$', '^pinctrl-[0-9]+$', '^pll[0|1]-refclk$', '^serdes@[0-9a-f]+$'

and so on..

How does this series pass dtbs_check?

> 
> v1 of this series is at:
> https://lore.kernel.org/r/20260505110631.1144200-1-s-vadapalli@ti.com/
> Changes since v1:
> - Collected Acked-by tag on patch 1 from Josua Mayer <josua@solid-run.com>
> - Reordered properties in patches 7, 8, 12 and 13 to have 'status' at the
>   end of the node based on feedback from Francesco Dolcini <francesco@dolcini.it>
> 
> Series has been tested on the following boards:
> 1. AM642-SK
> https://gist.github.com/Siddharth-Vadapalli-at-TI/d4aecc572697bd02bb65a0fe5efea393
> 2. AM68-SK-Baseboard
> https://gist.github.com/Siddharth-Vadapalli-at-TI/371aacaada2b236776455be5fa15e593
> 3. AM69-SK
> https://gist.github.com/Siddharth-Vadapalli-at-TI/1d7c6c3a5cbe6ec2bc966887c3e4d913
> 4. J721E-Common-Processor-Board
> https://gist.github.com/Siddharth-Vadapalli-at-TI/f815f1a9b400ba492133e43c36f69936
> 5. J721E-SK
> https://gist.github.com/Siddharth-Vadapalli-at-TI/0d1e4e72b47ab1482b5b7d1247bc8bfa
> 6. J722S-EVM
> https://gist.github.com/Siddharth-Vadapalli-at-TI/146533f0a89bde59b47ead582a924e62
> 7. J742S2-EVM
> https://gist.github.com/Siddharth-Vadapalli-at-TI/be8ed3e339441b7301f57ad006868238
> 8. J784S4-EVM
> https://gist.github.com/Siddharth-Vadapalli-at-TI/62795430857387491162b21d9c9692d0
> 
> Regards,
> Siddharth.
> 
> Luis Parga (2):
>   arm64: dts: ti: k3-am642-sk: fix USB clocking for compliance
>   arm64: dts: ti: k3-j722s-evm: fix USB clocking for compliance
> 
> Siddharth Vadapalli (11):
>   arm64: dts: ti: k3-am642-hummingboard-t: fix USB clocking for
>     compliance
>   arm64: dts: ti: k3-am642-phyboard-electra-rdk: fix USB clocking for
>     compliance
>   arm64: dts: ti: k3-am642-tqma64xxl: fix USB clocking for compliance
>   arm64: dts: ti: k3-am68-phyboard-izar: fix USB clocking for compliance
>   arm64: dts: ti: k3-am68-sk-baseboard: fix USB clocking for compliance
>   arm64: dts: ti: k3-am69-aquila: fix USB clocking for compliance
>   arm64: dts: ti: k3-am69-sk: fix USB clocking for compliance
>   arm64: dts: ti: k3-j721e-beagleboneai64: fix USB clocking for
>     compliance
>   arm64: dts: ti: k3-j721e-common-proc-board: fix USB clocking for
>     compliance
>   arm64: dts: ti: k3-j721e-sk: fix USB clocking for compliance
>   arm64: dts: ti: k3-j784s4-j742s2-evm-common: fix USB clocking for
>     compliance
> 
>  .../boot/dts/ti/k3-am642-hummingboard-t-usb3.dts  |  9 +++++++++
>  .../boot/dts/ti/k3-am642-phyboard-electra-rdk.dts |  9 +++++++++
>  arch/arm64/boot/dts/ti/k3-am642-sk.dts            |  6 ++++++
>  .../boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl.dts   |  9 +++++++++
>  arch/arm64/boot/dts/ti/k3-am68-phyboard-izar.dts  |  9 +++++++++
>  arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts  |  9 +++++++++
>  arch/arm64/boot/dts/ti/k3-am69-aquila.dtsi        |  6 ++++++
>  arch/arm64/boot/dts/ti/k3-am69-sk.dts             |  6 ++++++
>  .../arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 15 +++++++++++++++
>  .../boot/dts/ti/k3-j721e-common-proc-board.dts    |  6 ++++++
>  arch/arm64/boot/dts/ti/k3-j721e-sk.dts            | 15 +++++++++++++++
>  arch/arm64/boot/dts/ti/k3-j722s-evm.dts           |  6 ++++++
>  .../boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi  |  6 ++++++
>  13 files changed, 111 insertions(+)
> 
> -- 
> 2.51.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource