pinctrl: qcom: nord: remove duplicated pin function

[PATCH] pinctrl: qcom: nord: remove duplicated pin function

Posted by Bartosz Golaszewski 1 month, 1 week ago

The qdss_cti function is initialized twice in the nord_functions array.
Remove the duplicate entry.

Fixes: c24dd0826f06 ("pinctrl: qcom: add the TLMM driver for the Nord platforms")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605061633.BJLI5voT-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 drivers/pinctrl/qcom/pinctrl-nord.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-nord.c b/drivers/pinctrl/qcom/pinctrl-nord.c
index f14361101bf4..7c21306e77ff 100644
--- a/drivers/pinctrl/qcom/pinctrl-nord.c
+++ b/drivers/pinctrl/qcom/pinctrl-nord.c
@@ -1417,7 +1417,6 @@ static const struct pinfunction nord_functions[] = {
 	MSM_PIN_FUNCTION(prng_rosc0),
 	MSM_PIN_FUNCTION(prng_rosc1),
 	MSM_PIN_FUNCTION(pwrbrk_i_n),
-	MSM_PIN_FUNCTION(qdss_cti),
 	MSM_PIN_FUNCTION(qdss),
 	MSM_PIN_FUNCTION(qdss_cti),
 	MSM_PIN_FUNCTION(qspi),
-- 
2.47.3

Re: [PATCH] pinctrl: qcom: nord: remove duplicated pin function

Posted by Linus Walleij 1 month, 1 week ago

On Wed, May 6, 2026 at 11:00 AM Bartosz Golaszewski
<bartosz.golaszewski@oss.qualcomm.com> wrote:

> The qdss_cti function is initialized twice in the nord_functions array.
> Remove the duplicate entry.
>
> Fixes: c24dd0826f06 ("pinctrl: qcom: add the TLMM driver for the Nord platforms")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605061633.BJLI5voT-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Patch applied!

Yours,
Linus Walleij

Re: [PATCH] pinctrl: qcom: nord: remove duplicated pin function

Posted by Krzysztof Kozlowski 1 month, 1 week ago

On 06/05/2026 11:00, Bartosz Golaszewski wrote:
> The qdss_cti function is initialized twice in the nord_functions array.
> Remove the duplicate entry.
> 
> Fixes: c24dd0826f06 ("pinctrl: qcom: add the TLMM driver for the Nord platforms")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605061633.BJLI5voT-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
>  drivers/pinctrl/qcom/pinctrl-nord.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-nord.c b/drivers/pinctrl/qcom/pinctrl-nord.c
> index f14361101bf4..7c21306e77ff 100644
> --- a/drivers/pinctrl/qcom/pinctrl-nord.c
> +++ b/drivers/pinctrl/qcom/pinctrl-nord.c
> @@ -1417,7 +1417,6 @@ static const struct pinfunction nord_functions[] = {
>  	MSM_PIN_FUNCTION(prng_rosc0),
>  	MSM_PIN_FUNCTION(prng_rosc1),
>  	MSM_PIN_FUNCTION(pwrbrk_i_n),
> -	MSM_PIN_FUNCTION(qdss_cti),
>  	MSM_PIN_FUNCTION(qdss),
>  	MSM_PIN_FUNCTION(qdss_cti),
>  	MSM_PIN_FUNCTION(qspi),

I also see on my allyes builders -Winitializer-overrides.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH] pinctrl: qcom: nord: remove duplicated pin function

Posted by Konrad Dybcio 1 month, 1 week ago

On 5/6/26 11:00 AM, Bartosz Golaszewski wrote:
> The qdss_cti function is initialized twice in the nord_functions array.
> Remove the duplicate entry.
> 
> Fixes: c24dd0826f06 ("pinctrl: qcom: add the TLMM driver for the Nord platforms")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605061633.BJLI5voT-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad