[PATCH v3] bus: ts-nbus: drop unneeded dependency on OF_GPIO

Bartosz Golaszewski posted 1 patch 1 month, 1 week ago
drivers/bus/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v3] bus: ts-nbus: drop unneeded dependency on OF_GPIO
Posted by Bartosz Golaszewski 1 month, 1 week ago
OF_GPIO is selected automatically on all OF systems. Any symbols it
controls also provide stubs and are private to GPIOLIB anyway so there's
really no reason to select it explicitly.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Changes in v3:
- Send the bus patch separately so that it can be picked up for v7.2
- Link to v2: https://patch.msgid.link/20260316-gpio-of-kconfig-v2-0-de2f4b00a0e4@oss.qualcomm.com

Changes in v2:
- Make gpio-watchdog depend on OF && GPIOLIB
- Drop picked up patches
- Link to v1: https://patch.msgid.link/20260304-gpio-of-kconfig-v1-0-d597916e79e7@oss.qualcomm.com

 drivers/bus/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 3181d8aa32a3..e4b1db809187 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -216,7 +216,7 @@ config TI_SYSC
 config TS_NBUS
 	tristate "Technologic Systems NBUS Driver"
 	depends on SOC_IMX28
-	depends on OF_GPIO && PWM
+	depends on PWM
 	help
 	  Driver for the Technologic Systems NBUS which is used to interface
 	  with the peripherals in the FPGA of the TS-4600 SoM.
-- 
2.47.3
Re: [PATCH v3] bus: ts-nbus: drop unneeded dependency on OF_GPIO
Posted by Bartosz Golaszewski 5 days, 6 hours ago
On Wed, 06 May 2026 10:19:59 +0200, Bartosz Golaszewski wrote:
> OF_GPIO is selected automatically on all OF systems. Any symbols it
> controls also provide stubs and are private to GPIOLIB anyway so there's
> really no reason to select it explicitly.
> 
> 

Applied, thanks!

[1/1] bus: ts-nbus: drop unneeded dependency on OF_GPIO
      https://git.kernel.org/brgl/c/c698cfec79eb71588b512e790fbf9e10a39c3179

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Re: [PATCH v3] bus: ts-nbus: drop unneeded dependency on OF_GPIO
Posted by Bartosz Golaszewski 3 weeks, 2 days ago
On Wed, May 6, 2026 at 10:20 AM Bartosz Golaszewski
<bartosz.golaszewski@oss.qualcomm.com> wrote:
>
> OF_GPIO is selected automatically on all OF systems. Any symbols it
> controls also provide stubs and are private to GPIOLIB anyway so there's
> really no reason to select it explicitly.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> Changes in v3:
> - Send the bus patch separately so that it can be picked up for v7.2
> - Link to v2: https://patch.msgid.link/20260316-gpio-of-kconfig-v2-0-de2f4b00a0e4@oss.qualcomm.com
>
> Changes in v2:
> - Make gpio-watchdog depend on OF && GPIOLIB
> - Drop picked up patches
> - Link to v1: https://patch.msgid.link/20260304-gpio-of-kconfig-v1-0-d597916e79e7@oss.qualcomm.com
>
>  drivers/bus/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index 3181d8aa32a3..e4b1db809187 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -216,7 +216,7 @@ config TI_SYSC
>  config TS_NBUS
>         tristate "Technologic Systems NBUS Driver"
>         depends on SOC_IMX28
> -       depends on OF_GPIO && PWM
> +       depends on PWM
>         help
>           Driver for the Technologic Systems NBUS which is used to interface
>           with the peripherals in the FPGA of the TS-4600 SoM.
> --
> 2.47.3
>

Gentle ping.

Bart
Re: [PATCH v3] bus: ts-nbus: drop unneeded dependency on OF_GPIO
Posted by Bartosz Golaszewski 1 week, 5 days ago
On Thu, May 21, 2026 at 2:36 PM Bartosz Golaszewski <brgl@kernel.org> wrote:
>
> On Wed, May 6, 2026 at 10:20 AM Bartosz Golaszewski
> <bartosz.golaszewski@oss.qualcomm.com> wrote:
> >
> > OF_GPIO is selected automatically on all OF systems. Any symbols it
> > controls also provide stubs and are private to GPIOLIB anyway so there's
> > really no reason to select it explicitly.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> > ---

...

>
> Gentle ping.
>
> Bart

There are no responses. If there are no objections, I will queue this
through the GPIO tree for v7.2 in the following days.

Bartosz
Re: [PATCH v3] bus: ts-nbus: drop unneeded dependency on OF_GPIO
Posted by Andy Shevchenko 1 week, 3 days ago
On Sun, May 31, 2026 at 06:49:55PM +0200, Bartosz Golaszewski wrote:
> On Thu, May 21, 2026 at 2:36 PM Bartosz Golaszewski <brgl@kernel.org> wrote:
> > On Wed, May 6, 2026 at 10:20 AM Bartosz Golaszewski
> > <bartosz.golaszewski@oss.qualcomm.com> wrote:
> > >
> > > OF_GPIO is selected automatically on all OF systems. Any symbols it
> > > controls also provide stubs and are private to GPIOLIB anyway so there's
> > > really no reason to select it explicitly.

...

> >
> > Gentle ping.
> 
> There are no responses. If there are no objections, I will queue this
> through the GPIO tree for v7.2 in the following days.

This is right thing to do, so
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

whatever tree it goes through.

-- 
With Best Regards,
Andy Shevchenko


Re: [PATCH v3] bus: ts-nbus: drop unneeded dependency on OF_GPIO
Posted by Andy Shevchenko 1 month, 1 week ago
On Wed, May 06, 2026 at 10:19:59AM +0200, Bartosz Golaszewski wrote:
> OF_GPIO is selected automatically on all OF systems. Any symbols it
> controls also provide stubs and are private to GPIOLIB anyway so there's
> really no reason to select it explicitly.

Is the plan to hide it from the user eventually?

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v3] bus: ts-nbus: drop unneeded dependency on OF_GPIO
Posted by Bartosz Golaszewski 1 month, 1 week ago
On Wed, May 6, 2026 at 10:34 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, May 06, 2026 at 10:19:59AM +0200, Bartosz Golaszewski wrote:
> > OF_GPIO is selected automatically on all OF systems. Any symbols it
> > controls also provide stubs and are private to GPIOLIB anyway so there's
> > really no reason to select it explicitly.
>
> Is the plan to hide it from the user eventually?
>

Yes, that's what I'm trying to do, but I need to remove all these
dependencies tree-wide first.

Bartosz

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>