[v1] ALSA: sparc/dbri: add missing fallthrough

[PATCH] ALSA: sparc/dbri: add missing fallthrough

Posted by Rosen Penev 1 month, 1 week ago

Fixes compiler error with probably newer compilers:

sound/sparc/dbri.c:595:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
  595 |         case 1:
      |         ^
sound/sparc/dbri.c:595:2: note: insert 'break;' to avoid fall-through
  595 |         case 1:
      |         ^
      |         break;

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 sound/sparc/dbri.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c
index 75f82a92ff44..2f5f62079fa4 100644
--- a/sound/sparc/dbri.c
+++ b/sound/sparc/dbri.c
@@ -592,6 +592,7 @@ static __u32 reverse_bytes(__u32 b, int len)
 		fallthrough;
 	case 2:
 		b = ((b & 0xaaaaaaaa) >> 1) | ((b & 0x55555555) << 1);
+		fallthrough;
 	case 1:
 	case 0:
 		break;
-- 
2.54.0

Re: [PATCH] ALSA: sparc/dbri: add missing fallthrough

Posted by Takashi Iwai 1 month, 1 week ago

On Wed, 06 May 2026 05:18:54 +0200,
Rosen Penev wrote:
> 
> Fixes compiler error with probably newer compilers:
> 
> sound/sparc/dbri.c:595:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
>   595 |         case 1:
>       |         ^
> sound/sparc/dbri.c:595:2: note: insert 'break;' to avoid fall-through
>   595 |         case 1:
>       |         ^
>       |         break;
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Applied now.  Thanks.


Takashi