net/mlx5: HWS: Reject unsupported remove-header action

[PATCH net v1] net/mlx5: HWS: Reject unsupported remove-header action

Posted by Prathamesh Deshpande 1 month, 1 week ago

mlx5_cmd_hws_packet_reformat_alloc() handles
MLX5_REFORMAT_TYPE_REMOVE_HDR by looking up a matching HWS remove-header
action.

If mlx5_fs_get_action_remove_header_vlan() returns NULL, the code only
logs an error and continues. The function then returns success with a NULL
HWS action stored in the packet-reformat object.

Return an error when no matching remove-header action is available.

Fixes: aecd9d1020e3 ("net/mlx5: fs, add HWS packet reformat API function")
Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
index aca77853abb8..5a172c572a68 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
@@ -1320,8 +1320,10 @@ mlx5_cmd_hws_packet_reformat_alloc(struct mlx5_flow_root_namespace *ns,
 		break;
 	case MLX5_REFORMAT_TYPE_REMOVE_HDR:
 		hws_action = mlx5_fs_get_action_remove_header_vlan(fs_ctx, params);
-		if (!hws_action)
+		if (!hws_action) {
 			mlx5_core_err(dev, "Only vlan remove header supported\n");
+			return -EOPNOTSUPP;
+		}
 		break;
 	default:
 		mlx5_core_err(ns->dev, "Packet-reformat not supported(%d)\n",
-- 
2.43.0

Re: [PATCH net v1] net/mlx5: HWS: Reject unsupported remove-header action

Posted by Simon Horman 1 month ago

On Wed, May 06, 2026 at 01:00:31AM +0100, Prathamesh Deshpande wrote:
> mlx5_cmd_hws_packet_reformat_alloc() handles
> MLX5_REFORMAT_TYPE_REMOVE_HDR by looking up a matching HWS remove-header
> action.
> 
> If mlx5_fs_get_action_remove_header_vlan() returns NULL, the code only
> logs an error and continues. The function then returns success with a NULL
> HWS action stored in the packet-reformat object.
> 
> Return an error when no matching remove-header action is available.
> 
> Fixes: aecd9d1020e3 ("net/mlx5: fs, add HWS packet reformat API function")
> Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net v1] net/mlx5: HWS: Reject unsupported remove-header action

Posted by Yevgeny Kliteynik 1 month ago

On 09-May-26 16:25, Simon Horman wrote:
> On Wed, May 06, 2026 at 01:00:31AM +0100, Prathamesh Deshpande wrote:
>> mlx5_cmd_hws_packet_reformat_alloc() handles
>> MLX5_REFORMAT_TYPE_REMOVE_HDR by looking up a matching HWS remove-header
>> action.
>>
>> If mlx5_fs_get_action_remove_header_vlan() returns NULL, the code only
>> logs an error and continues. The function then returns success with a NULL
>> HWS action stored in the packet-reformat object.
>>
>> Return an error when no matching remove-header action is available.
>>
>> Fixes: aecd9d1020e3 ("net/mlx5: fs, add HWS packet reformat API function")
>> Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
> 
> Reviewed-by: Simon Horman <horms@kernel.org>

Reviewed-by: Yevgeny Kliteynik <kliteyn@nvidia.com>

Re: [PATCH net v1] net/mlx5: HWS: Reject unsupported remove-header action

Posted by Tariq Toukan 2 weeks, 5 days ago


On 10/05/2026 11:10, Yevgeny Kliteynik wrote:
> On 09-May-26 16:25, Simon Horman wrote:
>> On Wed, May 06, 2026 at 01:00:31AM +0100, Prathamesh Deshpande wrote:
>>> mlx5_cmd_hws_packet_reformat_alloc() handles
>>> MLX5_REFORMAT_TYPE_REMOVE_HDR by looking up a matching HWS remove-header
>>> action.
>>>
>>> If mlx5_fs_get_action_remove_header_vlan() returns NULL, the code only
>>> logs an error and continues. The function then returns success with a 
>>> NULL
>>> HWS action stored in the packet-reformat object.
>>>
>>> Return an error when no matching remove-header action is available.
>>>
>>> Fixes: aecd9d1020e3 ("net/mlx5: fs, add HWS packet reformat API 
>>> function")
>>> Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
>>
>> Reviewed-by: Simon Horman <horms@kernel.org>
> 
> Reviewed-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
> 
> 
> 

I guess this is still pending my ack after Yevgeny's review?

Here:
Acked-by: Tariq Toukan <tariqt@nvidia.com>

Thanks.

Re: [PATCH net v1] net/mlx5: HWS: Reject unsupported remove-header action

Posted by Jakub Kicinski 2 weeks, 5 days ago

On Mon, 25 May 2026 13:34:32 +0300 Tariq Toukan wrote:
> On 10/05/2026 11:10, Yevgeny Kliteynik wrote:
> > On 09-May-26 16:25, Simon Horman wrote:  
> >> On Wed, May 06, 2026 at 01:00:31AM +0100, Prathamesh Deshpande wrote:  
> >> Reviewed-by: Simon Horman <horms@kernel.org>  
> > 
> > Reviewed-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
> 
> I guess this is still pending my ack after Yevgeny's review?
> 
> Here:
> Acked-by: Tariq Toukan <tariqt@nvidia.com>

Yes, for us to apply directly we need an ack from the person who sends
us the company PR. Too many false positive otherwise. Even people
listed in MAINTAINERS are not considered sufficient by other companies
so we play it safe :|