[PATCH] tpm: svsm: constify tpm_chip_ops

David Windsor posted 1 patch 1 month, 1 week ago
drivers/char/tpm/tpm_svsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] tpm: svsm: constify tpm_chip_ops
Posted by David Windsor 1 month, 1 week ago
Constify the SVSM vTPM ops. It is statically initialized and never
written to, so let's store it in .rodata.

Every other tpm_class_ops instance in drivers/char/tpm/ is already
const.

Signed-off-by: David Windsor <dwindsor@gmail.com>
---
 drivers/char/tpm/tpm_svsm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_svsm.c b/drivers/char/tpm/tpm_svsm.c
index f5ba0f64850b..b74d60f687d5 100644
--- a/drivers/char/tpm/tpm_svsm.c
+++ b/drivers/char/tpm/tpm_svsm.c
@@ -49,7 +49,7 @@ static int tpm_svsm_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz,
 	return svsm_vtpm_cmd_response_parse(priv->buffer, buf, bufsiz);
 }
 
-static struct tpm_class_ops tpm_chip_ops = {
+static const struct tpm_class_ops tpm_chip_ops = {
 	.flags = TPM_OPS_AUTO_STARTUP,
 	.send = tpm_svsm_send,
 };

base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
-- 
2.53.0
Re: [PATCH] tpm: svsm: constify tpm_chip_ops
Posted by Jarkko Sakkinen 1 month ago
On Tue, May 05, 2026 at 04:27:38PM -0400, David Windsor wrote:
> Constify the SVSM vTPM ops. It is statically initialized and never
> written to, so let's store it in .rodata.
> 
> Every other tpm_class_ops instance in drivers/char/tpm/ is already
> const.
> 
> Signed-off-by: David Windsor <dwindsor@gmail.com>
> ---
>  drivers/char/tpm/tpm_svsm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_svsm.c b/drivers/char/tpm/tpm_svsm.c
> index f5ba0f64850b..b74d60f687d5 100644
> --- a/drivers/char/tpm/tpm_svsm.c
> +++ b/drivers/char/tpm/tpm_svsm.c
> @@ -49,7 +49,7 @@ static int tpm_svsm_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz,
>  	return svsm_vtpm_cmd_response_parse(priv->buffer, buf, bufsiz);
>  }
>  
> -static struct tpm_class_ops tpm_chip_ops = {
> +static const struct tpm_class_ops tpm_chip_ops = {
>  	.flags = TPM_OPS_AUTO_STARTUP,
>  	.send = tpm_svsm_send,
>  };
> 
> base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
> -- 
> 2.53.0
> 

Thanks, applied.

BR, Jarkko
Re: [PATCH] tpm: svsm: constify tpm_chip_ops
Posted by Stefano Garzarella 1 month, 1 week ago
On Tue, May 05, 2026 at 04:27:38PM -0400, David Windsor wrote:
>Constify the SVSM vTPM ops. It is statically initialized and never
>written to, so let's store it in .rodata.
>
>Every other tpm_class_ops instance in drivers/char/tpm/ is already
>const.
>
>Signed-off-by: David Windsor <dwindsor@gmail.com>
>---
> drivers/char/tpm/tpm_svsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

LGTM!

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>