[PATCH] KVM: arm64: nv: Consider the DS bit when translating TCR_EL2

Wei-Lin Chang posted 1 patch 1 month, 1 week ago
There is a newer version of this series
arch/arm64/include/asm/kvm_nested.h | 1 +
1 file changed, 1 insertion(+)
[PATCH] KVM: arm64: nv: Consider the DS bit when translating TCR_EL2
Posted by Wei-Lin Chang 1 month, 1 week ago
When running an nVHE L1, TCR_EL2 is mapped to TCR_EL1. Writes to the
register are trapped and written to TCR_EL1 after a translation.
Booting an nVHE L1 with 52-bit VA isn't working because the translation
was ignoring the DS bit set by the guest, hence causing repeating level
0 faults. Add it in the translation function.

Signed-off-by: Wei-Lin Chang <weilin.chang@arm.com>
---
 arch/arm64/include/asm/kvm_nested.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/include/asm/kvm_nested.h b/arch/arm64/include/asm/kvm_nested.h
index 091544e6af44..dc2957662ff2 100644
--- a/arch/arm64/include/asm/kvm_nested.h
+++ b/arch/arm64/include/asm/kvm_nested.h
@@ -23,6 +23,7 @@ static inline u64 tcr_el2_ps_to_tcr_el1_ips(u64 tcr_el2)
 static inline u64 translate_tcr_el2_to_tcr_el1(u64 tcr)
 {
 	return TCR_EPD1_MASK |				/* disable TTBR1_EL1 */
+	       ((tcr & TCR_EL2_DS) ? TCR_DS : 0) |
 	       ((tcr & TCR_EL2_TBI) ? TCR_TBI0 : 0) |
 	       tcr_el2_ps_to_tcr_el1_ips(tcr) |
 	       (tcr & TCR_EL2_TG0_MASK) |
-- 
2.43.0
Re: [PATCH] KVM: arm64: nv: Consider the DS bit when translating TCR_EL2
Posted by Marc Zyngier 1 month, 1 week ago
On Tue, 05 May 2026 15:47:35 +0100, Wei-Lin Chang wrote:
> When running an nVHE L1, TCR_EL2 is mapped to TCR_EL1. Writes to the
> register are trapped and written to TCR_EL1 after a translation.
> Booting an nVHE L1 with 52-bit VA isn't working because the translation
> was ignoring the DS bit set by the guest, hence causing repeating level
> 0 faults. Add it in the translation function.
> 
> 
> [...]

Applied to fixes, thanks!

[1/1] KVM: arm64: nv: Consider the DS bit when translating TCR_EL2
      commit: 8d9b9d985ad3a81c751a6b97edaf1d3c0780af7c

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.