1. Patchew
  2. linux
  3. View series

[PATCH] dmaengine: Move MODULE_DEVICE_TABLE next to the table itself

Krzysztof Kozlowski posted 1 patch 1 month, 1 week ago
There is a newer version of this series
drivers/dma/hisi_dma.c | 2 +-
drivers/dma/pch_dma.c  | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[PATCH] dmaengine: Move MODULE_DEVICE_TABLE next to the table itself
Posted by Krzysztof Kozlowski 1 month, 1 week ago 
By convention MODULE_DEVICE_TABLE() immediately follows the ID table it
exports, because this is easier to read and verify.  It also makes more
sense since #ifdef for ACPI or OF could hide both of them.

Most of the privers already have this correctly placed, so adjust
the missing ones.  No functional impact.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/dma/hisi_dma.c | 2 +-
 drivers/dma/pch_dma.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/hisi_dma.c b/drivers/dma/hisi_dma.c
index 32a0e95c6a20..28bf818f9aa6 100644
--- a/drivers/dma/hisi_dma.c
+++ b/drivers/dma/hisi_dma.c
@@ -1037,6 +1037,7 @@ static const struct pci_device_id hisi_dma_pci_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, 0xa122) },
 	{ 0, }
 };
+MODULE_DEVICE_TABLE(pci, hisi_dma_pci_tbl);
 
 static struct pci_driver hisi_dma_pci_driver = {
 	.name		= "hisi_dma",
@@ -1050,4 +1051,3 @@ MODULE_AUTHOR("Zhou Wang <wangzhou1@hisilicon.com>");
 MODULE_AUTHOR("Zhenfa Qiu <qiuzhenfa@hisilicon.com>");
 MODULE_DESCRIPTION("HiSilicon Kunpeng DMA controller driver");
 MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(pci, hisi_dma_pci_tbl);
diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
index e9fbfd5a3d51..bf805f1024f6 100644
--- a/drivers/dma/pch_dma.c
+++ b/drivers/dma/pch_dma.c
@@ -970,6 +970,7 @@ static const struct pci_device_id pch_dma_id_table[] = {
 	{ PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ML7831_DMA2_4CH), 4}, /* SPI */
 	{ 0, },
 };
+MODULE_DEVICE_TABLE(pci, pch_dma_id_table);
 
 static SIMPLE_DEV_PM_OPS(pch_dma_pm_ops, pch_dma_suspend, pch_dma_resume);
 
@@ -987,4 +988,3 @@ MODULE_DESCRIPTION("Intel EG20T PCH / LAPIS Semicon ML7213/ML7223/ML7831 IOH "
 		   "DMA controller driver");
 MODULE_AUTHOR("Yong Wang <yong.y.wang@intel.com>");
 MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(pci, pch_dma_id_table);
-- 
2.51.0
Re: [PATCH] dmaengine: Move MODULE_DEVICE_TABLE next to the table itself
Posted by Pandey, Radhey Shyam 1 month ago 
On 5/5/2026 3:59 PM, Krzysztof Kozlowski wrote:
> By convention MODULE_DEVICE_TABLE() immediately follows the ID table it
> exports, because this is easier to read and verify.  It also makes more
> sense since #ifdef for ACPI or OF could hide both of them.
> 
> Most of the privers already have this correctly placed, so adjust
> the missing ones.  No functional impact.

Nit - drivers

With that fixed .
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>

> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>   drivers/dma/hisi_dma.c | 2 +-
>   drivers/dma/pch_dma.c  | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/hisi_dma.c b/drivers/dma/hisi_dma.c
> index 32a0e95c6a20..28bf818f9aa6 100644
> --- a/drivers/dma/hisi_dma.c
> +++ b/drivers/dma/hisi_dma.c
> @@ -1037,6 +1037,7 @@ static const struct pci_device_id hisi_dma_pci_tbl[] = {
>   	{ PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, 0xa122) },
>   	{ 0, }
>   };
> +MODULE_DEVICE_TABLE(pci, hisi_dma_pci_tbl);
>   
>   static struct pci_driver hisi_dma_pci_driver = {
>   	.name		= "hisi_dma",
> @@ -1050,4 +1051,3 @@ MODULE_AUTHOR("Zhou Wang <wangzhou1@hisilicon.com>");
>   MODULE_AUTHOR("Zhenfa Qiu <qiuzhenfa@hisilicon.com>");
>   MODULE_DESCRIPTION("HiSilicon Kunpeng DMA controller driver");
>   MODULE_LICENSE("GPL v2");
> -MODULE_DEVICE_TABLE(pci, hisi_dma_pci_tbl);
> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> index e9fbfd5a3d51..bf805f1024f6 100644
> --- a/drivers/dma/pch_dma.c
> +++ b/drivers/dma/pch_dma.c
> @@ -970,6 +970,7 @@ static const struct pci_device_id pch_dma_id_table[] = {
>   	{ PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ML7831_DMA2_4CH), 4}, /* SPI */
>   	{ 0, },
>   };
> +MODULE_DEVICE_TABLE(pci, pch_dma_id_table);
>   
>   static SIMPLE_DEV_PM_OPS(pch_dma_pm_ops, pch_dma_suspend, pch_dma_resume);
>   
> @@ -987,4 +988,3 @@ MODULE_DESCRIPTION("Intel EG20T PCH / LAPIS Semicon ML7213/ML7223/ML7831 IOH "
>   		   "DMA controller driver");
>   MODULE_AUTHOR("Yong Wang <yong.y.wang@intel.com>");
>   MODULE_LICENSE("GPL v2");
> -MODULE_DEVICE_TABLE(pci, pch_dma_id_table);
Re: [PATCH] dmaengine: Move MODULE_DEVICE_TABLE next to the table itself
Posted by Frank Li 1 month, 1 week ago 
On Tue, May 05, 2026 at 12:29:33PM +0200, Krzysztof Kozlowski wrote:
> By convention MODULE_DEVICE_TABLE() immediately follows the ID table it
> exports, because this is easier to read and verify.  It also makes more
> sense since #ifdef for ACPI or OF could hide both of them.
>
> Most of the privers already have this correctly placed, so adjust
> the missing ones.  No functional impact.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/hisi_dma.c | 2 +-
>  drivers/dma/pch_dma.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/hisi_dma.c b/drivers/dma/hisi_dma.c
> index 32a0e95c6a20..28bf818f9aa6 100644
> --- a/drivers/dma/hisi_dma.c
> +++ b/drivers/dma/hisi_dma.c
> @@ -1037,6 +1037,7 @@ static const struct pci_device_id hisi_dma_pci_tbl[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, 0xa122) },
>  	{ 0, }
>  };
> +MODULE_DEVICE_TABLE(pci, hisi_dma_pci_tbl);
>
>  static struct pci_driver hisi_dma_pci_driver = {
>  	.name		= "hisi_dma",
> @@ -1050,4 +1051,3 @@ MODULE_AUTHOR("Zhou Wang <wangzhou1@hisilicon.com>");
>  MODULE_AUTHOR("Zhenfa Qiu <qiuzhenfa@hisilicon.com>");
>  MODULE_DESCRIPTION("HiSilicon Kunpeng DMA controller driver");
>  MODULE_LICENSE("GPL v2");
> -MODULE_DEVICE_TABLE(pci, hisi_dma_pci_tbl);
> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> index e9fbfd5a3d51..bf805f1024f6 100644
> --- a/drivers/dma/pch_dma.c
> +++ b/drivers/dma/pch_dma.c
> @@ -970,6 +970,7 @@ static const struct pci_device_id pch_dma_id_table[] = {
>  	{ PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ML7831_DMA2_4CH), 4}, /* SPI */
>  	{ 0, },
>  };
> +MODULE_DEVICE_TABLE(pci, pch_dma_id_table);
>
>  static SIMPLE_DEV_PM_OPS(pch_dma_pm_ops, pch_dma_suspend, pch_dma_resume);
>
> @@ -987,4 +988,3 @@ MODULE_DESCRIPTION("Intel EG20T PCH / LAPIS Semicon ML7213/ML7223/ML7831 IOH "
>  		   "DMA controller driver");
>  MODULE_AUTHOR("Yong Wang <yong.y.wang@intel.com>");
>  MODULE_LICENSE("GPL v2");
> -MODULE_DEVICE_TABLE(pci, pch_dma_id_table);
> --
> 2.51.0
>

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.