[PATCH] RDMA/mlx4: Use secs_to_jiffies() instead of open-coding

Rohit Chavan posted 1 patch 1 month, 1 week ago
drivers/infiniband/hw/mlx4/alias_GUID.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] RDMA/mlx4: Use secs_to_jiffies() instead of open-coding
Posted by Rohit Chavan 1 month, 1 week ago
The conversion from seconds to jiffies is currently performed by
multiplying the value by 1000 and passing it to msecs_to_jiffies().

Use the more direct secs_to_jiffies() helper instead. This simplifies the
code, improves readability, and avoids the manual multiplication step
by using the dedicated kernel API.

Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
---
 drivers/infiniband/hw/mlx4/alias_GUID.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx4/alias_GUID.c b/drivers/infiniband/hw/mlx4/alias_GUID.c
index c6e1b9e4122a..fc23960cf1fd 100644
--- a/drivers/infiniband/hw/mlx4/alias_GUID.c
+++ b/drivers/infiniband/hw/mlx4/alias_GUID.c
@@ -437,7 +437,7 @@ static void aliasguid_query_handler(int status,
 		queue_delayed_work(dev->sriov.alias_guid.ports_guid[port_index].wq,
 				   &dev->sriov.alias_guid.ports_guid[port_index].
 				   alias_guid_work,
-				   msecs_to_jiffies(resched_delay_sec * 1000));
+				   secs_to_jiffies(resched_delay_sec));
 	}
 	if (cb_ctx->sa_query) {
 		list_del(&cb_ctx->list);
-- 
2.34.1
Re: [PATCH] RDMA/mlx4: Use secs_to_jiffies() instead of open-coding
Posted by Leon Romanovsky 1 month ago
On Tue, 05 May 2026 13:23:07 +0530, Rohit Chavan wrote:
> The conversion from seconds to jiffies is currently performed by
> multiplying the value by 1000 and passing it to msecs_to_jiffies().
> 
> Use the more direct secs_to_jiffies() helper instead. This simplifies the
> code, improves readability, and avoids the manual multiplication step
> by using the dedicated kernel API.
> 
> [...]

Applied, thanks!

[1/1] RDMA/mlx4: Use secs_to_jiffies() instead of open-coding
      https://git.kernel.org/rdma/rdma/c/8b2a66cb49546c

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>