[v2] MIPS: alchemy: attach software nodes to GPIO controllers and use properties

[PATCH v2 0/6] MIPS: alchemy: attach software nodes to GPIO controllers and use properties

Posted by Bartosz Golaszewski 1 month, 1 week ago

This series of patches updates board previously converted to use static
device properties/software nodes to attach and use nodes attached to the
respective gpiochip devices rather than simply defining unattached
software nodes with matching name. This is a requirement of newer
gpiolib code. Note that there is currently a workaround preserving the
lookup based on the software node name, but it will be removed soon.

The additional 4 patches convert the remaining 2 boards to use software
nodes as well and fix some build warnings.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Changes in v2:
- Add two patches fixing build warnings with missing prototypes
- Use the new swnode field of struct platform_device_info
- Link to v1: https://patch.msgid.link/20260309-alchemy-v1-0-f55e9dc60ba1@gmail.com

---
Bartosz Golaszewski (2):
      MIPS: alchemy: platform: add missing include
      MIPS: alchemy: provide visible function prototypes to board files

Dmitry Torokhov (4):
      MIPS: alchemy: mtx1: attach software nodes to GPIO chips
      MIPS: alchemy: db1000: use nodes attached to GPIO chips in properties
      MIPS: alchemy: gpr: switch to static device properties
      MIPS: alchemy: db1300: switch to static device properties

 arch/mips/alchemy/board-gpr.c                   | 122 ++++++++------
 arch/mips/alchemy/board-mtx1.c                  |  79 ++++-----
 arch/mips/alchemy/common/gpiolib.c              |  45 ++++-
 arch/mips/alchemy/devboards/db1000.c            |  38 ++---
 arch/mips/alchemy/devboards/db1200.c            |   1 +
 arch/mips/alchemy/devboards/db1300.c            | 210 +++++++++++++++---------
 arch/mips/alchemy/devboards/db1550.c            |   2 +
 arch/mips/alchemy/devboards/db1xxx.c            |  11 +-
 arch/mips/alchemy/devboards/db1xxx.h            |  18 ++
 arch/mips/alchemy/devboards/platform.c          |   2 +
 arch/mips/include/asm/mach-au1x00/gpio-au1000.h |   5 +
 arch/mips/include/asm/mach-au1x00/gpio-au1300.h |   3 +
 12 files changed, 329 insertions(+), 207 deletions(-)
---
base-commit: 7fd2df204f342fc17d1a0bfcd474b24232fb0f32
change-id: 20260505-gpio-swnode-alchemy-3bff9c11e54c

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Re: [PATCH v2 0/6] MIPS: alchemy: attach software nodes to GPIO controllers and use properties

Posted by Manuel Lauss 1 month, 1 week ago

Hello Bartosz,

On Tue, May 5, 2026 at 11:09 AM Bartosz Golaszewski
<bartosz.golaszewski@oss.qualcomm.com> wrote:
>
> This series of patches updates board previously converted to use static
> device properties/software nodes to attach and use nodes attached to the
> respective gpiochip devices rather than simply defining unattached
> software nodes with matching name. This is a requirement of newer
> gpiolib code. Note that there is currently a workaround preserving the
> lookup based on the software node name, but it will be removed soon.
>
> The additional 4 patches convert the remaining 2 boards to use software
> nodes as well and fix some build warnings.

I have run-tested this on the DB1300, without any issues.
Tested-by: Manuel Lauss <manuel.lauss@gmail.com>

Thanks a lot!
      Manuel

Re: [PATCH v2 0/6] MIPS: alchemy: attach software nodes to GPIO controllers and use properties

Posted by Bartosz Golaszewski 3 weeks, 4 days ago

On Tue, May 5, 2026 at 3:31 PM Manuel Lauss <manuel.lauss@gmail.com> wrote:
>
> Hello Bartosz,
>
> On Tue, May 5, 2026 at 11:09 AM Bartosz Golaszewski
> <bartosz.golaszewski@oss.qualcomm.com> wrote:
> >
> > This series of patches updates board previously converted to use static
> > device properties/software nodes to attach and use nodes attached to the
> > respective gpiochip devices rather than simply defining unattached
> > software nodes with matching name. This is a requirement of newer
> > gpiolib code. Note that there is currently a workaround preserving the
> > lookup based on the software node name, but it will be removed soon.
> >
> > The additional 4 patches convert the remaining 2 boards to use software
> > nodes as well and fix some build warnings.
>
> I have run-tested this on the DB1300, without any issues.
> Tested-by: Manuel Lauss <manuel.lauss@gmail.com>
>
> Thanks a lot!
>       Manuel

Hi Thomas!

Can you please queue these for v7.2?

Thanks,
Bartosz

Re: [PATCH v2 0/6] MIPS: alchemy: attach software nodes to GPIO controllers and use properties

Posted by Thomas Bogendoerfer 3 weeks, 4 days ago

On Tue, May 19, 2026 at 01:52:16PM +0200, Bartosz Golaszewski wrote:
> On Tue, May 5, 2026 at 3:31 PM Manuel Lauss <manuel.lauss@gmail.com> wrote:
> >
> > Hello Bartosz,
> >
> > On Tue, May 5, 2026 at 11:09 AM Bartosz Golaszewski
> > <bartosz.golaszewski@oss.qualcomm.com> wrote:
> > >
> > > This series of patches updates board previously converted to use static
> > > device properties/software nodes to attach and use nodes attached to the
> > > respective gpiochip devices rather than simply defining unattached
> > > software nodes with matching name. This is a requirement of newer
> > > gpiolib code. Note that there is currently a workaround preserving the
> > > lookup based on the software node name, but it will be removed soon.
> > >
> > > The additional 4 patches convert the remaining 2 boards to use software
> > > nodes as well and fix some build warnings.
> >
> > I have run-tested this on the DB1300, without any issues.
> > Tested-by: Manuel Lauss <manuel.lauss@gmail.com>
> >
> > Thanks a lot!
> >       Manuel
> 
> Hi Thomas!
> 
> Can you please queue these for v7.2?

sure, will do.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH v2 0/6] MIPS: alchemy: attach software nodes to GPIO controllers and use properties

Posted by Bartosz Golaszewski 3 weeks, 3 days ago

On Tue, May 19, 2026 at 11:15 PM Thomas Bogendoerfer
<tsbogend@alpha.franken.de> wrote:
>
> On Tue, May 19, 2026 at 01:52:16PM +0200, Bartosz Golaszewski wrote:
> > On Tue, May 5, 2026 at 3:31 PM Manuel Lauss <manuel.lauss@gmail.com> wrote:
> > >
> > > Hello Bartosz,
> > >
> > > On Tue, May 5, 2026 at 11:09 AM Bartosz Golaszewski
> > > <bartosz.golaszewski@oss.qualcomm.com> wrote:
> > > >
> > > > This series of patches updates board previously converted to use static
> > > > device properties/software nodes to attach and use nodes attached to the
> > > > respective gpiochip devices rather than simply defining unattached
> > > > software nodes with matching name. This is a requirement of newer
> > > > gpiolib code. Note that there is currently a workaround preserving the
> > > > lookup based on the software node name, but it will be removed soon.
> > > >
> > > > The additional 4 patches convert the remaining 2 boards to use software
> > > > nodes as well and fix some build warnings.
> > >
> > > I have run-tested this on the DB1300, without any issues.
> > > Tested-by: Manuel Lauss <manuel.lauss@gmail.com>
> > >
> > > Thanks a lot!
> > >       Manuel
> >
> > Hi Thomas!
> >
> > Can you please queue these for v7.2?
>
> sure, will do.
>

While at it, can you also queue these?

https://lore.kernel.org/all/20260430-mips-rb532-gpio-v1-1-845a0c6206a5@oss.qualcomm.com/
https://lore.kernel.org/all/20260430112410.65986-1-bartosz.golaszewski@oss.qualcomm.com/

Thanks
Bartosz

Re: [PATCH v2 0/6] MIPS: alchemy: attach software nodes to GPIO controllers and use properties

Posted by Thomas Bogendoerfer 2 weeks, 4 days ago

On Wed, May 20, 2026 at 09:07:11AM +0200, Bartosz Golaszewski wrote:
> On Tue, May 19, 2026 at 11:15 PM Thomas Bogendoerfer
> <tsbogend@alpha.franken.de> wrote:
> >
> > On Tue, May 19, 2026 at 01:52:16PM +0200, Bartosz Golaszewski wrote:
> > > On Tue, May 5, 2026 at 3:31 PM Manuel Lauss <manuel.lauss@gmail.com> wrote:
> > > >
> > > > Hello Bartosz,
> > > >
> > > > On Tue, May 5, 2026 at 11:09 AM Bartosz Golaszewski
> > > > <bartosz.golaszewski@oss.qualcomm.com> wrote:
> > > > >
> > > > > This series of patches updates board previously converted to use static
> > > > > device properties/software nodes to attach and use nodes attached to the
> > > > > respective gpiochip devices rather than simply defining unattached
> > > > > software nodes with matching name. This is a requirement of newer
> > > > > gpiolib code. Note that there is currently a workaround preserving the
> > > > > lookup based on the software node name, but it will be removed soon.
> > > > >
> > > > > The additional 4 patches convert the remaining 2 boards to use software
> > > > > nodes as well and fix some build warnings.
> > > >
> > > > I have run-tested this on the DB1300, without any issues.
> > > > Tested-by: Manuel Lauss <manuel.lauss@gmail.com>
> > > >
> > > > Thanks a lot!
> > > >       Manuel
> > >
> > > Hi Thomas!
> > >
> > > Can you please queue these for v7.2?
> >
> > sure, will do.
> >
> 
> While at it, can you also queue these?
> 
> https://lore.kernel.org/all/20260430-mips-rb532-gpio-v1-1-845a0c6206a5@oss.qualcomm.com/
> https://lore.kernel.org/all/20260430112410.65986-1-bartosz.golaszewski@oss.qualcomm.com/

I've them now in my mips-next tree, but the alchmey series doesn't build
with gcc 10.2.1:

/local/tbogendoerfer/korg/linux/arch/mips/alchemy/board-mtx1.c:88:47: error: initializer element is not constant
   88 |  .properties = (const struct property_entry[]){
      |                                               ^

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]