[v2] Add USB Phy driver and binding changes for Qualcomm Shikra SoC

[PATCH v2 0/4] Add USB Phy driver and binding changes for Qualcomm Shikra SoC

Posted by Krishna Kurapati 1 month, 1 week ago

This series adds Driver and binding changes for USB Phys on Shikra. There
are two USB controllers - One of them is SS capable and other is highspeed
only capable. The ss Phy init sequence is same as that of Talos.

Changes in v2:
- Separated the usb controller binding changes
- Updated commit texts.

Krishna Kurapati (4):
  dt-bindings: phy: qcom,qusb2: Document QUSB2 Phy for Shikra
  dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for Shikra
  phy: qcom-qusb2: Add support for Shikra
  phy: qcom: qmp-usbc: Add qmp configuration for Shikra

 .../bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml  |  2 ++
 .../devicetree/bindings/phy/qcom,qusb2-phy.yaml  |  1 +
 drivers/phy/qualcomm/phy-qcom-qmp-usbc.c         |  3 +++
 drivers/phy/qualcomm/phy-qcom-qusb2.c            | 16 ++++++++++++++++
 4 files changed, 22 insertions(+)

-- 
2.34.1

Re: [PATCH v2 0/4] Add USB Phy driver and binding changes for Qualcomm Shikra SoC

Posted by Vinod Koul 1 month ago

On 04-05-26, 22:36, Krishna Kurapati wrote:
> This series adds Driver and binding changes for USB Phys on Shikra. There
> are two USB controllers - One of them is SS capable and other is highspeed
> only capable. The ss Phy init sequence is same as that of Talos.

Please check https://sashiko.dev/#/patchset/20260504170659.282532-1-krishna.kurapati%40oss.qualcomm.com

> 
> Changes in v2:
> - Separated the usb controller binding changes
> - Updated commit texts.
> 
> Krishna Kurapati (4):
>   dt-bindings: phy: qcom,qusb2: Document QUSB2 Phy for Shikra
>   dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for Shikra
>   phy: qcom-qusb2: Add support for Shikra
>   phy: qcom: qmp-usbc: Add qmp configuration for Shikra
> 
>  .../bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml  |  2 ++
>  .../devicetree/bindings/phy/qcom,qusb2-phy.yaml  |  1 +
>  drivers/phy/qualcomm/phy-qcom-qmp-usbc.c         |  3 +++
>  drivers/phy/qualcomm/phy-qcom-qusb2.c            | 16 ++++++++++++++++
>  4 files changed, 22 insertions(+)
> 
> -- 
> 2.34.1

-- 
~Vinod

Re: [PATCH v2 0/4] Add USB Phy driver and binding changes for Qualcomm Shikra SoC

Posted by Krishna Kurapati 1 month ago


On 5/10/2026 2:59 PM, Vinod Koul wrote:
> On 04-05-26, 22:36, Krishna Kurapati wrote:
>> This series adds Driver and binding changes for USB Phys on Shikra. There
>> are two USB controllers - One of them is SS capable and other is highspeed
>> only capable. The ss Phy init sequence is same as that of Talos.
> 
> Please check https://sashiko.dev/#/patchset/20260504170659.282532-1-krishna.kurapati%40oss.qualcomm.com
> 

Thanks for the report Vinod.

Will do the following:

1. On hs phy driver patch, will update commit text to mention that 
register init sequence of Shikra is same as that of Talos and hence the 
qcs615 init tbl is being reused.

2. On the super speed phy driver patch, I repsonded to Krzysztof 
comments as to why fallback copatible can't be used. Will update commit 
text appropriately once comments are all resolved.

[1]: 
https://lore.kernel.org/all/d52c5039-9431-44ed-9f3b-bb00d03ae176@oss.qualcomm.com/

Regards,
Krishna,

>>
>> Changes in v2:
>> - Separated the usb controller binding changes
>> - Updated commit texts.
>>
>> Krishna Kurapati (4):
>>    dt-bindings: phy: qcom,qusb2: Document QUSB2 Phy for Shikra
>>    dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for Shikra
>>    phy: qcom-qusb2: Add support for Shikra
>>    phy: qcom: qmp-usbc: Add qmp configuration for Shikra
>>
>>   .../bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml  |  2 ++
>>   .../devicetree/bindings/phy/qcom,qusb2-phy.yaml  |  1 +
>>   drivers/phy/qualcomm/phy-qcom-qmp-usbc.c         |  3 +++
>>   drivers/phy/qualcomm/phy-qcom-qusb2.c            | 16 ++++++++++++++++
>>   4 files changed, 22 insertions(+)
>>
>> -- 
>> 2.34.1
>