[resend PATCH v2 0/1] wifi: libertas: fix bug in Marvell Libertas driver

Jakov Novak posted 1 patch 1 month, 1 week ago
drivers/net/wireless/marvell/libertas/if_usb.c | 1 +
1 file changed, 1 insertion(+)
[resend PATCH v2 0/1] wifi: libertas: fix bug in Marvell Libertas driver
Posted by Jakov Novak 1 month, 1 week ago
This is the same patch with the suggested tag and message fixes.

Jakov Novak (1):
  wifi: libertas: add wake_up() call to properly notify

 drivers/net/wireless/marvell/libertas/if_usb.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.54.0
Re: [resend PATCH v2 0/1] wifi: libertas: fix bug in Marvell Libertas driver
Posted by Jeff Johnson 1 month, 1 week ago
On 5/4/2026 8:04 AM, Jakov Novak wrote:
> This is the same patch with the suggested tag and message fixes.
> 
> Jakov Novak (1):
>   wifi: libertas: add wake_up() call to properly notify
> 
>  drivers/net/wireless/marvell/libertas/if_usb.c | 1 +
>  1 file changed, 1 insertion(+)
> 

1) A single patch doesn't need a cover letter
2) new versions of a patch should be a separate thread. Don't make new
versions "In-reply-to" the previous version.
3) Ingo Molnar once suggested a good template to follow for many
changes:https://lore.kernel.org/all/20131111113218.GF15810@gmail.com/
Over time I found this advice helpful, although not that exact template,
especially given that using "we" is now strongly discouraged.

I suggest something more like:
Currently, when <scenario>, <code reference> does <action>.
This has a <problem description>.
To address this issue, <imperative action to fix the code>.
<Any other comments which support this action such as describing how it fixes
the problem, how we know there are no side-effects (or known side-effects or
limitations)>
Re: [resend PATCH v2 0/1] wifi: libertas: fix bug in Marvell Libertas driver
Posted by Johannes Berg 1 month, 1 week ago
On Mon, 2026-05-04 at 17:04 +0200, Jakov Novak wrote:
> This is the same patch with the suggested tag and message fixes.
> 

That makes it not a resend but a v3 I guess ...

johannes