[PATCH V1] dt-bindings: mmc: sdhci-msm: Document the Shikra compatible

Monish Chunara posted 1 patch 1 month, 1 week ago
There is a newer version of this series
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
1 file changed, 1 insertion(+)
[PATCH V1] dt-bindings: mmc: sdhci-msm: Document the Shikra compatible
Posted by Monish Chunara 1 month, 1 week ago
Add the MSM SDHCI compatible name to support both eMMC and SD card for
Shikra, which uses 'shikra' as the fallback SoC.

The SDHCI controller on Shikra is based on MSM SDHCI v5 IP. Hence,
document the compatible with "qcom,sdhci-msm-v5" as the fallback.

Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 695a95e8f35d..60dc6b0caa21 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -62,6 +62,7 @@ properties:
               - qcom,sdx55-sdhci
               - qcom,sdx65-sdhci
               - qcom,sdx75-sdhci
+              - qcom,shikra-sdhci
               - qcom,sm6115-sdhci
               - qcom,sm6125-sdhci
               - qcom,sm6350-sdhci
-- 
2.34.1
Re: [PATCH V1] dt-bindings: mmc: sdhci-msm: Document the Shikra compatible
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On Mon, May 04, 2026 at 12:43:34PM +0530, Monish Chunara wrote:
> Add the MSM SDHCI compatible name to support both eMMC and SD card for
> Shikra, which uses 'shikra' as the fallback SoC.

How shikra can use shikra fallback?

> 
> The SDHCI controller on Shikra is based on MSM SDHCI v5 IP. Hence,
> document the compatible with "qcom,sdhci-msm-v5" as the fallback.

And here you repeat or state something contradictory. So shikra or
sdhci-msm-v5?

This should be just one paragraph where you state the device and its
compatibility with any other devices or interfaces.

Best regards,
Krzysztof
Re: [PATCH V1] dt-bindings: mmc: sdhci-msm: Document the Shikra compatible
Posted by Monish Chunara 1 month ago
On Wed, May 06, 2026 at 10:23:07AM +0200, Krzysztof Kozlowski wrote:
> On Mon, May 04, 2026 at 12:43:34PM +0530, Monish Chunara wrote:
> > Add the MSM SDHCI compatible name to support both eMMC and SD card for
> > Shikra, which uses 'shikra' as the fallback SoC.
> 
> How shikra can use shikra fallback?
> 
> > 
> > The SDHCI controller on Shikra is based on MSM SDHCI v5 IP. Hence,
> > document the compatible with "qcom,sdhci-msm-v5" as the fallback.
> 
> And here you repeat or state something contradictory. So shikra or
> sdhci-msm-v5?
> 
> This should be just one paragraph where you state the device and its
> compatibility with any other devices or interfaces.

Will update commit text in next series with better clarity on the change.

> 
> Best regards,
> Krzysztof
>