[PATCH v2] staging: rtl8723bs: remove unnecessary braces in sdio_intf.c

Francisco Maestre posted 1 patch 1 month, 1 week ago
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH v2] staging: rtl8723bs: remove unnecessary braces in sdio_intf.c
Posted by Francisco Maestre 1 month, 1 week ago
Remove braces around a single-statement block in the SDIO
disconnect path, as per kernel coding style guidelines.

This fixes the following checkpatch.pl warning:
  WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Francisco Maestre <francisco@maestretorreblanca.com>
---
v2: Resend as individual patch, not part of an unrelated series.
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index d664e254912c..a86252ccac76 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
 		sdio_claim_host(func);
 		sdio_disable_func(func);
 
-		if (dvobj->irq_alloc) {
+		if (dvobj->irq_alloc)
 			sdio_release_irq(func);
-		}
 
 		sdio_release_host(func);
 	}
-- 
2.50.1 (Apple Git-155)
Re: [PATCH v2] staging: rtl8723bs: remove unnecessary braces in sdio_intf.c
Posted by Greg KH 1 month, 1 week ago
On Sat, May 02, 2026 at 07:57:54PM -0500, Francisco Maestre wrote:
> Remove braces around a single-statement block in the SDIO
> disconnect path, as per kernel coding style guidelines.
> 
> This fixes the following checkpatch.pl warning:
>   WARNING: braces {} are not necessary for single statement blocks
> 
> Signed-off-by: Francisco Maestre <francisco@maestretorreblanca.com>
> ---
> v2: Resend as individual patch, not part of an unrelated series.
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index d664e254912c..a86252ccac76 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
>  		sdio_claim_host(func);
>  		sdio_disable_func(func);
>  
> -		if (dvobj->irq_alloc) {
> +		if (dvobj->irq_alloc)
>  			sdio_release_irq(func);
> -		}
>  
>  		sdio_release_host(func);
>  	}
> -- 
> 2.50.1 (Apple Git-155)
> 
> 

Does not apply to my tree :(