drm/i915: replace select with dependency for visible DEBUG_OBJECTS

[PATCH] drm/i915: replace select with dependency for visible DEBUG_OBJECTS

Posted by Julian Braha 1 month, 1 week ago

DRM_I915_SW_FENCE_DEBUG_OBJECTS currently selects DEBUG_OBJECTS even though
DEBUG_OBJECTS is visible to users. Other config options use 'depends on'
for DEBUG_OBJECTS, so let's do the same here.

This select-visible Kconfig misusage was detected by Kconfirm, a static
analysis tool for Kconfig.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/gpu/drm/i915/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
index 52a3a59b4ba2..028a2c97361d 100644
--- a/drivers/gpu/drm/i915/Kconfig.debug
+++ b/drivers/gpu/drm/i915/Kconfig.debug
@@ -153,7 +153,7 @@ config DRM_I915_TRACE_GTT
 config DRM_I915_SW_FENCE_DEBUG_OBJECTS
 	bool "Enable additional driver debugging for fence objects"
 	depends on DRM_I915
-	select DEBUG_OBJECTS
+	depends on DEBUG_OBJECTS
 	default n
 	help
 	  Choose this option to turn on extra driver debugging that may affect
-- 
2.53.0

Re: [PATCH] drm/i915: replace select with dependency for visible DEBUG_OBJECTS

Posted by Jani Nikula 1 month, 1 week ago

On Sat, 02 May 2026, Julian Braha <julianbraha@gmail.com> wrote:
> DRM_I915_SW_FENCE_DEBUG_OBJECTS currently selects DEBUG_OBJECTS even though
> DEBUG_OBJECTS is visible to users. Other config options use 'depends on'
> for DEBUG_OBJECTS, so let's do the same here.
>
> This select-visible Kconfig misusage was detected by Kconfirm, a static
> analysis tool for Kconfig.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>

Thanks for the patch, pushed to drm-intel-next.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/Kconfig.debug | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> index 52a3a59b4ba2..028a2c97361d 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -153,7 +153,7 @@ config DRM_I915_TRACE_GTT
>  config DRM_I915_SW_FENCE_DEBUG_OBJECTS
>  	bool "Enable additional driver debugging for fence objects"
>  	depends on DRM_I915
> -	select DEBUG_OBJECTS
> +	depends on DEBUG_OBJECTS
>  	default n
>  	help
>  	  Choose this option to turn on extra driver debugging that may affect

-- 
Jani Nikula, Intel