1. Patchew
  2. linux
  3. View series

[PATCH] staging: atomisp: isp: xnr 3.0 fix whitespace issue

Shirin Kaul posted 1 patch 1 month, 1 week ago
There is a newer version of this series
.../kernels/xnr/xnr_3.0/ia_css_xnr3.host.c    | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
[PATCH] staging: atomisp: isp: xnr 3.0 fix whitespace issue
Posted by Shirin Kaul 1 month, 1 week ago 
Fix spaces by replacing them with tabs in function calls to comply
with kernel coding style.

Signed-off-by: Shirin Kaul <shirin.kaul11@gmail.com>
---
 .../kernels/xnr/xnr_3.0/ia_css_xnr3.host.c    | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c
index e90dea58215b..3da73001d645 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c
@@ -34,8 +34,8 @@ static const s16 x[XNR3_LOOK_UP_TABLE_POINTS] = {
 
 static const s16 a[XNR3_LOOK_UP_TABLE_POINTS] = {
 	-7213, -5580, -4371, -3421, -2722, -2159, -6950, -5585,
-	    -4529, -3697, -3010, -2485, -2070, -1727, -1428, 0
-    };
+	-4529, -3697, -3010, -2485, -2070, -1727, -1428, 0
+	};
 
 static const s16 b[XNR3_LOOK_UP_TABLE_POINTS] = {
 	4096, 3603, 3178, 2811, 2497, 2226, 1990, 1783,
@@ -125,9 +125,9 @@ compute_blending(int strength)
 
 void
 ia_css_xnr3_encode(
-    struct sh_css_isp_xnr3_params *to,
-    const struct ia_css_xnr3_config *from,
-    unsigned int size)
+	struct sh_css_isp_xnr3_params *to,
+	const struct ia_css_xnr3_config *from,
+	unsigned int size)
 {
 	int kernel_size = XNR_FILTER_SIZE;
 	int adjust_factor = roundup_pow_of_two(kernel_size);
@@ -180,9 +180,9 @@ ia_css_xnr3_encode(
 */
 void
 ia_css_xnr3_vmem_encode(
-    struct sh_css_isp_xnr3_vmem_params *to,
-    const struct ia_css_xnr3_config *from,
-    unsigned int size)
+	struct sh_css_isp_xnr3_vmem_params *to,
+	const struct ia_css_xnr3_config *from,
+	unsigned int size)
 {
 	unsigned int i, j, base;
 	const unsigned int total_blocks = 4;
@@ -232,8 +232,8 @@ ia_css_xnr3_vmem_encode(
 /* Dummy Function added as the tool expects it*/
 void
 ia_css_xnr3_debug_dtrace(
-    const struct ia_css_xnr3_config *config,
-    unsigned int level)
+	const struct ia_css_xnr3_config *config,
+	unsigned int level)
 {
 	(void)config;
 	(void)level;
-- 
2.43.0
Re: [PATCH] staging: atomisp: isp: xnr 3.0 fix whitespace issue
Posted by Andy Shevchenko 1 month, 1 week ago 
On Sat, May 02, 2026 at 08:25:16AM +0000, Shirin Kaul wrote:
> Fix spaces by replacing them with tabs in function calls to comply
> with kernel coding style.

...

>  static const s16 a[XNR3_LOOK_UP_TABLE_POINTS] = {
>  	-7213, -5580, -4371, -3421, -2722, -2159, -6950, -5585,
> -	    -4529, -3697, -3010, -2485, -2070, -1727, -1428, 0
> -    };
> +	-4529, -3697, -3010, -2485, -2070, -1727, -1428, 0

Leave trailing comma, as it's not a sign that this array has a terminator.

> +	};

Wrong indentation.

...

>  void
>  ia_css_xnr3_encode(
> -    struct sh_css_isp_xnr3_params *to,
> -    const struct ia_css_xnr3_config *from,
> -    unsigned int size)
> +	struct sh_css_isp_xnr3_params *to,
> +	const struct ia_css_xnr3_config *from,
> +	unsigned int size)

It's half-baked solution. Moreover there were handful of patches (better than
this one) to address the same, please, study preexisting work (linux-media
mailing list archives is for your help).

-- 
With Best Regards,
Andy Shevchenko
[PATCH v2] staging: atomisp: isp: xnr 3.0 fix whitespace issue
Posted by Shirin Kaul 1 month, 1 week ago 
Fix spaces by replacing them with tabs in function calls to comply
with kernel coding style with checkpatch.pl.

v2:
- Added trailing commas in arrays
- Fixed indentation
Signed-off-by: Shirin Kaul <shirin.kaul11@gmail.com>
---
 .../kernels/xnr/xnr_3.0/ia_css_xnr3.host.c    | 29 +++++++++----------
 1 file changed, 13 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c
index e90dea58215b..a3ee8827c44d 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c
@@ -29,21 +29,21 @@
 
 static const s16 x[XNR3_LOOK_UP_TABLE_POINTS] = {
 	1024, 1164, 1320, 1492, 1680, 1884, 2108, 2352,
-	2616, 2900, 3208, 3540, 3896, 4276, 4684, 5120
+	2616, 2900, 3208, 3540, 3896, 4276, 4684, 5120,
 };
 
 static const s16 a[XNR3_LOOK_UP_TABLE_POINTS] = {
 	-7213, -5580, -4371, -3421, -2722, -2159, -6950, -5585,
-	    -4529, -3697, -3010, -2485, -2070, -1727, -1428, 0
-    };
+	-4529, -3697, -3010, -2485, -2070, -1727, -1428, 0,
+};
 
 static const s16 b[XNR3_LOOK_UP_TABLE_POINTS] = {
 	4096, 3603, 3178, 2811, 2497, 2226, 1990, 1783,
-	1603, 1446, 1307, 1185, 1077, 981, 895, 819
+	1603, 1446, 1307, 1185, 1077, 981, 895, 819,
 };
 
 static const s16 c[XNR3_LOOK_UP_TABLE_POINTS] = {
-	1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
+	1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
 };
 
 /*
@@ -124,10 +124,9 @@ compute_blending(int strength)
 }
 
 void
-ia_css_xnr3_encode(
-    struct sh_css_isp_xnr3_params *to,
-    const struct ia_css_xnr3_config *from,
-    unsigned int size)
+ia_css_xnr3_encode(struct sh_css_isp_xnr3_params *to,
+		   const struct ia_css_xnr3_config *from,
+		   unsigned int size)
 {
 	int kernel_size = XNR_FILTER_SIZE;
 	int adjust_factor = roundup_pow_of_two(kernel_size);
@@ -179,10 +178,9 @@ ia_css_xnr3_encode(
  * VMEM Encode Function to translate UV parameters from userspace into ISP space
 */
 void
-ia_css_xnr3_vmem_encode(
-    struct sh_css_isp_xnr3_vmem_params *to,
-    const struct ia_css_xnr3_config *from,
-    unsigned int size)
+ia_css_xnr3_vmem_encode(struct sh_css_isp_xnr3_vmem_params *to,
+			const struct ia_css_xnr3_config *from,
+			unsigned int size)
 {
 	unsigned int i, j, base;
 	const unsigned int total_blocks = 4;
@@ -231,9 +229,8 @@ ia_css_xnr3_vmem_encode(
 
 /* Dummy Function added as the tool expects it*/
 void
-ia_css_xnr3_debug_dtrace(
-    const struct ia_css_xnr3_config *config,
-    unsigned int level)
+ia_css_xnr3_debug_dtrace(const struct ia_css_xnr3_config *config,
+			 unsigned int level)
 {
 	(void)config;
 	(void)level;
-- 
2.43.0
Re: [PATCH v2] staging: atomisp: isp: xnr 3.0 fix whitespace issue
Posted by Andy Shevchenko 1 month, 1 week ago 
On Sun, May 03, 2026 at 10:54:45AM +0000, Shirin Kaul wrote:
> Fix spaces by replacing them with tabs in function calls to comply
> with kernel coding style with checkpatch.pl.

Subject is wrong. The patch doesn't cover things outside the single file.
The patch does two things (has to be split). Also patch doesn't anyhow
rely on the preexisted changes that were submitted to the mailing list
(that cover much more that this one).

> v2:
> - Added trailing commas in arrays
> - Fixed indentation

We have special place for the changelog and comments...

> Signed-off-by: Shirin Kaul <shirin.kaul11@gmail.com>
> ---

...somewhere here.

>  .../kernels/xnr/xnr_3.0/ia_css_xnr3.host.c    | 29 +++++++++----------
>  1 file changed, 13 insertions(+), 16 deletions(-)

-- 
With Best Regards,
Andy Shevchenko

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.