mm/oom_kill: Insert newline for better readability

[PATCH] mm/oom_kill: Insert newline for better readability

Posted by Nyunwoo Kim 1 month, 2 weeks ago

Insert a newline in check_panic_on_oom() for better readability.

Signed-off-by: Nyunwoo Kim <knw0507@naver.com>
---
This is my first patch and I am using it as practice to learn kernel
development. If this has wasted your time, I apologize; it was unintentional.
Thank you for your consideration.

 mm/oom_kill.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 5c6c95c169ee..86a08deaa697 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -1076,6 +1076,7 @@ static void check_panic_on_oom(struct oom_control *oc)
 {
 	if (likely(!sysctl_panic_on_oom))
 		return;
+
 	if (sysctl_panic_on_oom != 2) {
 		/*
 		 * panic_on_oom == 1 only affects CONSTRAINT_NONE, the kernel
@@ -1085,9 +1086,11 @@ static void check_panic_on_oom(struct oom_control *oc)
 		if (oc->constraint != CONSTRAINT_NONE)
 			return;
 	}
+
 	/* Do not panic for oom kills triggered by sysrq */
 	if (is_sysrq_oom(oc))
 		return;
+
 	dump_header(oc);
 	panic("Out of memory: %s panic_on_oom is enabled\n",
 		sysctl_panic_on_oom == 2 ? "compulsory" : "system-wide");
-- 
2.25.1

Re: [PATCH] mm/oom_kill: Insert newline for better readability

Posted by Michal Hocko 1 month, 2 weeks ago

On Thu 30-04-26 21:53:21, Nyunwoo Kim wrote:
> Insert a newline in check_panic_on_oom() for better readability.
> 
> Signed-off-by: Nyunwoo Kim <knw0507@naver.com>
> ---
> This is my first patch and I am using it as practice to learn kernel
> development. If this has wasted your time, I apologize; it was unintentional.
> Thank you for your consideration.

Patches like this are not adding any real value. While aiming for a
better readable code is a nobel goal I would recommend adding clean ups
like this one to other changes/patches that are improving the code
(either fixing existing bugs or making the overall code much better).

Thanks for trying and keep looking for something that might improve the
code.

> 
>  mm/oom_kill.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 5c6c95c169ee..86a08deaa697 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -1076,6 +1076,7 @@ static void check_panic_on_oom(struct oom_control *oc)
>  {
>  	if (likely(!sysctl_panic_on_oom))
>  		return;
> +
>  	if (sysctl_panic_on_oom != 2) {
>  		/*
>  		 * panic_on_oom == 1 only affects CONSTRAINT_NONE, the kernel
> @@ -1085,9 +1086,11 @@ static void check_panic_on_oom(struct oom_control *oc)
>  		if (oc->constraint != CONSTRAINT_NONE)
>  			return;
>  	}
> +
>  	/* Do not panic for oom kills triggered by sysrq */
>  	if (is_sysrq_oom(oc))
>  		return;
> +
>  	dump_header(oc);
>  	panic("Out of memory: %s panic_on_oom is enabled\n",
>  		sysctl_panic_on_oom == 2 ? "compulsory" : "system-wide");
> -- 
> 2.25.1

-- 
Michal Hocko
SUSE Labs