snic/vnic_dev: Remove dead store in vnic_dev_discover_res()

[PATCH] snic/vnic_dev: Remove dead store in vnic_dev_discover_res()

Posted by Evgenii Burenchev 1 month, 2 weeks ago

The assignment 'len = count' for RES_TYPE_INTR_PBA_LEGACY,
RES_TYPE_DEVCMD, and RES_TYPE_DEVCMD2 cases is never used.

Drop the unused assignments to fix the following static analyzer warning.

No functional change.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Evgenii Burenchev <evg28bur@yandex.ru>
---
 drivers/scsi/snic/vnic_dev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/snic/vnic_dev.c b/drivers/scsi/snic/vnic_dev.c
index ed7771e62854..22303f827583 100644
--- a/drivers/scsi/snic/vnic_dev.c
+++ b/drivers/scsi/snic/vnic_dev.c
@@ -132,7 +132,6 @@ static int vnic_dev_discover_res(struct vnic_dev *vdev,
 		case RES_TYPE_INTR_PBA_LEGACY:
 		case RES_TYPE_DEVCMD:
 		case RES_TYPE_DEVCMD2:
-			len = count;
 			break;
 
 		default:
-- 
2.43.0

Re: [PATCH] snic/vnic_dev: Remove dead store in vnic_dev_discover_res()

Posted by Martin K. Petersen 3 weeks, 3 days ago

On Wed, 29 Apr 2026 12:52:12 +0300, Evgenii Burenchev wrote:

> The assignment 'len = count' for RES_TYPE_INTR_PBA_LEGACY,
> RES_TYPE_DEVCMD, and RES_TYPE_DEVCMD2 cases is never used.
> 
> Drop the unused assignments to fix the following static analyzer warning.
> 
> No functional change.
> 
> [...]

Applied to 7.2/scsi-queue, thanks!

[1/1] snic/vnic_dev: Remove dead store in vnic_dev_discover_res()
      https://git.kernel.org/mkp/scsi/c/195254adeddc

-- 
Martin K. Petersen