most: replace snprintf("%s") with strscpy in audio_probe_channel

[PATCH] most: replace snprintf("%s") with strscpy in audio_probe_channel

Posted by Thorsten Blum 1 month, 2 weeks ago

Replace snprintf("%s") with the faster and more direct strscpy().

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/most/most_snd.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/most/most_snd.c b/drivers/most/most_snd.c
index 68b9e6c64033..dc366813c31e 100644
--- a/drivers/most/most_snd.c
+++ b/drivers/most/most_snd.c
@@ -16,6 +16,7 @@
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
 #include <linux/sched.h>
+#include <linux/string.h>
 #include <linux/kthread.h>
 #include <linux/most.h>
 
@@ -554,10 +555,8 @@ static int audio_probe_channel(struct most_interface *iface, int channel_id,
 			   sizeof(*channel), &adpt->card);
 	if (ret < 0)
 		goto err_free_adpt;
-	snprintf(adpt->card->driver, sizeof(adpt->card->driver),
-		 "%s", DRIVER_NAME);
-	snprintf(adpt->card->shortname, sizeof(adpt->card->shortname),
-		 "Microchip INIC");
+	strscpy(adpt->card->driver, DRIVER_NAME);
+	strscpy(adpt->card->shortname, "Microchip INIC");
 	snprintf(adpt->card->longname, sizeof(adpt->card->longname),
 		 "%s at %s", adpt->card->shortname, iface->description);
 skip_adpt_alloc:

Re: [PATCH] most: replace snprintf("%s") with strscpy in audio_probe_channel

Posted by Thorsten Blum 1 week, 5 days ago

Gentle ping?

On Wed, Apr 29, 2026 at 02:08:59AM +0200, Thorsten Blum wrote:
> Replace snprintf("%s") with the faster and more direct strscpy().
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  drivers/most/most_snd.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/most/most_snd.c b/drivers/most/most_snd.c
> index 68b9e6c64033..dc366813c31e 100644
> --- a/drivers/most/most_snd.c
> +++ b/drivers/most/most_snd.c
> @@ -16,6 +16,7 @@
>  #include <sound/pcm.h>
>  #include <sound/pcm_params.h>
>  #include <linux/sched.h>
> +#include <linux/string.h>
>  #include <linux/kthread.h>
>  #include <linux/most.h>
>  
> @@ -554,10 +555,8 @@ static int audio_probe_channel(struct most_interface *iface, int channel_id,
>  			   sizeof(*channel), &adpt->card);
>  	if (ret < 0)
>  		goto err_free_adpt;
> -	snprintf(adpt->card->driver, sizeof(adpt->card->driver),
> -		 "%s", DRIVER_NAME);
> -	snprintf(adpt->card->shortname, sizeof(adpt->card->shortname),
> -		 "Microchip INIC");
> +	strscpy(adpt->card->driver, DRIVER_NAME);
> +	strscpy(adpt->card->shortname, "Microchip INIC");
>  	snprintf(adpt->card->longname, sizeof(adpt->card->longname),
>  		 "%s at %s", adpt->card->shortname, iface->description);
>  skip_adpt_alloc: