arm64: dts: qcom: sm8750: wire UFS to ice instance

[PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance

Posted by Kuldeep Singh 1 month, 2 weeks ago

The Inline Crypto Engine (ICE) exists as a standalone DT node, but the
UFS node lacks the required qcom,ice phandle reference.

Add the qcom,ice property to explicitly associate the UFS controller
with its ICE instance.

Fixes: d288abc3a70e ("arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC")
Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
---
Validations:
* Driver probe
* FBE with standard keys. 
---
 arch/arm64/boot/dts/qcom/sm8750.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index 18fb52c14acd..4ea7f6b7e20d 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -5396,6 +5396,7 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 			phy-names = "ufsphy";
 
 			#reset-cells = <1>;
+			qcom,ice = <&ice>;
 
 			status = "disabled";
 

---
base-commit: 39704f00f747aba3144289870b5fd8ac230a9aaf
change-id: 20260428-sm8750_ice_dt_fix-d32c838c0c3b

Best regards,
--  
Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance

Posted by Kuldeep Singh 3 weeks, 5 days ago

On 29-04-2026 15:05, Kuldeep Singh wrote:
> The Inline Crypto Engine (ICE) exists as a standalone DT node, but the
> UFS node lacks the required qcom,ice phandle reference.
> 
> Add the qcom,ice property to explicitly associate the UFS controller
> with its ICE instance.
> 
> Fixes: d288abc3a70e ("arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC")
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>

Bjorn, kind reminder to review and pick the fix patch.
This is required for ufs-ice to work for standard/wrapped keys which
isn't in working stage right now.

-- 
Regards
Kuldeep

Re: [PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance

Posted by Wenjia Zhang 1 month, 1 week ago

On 4/29/2026 5:35 PM, Kuldeep Singh wrote:
> The Inline Crypto Engine (ICE) exists as a standalone DT node, but the
> UFS node lacks the required qcom,ice phandle reference.
>
> Add the qcom,ice property to explicitly associate the UFS controller
> with its ICE instance.
>
> Fixes: d288abc3a70e ("arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC")
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> ---
> Validations:
> * Driver probe
> * FBE with standard keys.
> ---
>   arch/arm64/boot/dts/qcom/sm8750.dtsi | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index 18fb52c14acd..4ea7f6b7e20d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -5396,6 +5396,7 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>   			phy-names = "ufsphy";
>   
>   			#reset-cells = <1>;
> +			qcom,ice = <&ice>;
>   
>   			status = "disabled";
>   
>
> ---
> base-commit: 39704f00f747aba3144289870b5fd8ac230a9aaf
> change-id: 20260428-sm8750_ice_dt_fix-d32c838c0c3b
>
> Best regards,
> --
> Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>

Tested-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com> # on sm8750-mtp

Already validated the standard key and wrappred key.

Regards,
Wenjia

Re: [PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance

Posted by Konrad Dybcio 1 month, 2 weeks ago

On 4/29/26 11:35 AM, Kuldeep Singh wrote:
> The Inline Crypto Engine (ICE) exists as a standalone DT node, but the
> UFS node lacks the required qcom,ice phandle reference.
> 
> Add the qcom,ice property to explicitly associate the UFS controller
> with its ICE instance.
> 
> Fixes: d288abc3a70e ("arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC")
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad