[PATCH] platform/x86: pcengines-apuv2: reduce indiraction in swnode assignment

Bartosz Golaszewski posted 1 patch 1 month, 2 weeks ago
drivers/platform/x86/pcengines-apuv2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] platform/x86: pcengines-apuv2: reduce indiraction in swnode assignment
Posted by Bartosz Golaszewski 1 month, 2 weeks ago
struct platform_device_info now has the 'swnode' field allowing passing
software nodes directly to platform_device_register_full() without going
through software_node_fwnode(). It supports both registered and
unregistered software nodes. Use it to drop one layer of indirection.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 drivers/platform/x86/pcengines-apuv2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index 3f19589d1ba032d8360a56a6f8efef14c8e87049..8ac5f719c5a39b3511d7f4e4d752adc9d99eabfc 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -262,7 +262,7 @@ static struct platform_device * __init apu_create_pdev(const char *name,
 		.id = PLATFORM_DEVID_NONE,
 		.data = data,
 		.size_data = size,
-		.fwnode = software_node_fwnode(swnode),
+		.swnode = swnode,
 	};
 	struct platform_device *pdev;
 	int err;

---
base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
change-id: 20260429-pcengines-apuv2-swnodes-c20c9279b044

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Re: [PATCH] platform/x86: pcengines-apuv2: reduce indiraction in swnode assignment
Posted by Ilpo Järvinen 1 month, 1 week ago
On Wed, 29 Apr 2026 11:46:01 +0200, Bartosz Golaszewski wrote:

> struct platform_device_info now has the 'swnode' field allowing passing
> software nodes directly to platform_device_register_full() without going
> through software_node_fwnode(). It supports both registered and
> unregistered software nodes. Use it to drop one layer of indirection.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: pcengines-apuv2: reduce indiraction in swnode assignment
      commit: fa84425e53c43c8a17ac2af2c8f99202f4e1ee7e

--
 i.
Re: [PATCH] platform/x86: pcengines-apuv2: reduce indiraction in swnode assignment
Posted by Dmitry Torokhov 1 month, 2 weeks ago
On Wed, Apr 29, 2026 at 11:46:01AM +0200, Bartosz Golaszewski wrote:
> struct platform_device_info now has the 'swnode' field allowing passing
> software nodes directly to platform_device_register_full() without going
> through software_node_fwnode(). It supports both registered and
> unregistered software nodes. Use it to drop one layer of indirection.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks.

-- 
Dmitry