[PATCH v3] ALSA: usb-audio: Add quirk for PreSonus AudioBox USB

Abhinav Mahadevan posted 1 patch 1 month, 2 weeks ago
sound/usb/quirks-table.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[PATCH v3] ALSA: usb-audio: Add quirk for PreSonus AudioBox USB
Posted by Abhinav Mahadevan 1 month, 2 weeks ago
The PreSonus AudioBox USB (0x194f:0x0301) only advertises S24_3LE
for both playback and capture interfaces. Add an explicit entry to
the quirks table to ensure correct format handling for this device.

Fixes: 099cce2b5 ("ALSA: usb-audio: Add quirk for PreSonus AudioBox USB")
Signed-off-by: Abhinav Mahadevan <abhi220204@gmail.com>
---

v3: Update patch description to accurately reflect the change
(adding a quirks table entry, not fixing format negotiation).
Add Fixes tag referencing the original commit.

v2: Fix placement - entry was incorrectly inside a #if 0 disabled
block. Moved to after the #endif /* disabled */.

 sound/usb/quirks-table.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index 803e03d4d..4e9cfff40 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -2652,6 +2652,9 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
+
+#endif /* disabled */
+
 {
 	/*
 	 * The AudioBox USB advertises S24_3LE as the only supported format
@@ -2700,7 +2703,6 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
-#endif /* disabled */
 
 {
 	/*
-- 
2.43.0
Re: [PATCH v3] ALSA: usb-audio: Add quirk for PreSonus AudioBox USB
Posted by Takashi Iwai 1 month, 2 weeks ago
On Tue, 28 Apr 2026 16:33:38 +0200,
Abhinav Mahadevan wrote:
> 
> The PreSonus AudioBox USB (0x194f:0x0301) only advertises S24_3LE
> for both playback and capture interfaces. Add an explicit entry to
> the quirks table to ensure correct format handling for this device.
> 
> Fixes: 099cce2b5 ("ALSA: usb-audio: Add quirk for PreSonus AudioBox USB")

Non-existing commit ID for the upstream.
And, you'll have to put 12 letters SHA id here.

> Signed-off-by: Abhinav Mahadevan <abhi220204@gmail.com>
> ---
> 
> v3: Update patch description to accurately reflect the change
> (adding a quirks table entry, not fixing format negotiation).

... and it's not exactly what *this* patch does!
You don't have to repeat the same text you already gave in the
original commit at all.

Basically this patch *corrects* the position of the quirk entry that
was mistakenly put into the disabled block in the previous commit.

Please resubmit with a proper patch description and Fixes tag again.


thanks,

Takashi