[PATCH RESEND] firmware: imx: sm-misc: Make scmi_imx_misc_ctrl_nb variable static

Krzysztof Kozlowski posted 1 patch 1 month, 2 weeks ago
drivers/firmware/imx/sm-misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH RESEND] firmware: imx: sm-misc: Make scmi_imx_misc_ctrl_nb variable static
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
File-scope 'scmi_imx_misc_ctrl_nb' is not used outside of this unit, so
make it static to silence sparse warning:

  sm-misc.c:19:23: warning: symbol 'scmi_imx_misc_ctrl_nb' was not declared. Should it be static?

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/firmware/imx/sm-misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/imx/sm-misc.c b/drivers/firmware/imx/sm-misc.c
index 16b5ff833d21..ac9af824c2d4 100644
--- a/drivers/firmware/imx/sm-misc.c
+++ b/drivers/firmware/imx/sm-misc.c
@@ -16,7 +16,7 @@
 
 static const struct scmi_imx_misc_proto_ops *imx_misc_ctrl_ops;
 static struct scmi_protocol_handle *ph;
-struct notifier_block scmi_imx_misc_ctrl_nb;
+static struct notifier_block scmi_imx_misc_ctrl_nb;
 
 static const char * const rst_imx95[] = {
 	"cm33_lockup", "cm33_swreq", "cm7_lockup", "cm7_swreq", "fccu",
-- 
2.51.0
Re: [PATCH RESEND] firmware: imx: sm-misc: Make scmi_imx_misc_ctrl_nb variable static
Posted by Frank.Li@oss.nxp.com 3 weeks, 2 days ago
From: Frank Li <Frank.Li@nxp.com>


On Tue, 28 Apr 2026 15:57:33 +0200, Krzysztof Kozlowski wrote:
> File-scope 'scmi_imx_misc_ctrl_nb' is not used outside of this unit, so
> make it static to silence sparse warning:
> 
>   sm-misc.c:19:23: warning: symbol 'scmi_imx_misc_ctrl_nb' was not declared. Should it be static?

Applied, thanks!

[1/1] firmware: imx: sm-misc: Make scmi_imx_misc_ctrl_nb variable static
      commit: 2430f2080f2a4e45b69befba26ef726d62180bba

Best regards,
-- 
Frank Li <Frank.Li@nxp.com>