1. Patchew
  2. linux
  3. View series

[PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle

Dmitry Baryshkov posted 1 patch 1 month, 2 weeks ago
There is a newer version of this series
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle
Posted by Dmitry Baryshkov 1 month, 2 weeks ago 
With the default PSCI suspend value for cluster idle state Lenovo Yoga
C630 isn't stable enough. For example it might reset if display device
isn't probed early enough. Drop one of the bits from the PSCI suspend
value to make C630 work in stable way.

Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index e41200839dbe..e6c67016552a 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -347,6 +347,10 @@ &cdsp_pas {
 	status = "okay";
 };
 
+&cluster_sleep_0 {
+	arm,psci-suspend-param = <0x41003244>;
+};
+
 &gcc {
 	protected-clocks = <GCC_QSPI_CORE_CLK>,
 			   <GCC_QSPI_CORE_CLK_SRC>,

---
base-commit: bee6ea30c48788e18348309f891ed8afbf7702ac
change-id: 20260428-c630-fix-idle-ed0a161d4050

Best regards,
--  
With best wishes
Dmitry
Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle
Posted by Konrad Dybcio 1 month ago 
On 4/28/26 9:36 PM, Dmitry Baryshkov wrote:
> With the default PSCI suspend value for cluster idle state Lenovo Yoga
> C630 isn't stable enough. For example it might reset if display device
> isn't probed early enough. Drop one of the bits from the PSCI suspend
> value to make C630 work in stable way.
> 
> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index e41200839dbe..e6c67016552a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -347,6 +347,10 @@ &cdsp_pas {
>  	status = "okay";
>  };
>  
> +&cluster_sleep_0 {
> +	arm,psci-suspend-param = <0x41003244>;
> +};

Is it better if you do hack in a

qmp_send(qmp, "{class: cx_mol, res: cx, val: mol}");

somewhere?

Konrad
Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle
Posted by Dmitry Baryshkov 1 month ago 
On 15/05/2026 14:00, Konrad Dybcio wrote:
> On 4/28/26 9:36 PM, Dmitry Baryshkov wrote:
>> With the default PSCI suspend value for cluster idle state Lenovo Yoga
>> C630 isn't stable enough. For example it might reset if display device
>> isn't probed early enough. Drop one of the bits from the PSCI suspend
>> value to make C630 work in stable way.
>>
>> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>> index e41200839dbe..e6c67016552a 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>> @@ -347,6 +347,10 @@ &cdsp_pas {
>>   	status = "okay";
>>   };
>>   
>> +&cluster_sleep_0 {
>> +	arm,psci-suspend-param = <0x41003244>;
>> +};
> 
> Is it better if you do hack in a
> 
> qmp_send(qmp, "{class: cx_mol, res: cx, val: mol}");

Any clarification? Then I can try hacking it in.

> 
> somewhere?
> 
> Konrad
> 
> 
> 


-- 
With best wishes
Dmitry
Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle
Posted by Konrad Dybcio 1 month ago 
On 5/15/26 1:01 PM, Dmitry Baryshkov wrote:
> On 15/05/2026 14:00, Konrad Dybcio wrote:
>> On 4/28/26 9:36 PM, Dmitry Baryshkov wrote:
>>> With the default PSCI suspend value for cluster idle state Lenovo Yoga
>>> C630 isn't stable enough. For example it might reset if display device
>>> isn't probed early enough. Drop one of the bits from the PSCI suspend
>>> value to make C630 work in stable way.
>>>
>>> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>> index e41200839dbe..e6c67016552a 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>> @@ -347,6 +347,10 @@ &cdsp_pas {
>>>       status = "okay";
>>>   };
>>>   +&cluster_sleep_0 {
>>> +    arm,psci-suspend-param = <0x41003244>;
>>> +};
>>
>> Is it better if you do hack in a
>>
>> qmp_send(qmp, "{class: cx_mol, res: cx, val: mol}");
> 
> Any clarification? Then I can try hacking it in.

This will send a message to AOSS to intrusct it to prevent CX from
collapsing

You'd need this somewhere early enough so as not to crash

alternatively, the good ol'

diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c
index 6d5bbeda0689..2fea94618839 100644
--- a/drivers/interconnect/qcom/sdm845.c
+++ b/drivers/interconnect/qcom/sdm845.c
@@ -1786,7 +1786,7 @@ static struct platform_driver qnoc_driver = {
        .driver = {
                .name = "qnoc-sdm845",
                .of_match_table = qnoc_of_match,
-               .sync_state = icc_sync_state,
+               //.sync_state = icc_sync_state,
        },
 };
 module_platform_driver(qnoc_driver);


should give you a similar result

Konrad
Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle
Posted by Dmitry Baryshkov 1 month ago 
On 15/05/2026 14:03, Konrad Dybcio wrote:
> On 5/15/26 1:01 PM, Dmitry Baryshkov wrote:
>> On 15/05/2026 14:00, Konrad Dybcio wrote:
>>> On 4/28/26 9:36 PM, Dmitry Baryshkov wrote:
>>>> With the default PSCI suspend value for cluster idle state Lenovo Yoga
>>>> C630 isn't stable enough. For example it might reset if display device
>>>> isn't probed early enough. Drop one of the bits from the PSCI suspend
>>>> value to make C630 work in stable way.
>>>>
>>>> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>>> index e41200839dbe..e6c67016552a 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>>> @@ -347,6 +347,10 @@ &cdsp_pas {
>>>>        status = "okay";
>>>>    };
>>>>    +&cluster_sleep_0 {
>>>> +    arm,psci-suspend-param = <0x41003244>;
>>>> +};
>>>
>>> Is it better if you do hack in a
>>>
>>> qmp_send(qmp, "{class: cx_mol, res: cx, val: mol}");
>>
>> Any clarification? Then I can try hacking it in.
> 
> This will send a message to AOSS to intrusct it to prevent CX from
> collapsing

This sounds like a dirty hack. I think, hacking psci-suspend-param is a 
lesser evil.

I know that we should spend time on understanding, what should vote on 
CX instead, but having the issue only on C630 doesn't really help. Maybe 
it will go away once I can sort out the gcc / dispcc / mdss issue on 
SDM845 & SM8150.

> 
> You'd need this somewhere early enough so as not to crash
> 
> alternatively, the good ol'
> 
> diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c
> index 6d5bbeda0689..2fea94618839 100644
> --- a/drivers/interconnect/qcom/sdm845.c
> +++ b/drivers/interconnect/qcom/sdm845.c
> @@ -1786,7 +1786,7 @@ static struct platform_driver qnoc_driver = {
>          .driver = {
>                  .name = "qnoc-sdm845",
>                  .of_match_table = qnoc_of_match,
> -               .sync_state = icc_sync_state,
> +               //.sync_state = icc_sync_state,
>          },
>   };
>   module_platform_driver(qnoc_driver);
> 
> 
> should give you a similar result
> 
> Konrad


-- 
With best wishes
Dmitry
Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle
Posted by Konrad Dybcio 1 month ago 
On 5/15/26 1:09 PM, Dmitry Baryshkov wrote:
> On 15/05/2026 14:03, Konrad Dybcio wrote:
>> On 5/15/26 1:01 PM, Dmitry Baryshkov wrote:
>>> On 15/05/2026 14:00, Konrad Dybcio wrote:
>>>> On 4/28/26 9:36 PM, Dmitry Baryshkov wrote:
>>>>> With the default PSCI suspend value for cluster idle state Lenovo Yoga
>>>>> C630 isn't stable enough. For example it might reset if display device
>>>>> isn't probed early enough. Drop one of the bits from the PSCI suspend
>>>>> value to make C630 work in stable way.
>>>>>
>>>>> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
>>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>>>> ---
>>>>>    arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++++
>>>>>    1 file changed, 4 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>>>> index e41200839dbe..e6c67016552a 100644
>>>>> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>>>> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>>>> @@ -347,6 +347,10 @@ &cdsp_pas {
>>>>>        status = "okay";
>>>>>    };
>>>>>    +&cluster_sleep_0 {
>>>>> +    arm,psci-suspend-param = <0x41003244>;
>>>>> +};
>>>>
>>>> Is it better if you do hack in a
>>>>
>>>> qmp_send(qmp, "{class: cx_mol, res: cx, val: mol}");
>>>
>>> Any clarification? Then I can try hacking it in.
>>
>> This will send a message to AOSS to intrusct it to prevent CX from
>> collapsing
> 
> This sounds like a dirty hack. I think, hacking psci-suspend-param is a lesser evil.

Yes, that dirty hack is supposed to help us understand why this is an issue
in the first place. Especially since it only came around at some point
(although I suppose you're not really happy with spending a day bisecting
when exactly)

> I know that we should spend time on understanding, what should vote on CX instead, but having the issue only on C630 doesn't really help. Maybe it will go away once I can sort out the gcc / dispcc / mdss issue on SDM845 & SM8150.

If it's a "not enough votes" type issue, it can vary from device to
device, from unit to unit, depending on your luck in the silicon
lottery

Konrad
Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle
Posted by Dmitry Baryshkov 1 month ago 
On 15/05/2026 14:13, Konrad Dybcio wrote:
> On 5/15/26 1:09 PM, Dmitry Baryshkov wrote:
>> On 15/05/2026 14:03, Konrad Dybcio wrote:
>>> On 5/15/26 1:01 PM, Dmitry Baryshkov wrote:
>>>> On 15/05/2026 14:00, Konrad Dybcio wrote:
>>>>> On 4/28/26 9:36 PM, Dmitry Baryshkov wrote:
>>>>>> With the default PSCI suspend value for cluster idle state Lenovo Yoga
>>>>>> C630 isn't stable enough. For example it might reset if display device
>>>>>> isn't probed early enough. Drop one of the bits from the PSCI suspend
>>>>>> value to make C630 work in stable way.
>>>>>>
>>>>>> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
>>>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>>>>> ---
>>>>>>     arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++++
>>>>>>     1 file changed, 4 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>>>>> index e41200839dbe..e6c67016552a 100644
>>>>>> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>>>>> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>>>>>> @@ -347,6 +347,10 @@ &cdsp_pas {
>>>>>>         status = "okay";
>>>>>>     };
>>>>>>     +&cluster_sleep_0 {
>>>>>> +    arm,psci-suspend-param = <0x41003244>;
>>>>>> +};
>>>>>
>>>>> Is it better if you do hack in a
>>>>>
>>>>> qmp_send(qmp, "{class: cx_mol, res: cx, val: mol}");
>>>>
>>>> Any clarification? Then I can try hacking it in.
>>>
>>> This will send a message to AOSS to intrusct it to prevent CX from
>>> collapsing
>>
>> This sounds like a dirty hack. I think, hacking psci-suspend-param is a lesser evil.
> 
> Yes, that dirty hack is supposed to help us understand why this is an issue
> in the first place. Especially since it only came around at some point
> (although I suppose you're not really happy with spending a day bisecting
> when exactly)

A similar patch has, I think, always been in any laptop tree targeting 
c630. It could having been a disablement of sync state, a removal of 
cluster sleep or something similar.

> 
>> I know that we should spend time on understanding, what should vote on CX instead, but having the issue only on C630 doesn't really help. Maybe it will go away once I can sort out the gcc / dispcc / mdss issue on SDM845 & SM8150.
> 
> If it's a "not enough votes" type issue, it can vary from device to
> device, from unit to unit, depending on your luck in the silicon
> lottery
> 
> Konrad


-- 
With best wishes
Dmitry
Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle
Posted by Dmitry Baryshkov 4 days, 15 hours ago 
On Fri, May 15, 2026 at 02:15:55PM +0300, Dmitry Baryshkov wrote:
> On 15/05/2026 14:13, Konrad Dybcio wrote:
> > On 5/15/26 1:09 PM, Dmitry Baryshkov wrote:
> > > On 15/05/2026 14:03, Konrad Dybcio wrote:
> > > > On 5/15/26 1:01 PM, Dmitry Baryshkov wrote:
> > > > > On 15/05/2026 14:00, Konrad Dybcio wrote:
> > > > > > On 4/28/26 9:36 PM, Dmitry Baryshkov wrote:
> > > > > > > With the default PSCI suspend value for cluster idle state Lenovo Yoga
> > > > > > > C630 isn't stable enough. For example it might reset if display device
> > > > > > > isn't probed early enough. Drop one of the bits from the PSCI suspend
> > > > > > > value to make C630 work in stable way.
> > > > > > > 
> > > > > > > Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
> > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > > > > > > ---
> > > > > > >     arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++++
> > > > > > >     1 file changed, 4 insertions(+)
> > > > > > > 
> > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > > > > > > index e41200839dbe..e6c67016552a 100644
> > > > > > > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > > > > > > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > > > > > > @@ -347,6 +347,10 @@ &cdsp_pas {
> > > > > > >         status = "okay";
> > > > > > >     };
> > > > > > >     +&cluster_sleep_0 {
> > > > > > > +    arm,psci-suspend-param = <0x41003244>;
> > > > > > > +};
> > > > > > 
> > > > > > Is it better if you do hack in a
> > > > > > 
> > > > > > qmp_send(qmp, "{class: cx_mol, res: cx, val: mol}");
> > > > > 
> > > > > Any clarification? Then I can try hacking it in.
> > > > 
> > > > This will send a message to AOSS to intrusct it to prevent CX from
> > > > collapsing
> > > 
> > > This sounds like a dirty hack. I think, hacking psci-suspend-param is a lesser evil.
> > 
> > Yes, that dirty hack is supposed to help us understand why this is an issue
> > in the first place. Especially since it only came around at some point
> > (although I suppose you're not really happy with spending a day bisecting
> > when exactly)
> 
> A similar patch has, I think, always been in any laptop tree targeting c630.
> It could having been a disablement of sync state, a removal of cluster sleep
> or something similar.

And gracious ping.... Can we sort this out somehow?

> 
> > 
> > > I know that we should spend time on understanding, what should vote on CX instead, but having the issue only on C630 doesn't really help. Maybe it will go away once I can sort out the gcc / dispcc / mdss issue on SDM845 & SM8150.
> > 
> > If it's a "not enough votes" type issue, it can vary from device to
> > device, from unit to unit, depending on your luck in the silicon
> > lottery
> > 
> > Konrad
> 
> 
> -- 
> With best wishes
> Dmitry

-- 
With best wishes
Dmitry
Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle
Posted by Abel Vesa 1 month, 2 weeks ago 
On 26-04-28 22:36:49, Dmitry Baryshkov wrote:
> With the default PSCI suspend value for cluster idle state Lenovo Yoga
> C630 isn't stable enough. For example it might reset if display device
> isn't probed early enough. Drop one of the bits from the PSCI suspend
> value to make C630 work in stable way.

Now I'm curious how you got to this new value.

> 
> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

Anyway:

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle
Posted by Dmitry Baryshkov 1 month, 2 weeks ago 
On Tue, Apr 28, 2026 at 11:38:30PM +0300, Abel Vesa wrote:
> On 26-04-28 22:36:49, Dmitry Baryshkov wrote:
> > With the default PSCI suspend value for cluster idle state Lenovo Yoga
> > C630 isn't stable enough. For example it might reset if display device
> > isn't probed early enough. Drop one of the bits from the PSCI suspend
> > value to make C630 work in stable way.
> 
> Now I'm curious how you got to this new value.

Good pointer. Let me send a more obvious change (which I probably should
have checked first).

> 
> > 
> > Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> 
> Anyway:
> 
> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.