staging: rtl8723bs: hal: add blank line after declaration

[PATCH] staging: rtl8723bs: hal: add blank line after declaration

Posted by Shyam Sunder Reddy Padira 1 month, 2 weeks ago

Add missing  blank line after variable declarations to comply with
kernel coding style.

Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
index 6d5e531505f9..7fac1c2ba8e0 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
@@ -575,6 +575,7 @@ static void phy_SetRegBW_8723B(
 )
 {
 	u16 RegRfMod_BW, u2tmp = 0;
+
 	RegRfMod_BW = rtw_read16(Adapter, REG_TRXPTCL_CTL_8723B);
 
 	switch (CurrentBW) {
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: hal: add blank line after declaration

Posted by Greg KH 1 month, 1 week ago

On Tue, Apr 28, 2026 at 12:04:56AM +0530, Shyam Sunder Reddy Padira wrote:
> Add missing  blank line after variable declarations to comply with
> kernel coding style.
> 
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> index 6d5e531505f9..7fac1c2ba8e0 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> @@ -575,6 +575,7 @@ static void phy_SetRegBW_8723B(
>  )
>  {
>  	u16 RegRfMod_BW, u2tmp = 0;
> +
>  	RegRfMod_BW = rtw_read16(Adapter, REG_TRXPTCL_CTL_8723B);
>  
>  	switch (CurrentBW) {
> -- 
> 2.43.0
> 
> 

Does not apply to my tree :(

Re: [PATCH] staging: rtl8723bs: hal: add blank line after declaration

Posted by Luka Gejak 1 month, 2 weeks ago

> Add missing  blank line after variable declarations to comply with
> kernel coding style.
> 
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> index 6d5e531505f9..7fac1c2ba8e0 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> @@ -575,6 +575,7 @@ static void phy_SetRegBW_8723B(
>  )
>  {
>  	u16 RegRfMod_BW, u2tmp = 0;
> +
>  	RegRfMod_BW = rtw_read16(Adapter, REG_TRXPTCL_CTL_8723B);
>  
>  	switch (CurrentBW) {
> -- 
> 2.43.0
>

Hi Shyam,
I am sorry to inform you but someone has does this change already in 
the past. You are probably working on mainline or older tree, which is
why this change wasn't present for you. Please work on top of 
staging-next branch in the future.
Best regards,
Luka Gejak